From: Ulf Hansson <ulf.hansson@linaro.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: renesas_sdhi: enable bigger data ports where available
Date: Fri, 17 Oct 2025 15:30:11 +0200 [thread overview]
Message-ID: <CAPDyKFroUEASykqp-cPHnhDLOvox9jPQHCGucpTx6KMjwK9Qkw@mail.gmail.com> (raw)
In-Reply-To: <20250923161915.3172-2-wsa+renesas@sang-engineering.com>
On Tue, 23 Sept 2025 at 18:19, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> R-Car Gen2 SoCs have a 32 bit dataport, V3M even 64 bit. Make use of
> the bigger size in the rare case DMA is failing.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
>
> Tested on a Renesas Lager board (Gen2) and Eagle + extension board
> (V3M). SDHI driver was hacked to avoid DMA and use PIO.
>
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 3 ++-
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> index 9e3ed0bcddd6..73c84fd8a2d8 100644
> --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> @@ -124,7 +124,8 @@ static const struct renesas_sdhi_of_data of_data_rcar_gen3 = {
>
> static const struct renesas_sdhi_of_data of_data_rcar_gen3_no_sdh_fallback = {
> .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_CLK_ACTUAL |
> - TMIO_MMC_HAVE_CBSY | TMIO_MMC_MIN_RCAR2,
> + TMIO_MMC_HAVE_CBSY | TMIO_MMC_MIN_RCAR2 |
> + TMIO_MMC_64BIT_DATA_PORT,
> .capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |
> MMC_CAP_CMD23 | MMC_CAP_WAIT_WHILE_BUSY,
> .capabilities2 = MMC_CAP2_NO_WRITE_PROTECT | MMC_CAP2_MERGE_CAPABLE,
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index 822a310c9bba..543ad1d0ed1c 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -60,7 +60,8 @@ static struct renesas_sdhi_scc rcar_gen2_scc_taps[] = {
>
> static const struct renesas_sdhi_of_data of_rcar_gen2_compatible = {
> .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_CLK_ACTUAL |
> - TMIO_MMC_HAVE_CBSY | TMIO_MMC_MIN_RCAR2,
> + TMIO_MMC_HAVE_CBSY | TMIO_MMC_MIN_RCAR2 |
> + TMIO_MMC_32BIT_DATA_PORT,
> .capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |
> MMC_CAP_CMD23 | MMC_CAP_WAIT_WHILE_BUSY,
> .capabilities2 = MMC_CAP2_NO_WRITE_PROTECT,
> --
> 2.47.2
>
prev parent reply other threads:[~2025-10-17 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 16:17 [PATCH] mmc: renesas_sdhi: enable bigger data ports where available Wolfram Sang
2025-10-17 13:30 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFroUEASykqp-cPHnhDLOvox9jPQHCGucpTx6KMjwK9Qkw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).