From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0C71336ED5; Wed, 17 Dec 2025 08:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765959378; cv=none; b=OorGGpwNXFnIJjfqGP0/dx8AvLA1+jom4DHOn4myJfZRPE5feeMmBgbRe73ZbixzAAiMWEDtaDMTHMQXTxbocOx4cnWlf3cRzq25bp9aGI+iwhaKBkeRI8b3Ud0BwJNJ8/BFEd4aliuROtposR4SIJ6kGMumbdmnC2x2ItljkCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765959378; c=relaxed/simple; bh=K/OkgzUT7VmdZSGn5RyTgWoV59PXWiPM+6lt/Aikx4Q=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=lCm7g4+8ss/ARLYh2zWJSnOazLyYUd4BBJp4SHpDE2pxh4LUeBVW9SJDvLyYsNSH5C2Z768AZmSaR/5KyDr+n/aH/Ccco8ciljke4wJDWp+aEola1BXY+H5zEWsYOyXC5NSaQ8t+nHAYC0WCEmNkx5v5qCTzegLQmeZW47iQjJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Ayn6HVBx; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Ayn6HVBx" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 44A334E41C50; Wed, 17 Dec 2025 08:16:11 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E824A6072F; Wed, 17 Dec 2025 08:16:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9B75111950295; Wed, 17 Dec 2025 09:15:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765959364; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ujozvAR/egQa+0OwQ9Aeym97mJvVMjkPUclMUt6mE28=; b=Ayn6HVBxPDFZQPsofDALTubSwQYYhWe28r/JxNzT2jwfqVPYB7L1I838PbDqUA2VUIhOqj T/p4Xd7+cEZfKoKVw2hurXHe5vkPMT19dkYgFzdXbeOY64a8mz9tBTIzqiLJh+GRQDwPsD VjAj9SUjWDu+mnsDdX0xgZ/mlF+pzcRkZRkq2CszNx2kC9Ltjs6UjvGcm1OTBOr2Np/bLn NV1CdrC5Y70iuSm3WZgQtjFIEPVbj0wIEJonCx4y0ASyFHkHSoAirTeo3ptVJUHuNJrcDq 2uOgFYfMi01DRPjYnMRS09aqCaxaU09vJzqAbOE6JqfuzC65rEyPdzG9DDpNlg== Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 17 Dec 2025 09:15:48 +0100 Message-Id: Subject: Re: [PATCH v2 17/26] drm/meson: encoder_*: use devm_of_drm_get_bridge() to put the next bridge Cc: "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Jonathan Corbet" , "Alexey Brodkin" , "Phong LE" , "Liu Ying" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Adrien Grassein" , "Laurent Pinchart" , "Tomi Valkeinen" , "Kieran Bingham" , "Geert Uytterhoeven" , "Magnus Damm" , "Kevin Hilman" , "Jerome Brunet" , "Chun-Kuang Hu" , "Philipp Zabel" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Anitha Chrisanthus" , "Inki Dae" , "Seung-Woo Kim" , "Kyungmin Park" , "Krzysztof Kozlowski" , "Alim Akhtar" , "Hui Pu" , "Thomas Petazzoni" , "Louis Chauvet" , , , , , , , , , To: "Martin Blumenstingl" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251128-drm-bridge-alloc-getput-drm_of_find_bridge-v2-0-88f8a107eca2@bootlin.com> <20251128-drm-bridge-alloc-getput-drm_of_find_bridge-v2-17-88f8a107eca2@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 Hello Martin, On Wed Dec 17, 2025 at 1:01 AM CET, Martin Blumenstingl wrote: > Hi Luca, > > On Tue, Dec 16, 2025 at 1:46=E2=80=AFPM Luca Ceresoli wrote: > [...] >> > What I'm not sure about is how this series interacts with >> > devm_drm_of_get_bridge() which is why I'm asking before cooking a >> > patch. >> >> Apologies for the long delay in getting back to you. You might have noti= ced >> some discussion about the overall approach, and I waited for it to settl= e. > That hasn't gone unnoticed! > >> About devm_drm_of_get_bridge(), it is a very different function so it do= es >> not affect this series. The name similarity is confusing indeed, but >> devm_of_drm_get_bridge() has been removed from my approach, so one less >> source of confusion. > I have to confess that I'm still confused. drivers/gpu/drm/drm_bridge.c s= tates: > "Display drivers are responsible for linking encoders with the first brid= ge > in the chains. This is done by acquiring the appropriate bridge with > devm_drm_of_get_bridge(). Once acquired, the bridge shall be attached to= the > encoder with a call to drm_bridge_attach(). > > Bridges are responsible for linking themselves with the next bridge in t= he > chain, if any. This is done the same way as for encoders, with the call = to > drm_bridge_attach() occurring in the &drm_bridge_funcs.attach operation.= " > Does this mean your series effectively deprecates devm_drm_of_get_bridge(= )? Well spotted! I theory yes, my series kind of implicitly deprecates other functions based on it, including drm_of_find_panel_or_bridge() and *_of_get_bridge(), which are problematic in case of bridge removal. But before explicitly deprecating them we need a good alternative. Which in turn depends on the rework of the panel_bridge lifetime, which was also discussed with Maxime in the same thread. Bottom line: for now *_of_get_bridge() usage is still OK, but stay tuned. :-) >> I'm soon sending v3, and I have updated my patch to >> eson_encoder_{cvbs,dsi,hdmi}.c, actually splitting it in 3. I'd be grate= ful >> if you could reviewd and/ot test them when I send v3. But I don't think >> there is a need for you to send any patches related to this topic. > Regardless of the questions I still have around > devm_drm_of_get_bridge(): I'll give your patches a go in the next > days. Thank you, v3 is there awaiting you! Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com