Re: [PATCH v3 2/3] serial: 8250_em: Update RZ/V2M port type as PORT_16750

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, Feb 10, 2023 at 08:34:38PM +0000, Biju Das wrote:
> The UART IP found on RZ/V2M SoC is Register-compatible with the
> general-purpose 16750 UART chip. This patch updates RZ/V2M
> port type from 16550A->16750 and also enables 64-bytes fifo support.

LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> v2->v3:
>  * Replaced of_device_get_match_data()->device_get_match_data().
>  * Replaced of_device.h->property.h
>  * Dropped struct serial8250_em_hw_info *info from priv and started
>    using a local variable info in probe().
>  * Retained Rb tag from Ilpo as changes are trivial.
> v2:
>  * New patch
> ---
>  drivers/tty/serial/8250/8250_em.c | 28 ++++++++++++++++++++++++----
>  1 file changed, 24 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_em.c b/drivers/tty/serial/8250/8250_em.c
> index 9781bf73ed0c..69cd3b611501 100644
> --- a/drivers/tty/serial/8250/8250_em.c
> +++ b/drivers/tty/serial/8250/8250_em.c
> @@ -9,6 +9,7 @@
>  #include <linux/io.h>
>  #include <linux/module.h>
>  #include <linux/mod_devicetable.h>
> +#include <linux/property.h>
>  #include <linux/serial_8250.h>
>  #include <linux/serial_reg.h>
>  #include <linux/platform_device.h>
> @@ -19,6 +20,11 @@
>  #define UART_DLL_EM 9
>  #define UART_DLM_EM 10
>  
> +struct serial8250_em_hw_info {
> +	unsigned int type;
> +	upf_t flags;
> +};
> +
>  struct serial8250_em_priv {
>  	int line;
>  };
> @@ -76,6 +82,7 @@ static void serial8250_em_serial_dl_write(struct uart_8250_port *up, int value)
>  
>  static int serial8250_em_probe(struct platform_device *pdev)
>  {
> +	const struct serial8250_em_hw_info *info;
>  	struct serial8250_em_priv *priv;
>  	struct device *dev = &pdev->dev;
>  	struct uart_8250_port up;
> @@ -83,6 +90,8 @@ static int serial8250_em_probe(struct platform_device *pdev)
>  	struct clk *sclk;
>  	int irq, ret;
>  
> +	info = device_get_match_data(dev);
> +
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0)
>  		return irq;
> @@ -102,8 +111,8 @@ static int serial8250_em_probe(struct platform_device *pdev)
>  	memset(&up, 0, sizeof(up));
>  	up.port.mapbase = regs->start;
>  	up.port.irq = irq;
> -	up.port.type = PORT_UNKNOWN;
> -	up.port.flags = UPF_BOOT_AUTOCONF | UPF_FIXED_PORT | UPF_IOREMAP;
> +	up.port.type = info->type;
> +	up.port.flags = info->flags;
>  	up.port.dev = dev;
>  	up.port.private_data = priv;
>  
> @@ -132,9 +141,20 @@ static int serial8250_em_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static const struct serial8250_em_hw_info emma_mobile_uart_hw_info = {
> +	.type = PORT_UNKNOWN,
> +	.flags = UPF_BOOT_AUTOCONF | UPF_FIXED_PORT | UPF_IOREMAP,
> +};
> +
> +static const struct serial8250_em_hw_info rzv2m_uart_hw_info = {
> +	.type = PORT_16750,
> +	.flags = UPF_BOOT_AUTOCONF | UPF_FIXED_PORT | UPF_IOREMAP | UPF_FIXED_TYPE,
> +};
> +
>  static const struct of_device_id serial8250_em_dt_ids[] = {
> -	{ .compatible = "renesas,em-uart", },
> -	{},
> +	{ .compatible = "renesas,r9a09g011-uart", .data = &rzv2m_uart_hw_info },
> +	{ .compatible = "renesas,em-uart", .data = &emma_mobile_uart_hw_info },
> +	{ /* Sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, serial8250_em_dt_ids);
>  
> -- 
> 2.25.1
> 
> 

-- 
With Best Regards,
Andy Shevchenko