From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH LOCAL] arm64: renesas: defconfig: Restore graphical consoles
Date: Mon, 12 Jul 2021 14:21:35 +0300 [thread overview]
Message-ID: <YOwlv26H1pYVCny0@pendragon.ideasonboard.com> (raw)
In-Reply-To: <4a671ef00b3469f8b7ffd42309c3dfb1ccb8eb8a.1626085156.git.geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Mon, Jul 12, 2021 at 12:19:33PM +0200, Geert Uytterhoeven wrote:
> As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for
> CONFIG_FB"), CONFIG_FB is no longer auto-enabled.
>
> Restore support for graphical consoles by enabling it explicitly in the
> defconfig for Renesas R-Car Gen3 and RZ/G2 systems.
>
> Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Not intended for upstream merge.
Why not ? We have no KMS console driver yet, FB is currently the only
option.
> To be queued in topic/renesas-defconfig, unless the rcar-du experts
> consider CONFIG_FB to be no longer needed nor wanted on systems where
> graphics are provided by a DRM driver.
> ---
> arch/arm64/configs/renesas_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/renesas_defconfig b/arch/arm64/configs/renesas_defconfig
> index 27b55fcc3bbca4dc..2fc00cadc30eb26b 100644
> --- a/arch/arm64/configs/renesas_defconfig
> +++ b/arch/arm64/configs/renesas_defconfig
> @@ -243,6 +243,7 @@ CONFIG_DRM_I2C_ADV7511_AUDIO=y
> CONFIG_DRM_DW_HDMI_AHB_AUDIO=y
> CONFIG_DRM_DW_HDMI_I2S_AUDIO=y
> CONFIG_DRM_DW_HDMI_CEC=y
> +CONFIG_FB=y
> CONFIG_FB_MODE_HELPERS=y
> CONFIG_BACKLIGHT_CLASS_DEVICE=y
> CONFIG_BACKLIGHT_PWM=y
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-07-12 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 10:19 [PATCH LOCAL] arm64: renesas: defconfig: Restore graphical consoles Geert Uytterhoeven
2021-07-12 11:21 ` Laurent Pinchart [this message]
2021-07-12 11:36 ` Geert Uytterhoeven
2021-07-12 11:44 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOwlv26H1pYVCny0@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox