From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: renesas,etheravb: Update example to match reality
Date: Fri, 1 Oct 2021 19:43:39 +0200 [thread overview]
Message-ID: <YVdIy9JF3et1DFT8@bismarck.dyn.berto.se> (raw)
In-Reply-To: <7590361db25e8c8b22021d3a4e87f9d304773533.1633090409.git.geert+renesas@glider.be>
Hi Geert,
Thanks for your patch.
On 2021-10-01 14:13:55 +0200, Geert Uytterhoeven wrote:
> - Add missing clock-names property,
> - Add example compatible values for PHY subnode.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> index 4c927d2c17d35d1b..bda821065a2b631f 100644
> --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> @@ -287,6 +287,7 @@ examples:
> "ch13", "ch14", "ch15", "ch16", "ch17", "ch18",
> "ch19", "ch20", "ch21", "ch22", "ch23", "ch24";
> clocks = <&cpg CPG_MOD 812>;
> + clock-names = "fck";
> iommus = <&ipmmu_ds0 16>;
> power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> resets = <&cpg 812>;
> @@ -298,6 +299,8 @@ examples:
> #size-cells = <0>;
>
> phy0: ethernet-phy@0 {
> + compatible = "ethernet-phy-id0022.1622",
> + "ethernet-phy-ieee802.3-c22";
> rxc-skew-ps = <1500>;
> reg = <0>;
> interrupt-parent = <&gpio2>;
> --
> 2.25.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2021-10-01 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 12:13 [PATCH] dt-bindings: net: renesas,etheravb: Update example to match reality Geert Uytterhoeven
2021-10-01 17:43 ` Niklas Söderlund [this message]
2021-10-02 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVdIy9JF3et1DFT8@bismarck.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox