From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B0DC433FE for ; Mon, 11 Apr 2022 12:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245117AbiDKMC1 (ORCPT ); Mon, 11 Apr 2022 08:02:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231547AbiDKMC0 (ORCPT ); Mon, 11 Apr 2022 08:02:26 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B730E2A732; Mon, 11 Apr 2022 05:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649678412; x=1681214412; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sC8CyttMimPSNhIr3hh4HcfuM59Ph6N7lGNcafQdvcs=; b=jqXvzjSStgCyRqvoJe3HZnI+q2y3XJh8E6mUbYsEQEEljEfhy4N71v2t Ns+ZpiWLX9hm5jCu6qwfqnBROgzcQ3JRJGTDDX6nw4lGHB9DjZ6MMBGEl oOONbDcSSiNWXvQW+4QiqtLtEM5DjIHO4bNzE6AEEs/axwzY+anicEVds KpttVF73a/+vW9D3NZiiWT8jxdtVMKBrij3QxOh1dmUsaxBIlDjl9frR2 uWcvmeacufpMCpXRhrj6wmrem5IC0MvPc75mzIit3AUYI/PHBExqwm/zX l0ehMil4gbzh1ksUkyqamWiqcWouuLNL9as6GiLh8YCOPPirLpMQOx+Fu A==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="242684842" X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="242684842" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 05:00:12 -0700 X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="699346695" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 05:00:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1ndsed-001CQ3-RA; Mon, 11 Apr 2022 14:56:23 +0300 Date: Mon, 11 Apr 2022 14:56:23 +0300 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Qianggui Song , Geert Uytterhoeven , Marc Zyngier , Fabien Dessenne , Linus Walleij , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Bartosz Golaszewski , Philipp Zabel Subject: Re: [PATCH v4 05/13] pinctrl: samsung: Switch to use for_each_gpiochip_node() helper Message-ID: References: <20220401103604.8705-1-andriy.shevchenko@linux.intel.com> <20220401103604.8705-6-andriy.shevchenko@linux.intel.com> <3b527700-444e-1f6e-fee1-5cd6ed2ef7f9@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b527700-444e-1f6e-fee1-5cd6ed2ef7f9@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Sat, Apr 09, 2022 at 03:33:49PM +0200, Krzysztof Kozlowski wrote: > On 08/04/2022 17:39, Andy Shevchenko wrote: > > On Fri, Apr 08, 2022 at 05:22:21PM +0200, Krzysztof Kozlowski wrote: > >> On 01/04/2022 12:35, Andy Shevchenko wrote: > >>> Switch the code to use for_each_gpiochip_node() helper. > > > > (...) > > > >>> /* > >>> * Iterate over all driver pin banks to find one matching the name of node, > >>> * skipping optional "-gpio" node suffix. When found, assign node to the bank. > >>> */ > >>> -static void samsung_banks_of_node_get(struct device *dev, > >>> - struct samsung_pinctrl_drv_data *d, > >>> - struct device_node *node) > >>> +static void samsung_banks_node_get(struct device *dev, struct samsung_pinctrl_drv_data *d) > >> > >> This is worth simplification anyway, so please split it to separate patch. > > > > Not sure what to do and why it worth an additional churn. > > Makes this change smaller so it's easier to review. https://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-gpio-intel.git/log/?h=review-andy That's how it looks like. Tell me if it is what you have had in mind. -- With Best Regards, Andy Shevchenko