Re: [PATCH 2/3] kmstest: Support specifying pixel blend mode for planes

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Hayama-san,

Thank you for the patch.

On Mon, Jul 04, 2022 at 11:56:31AM +0900, Takanari Hayama wrote:
> Add an optional pixel blend mode argument to the atomic_plane_set()
> function to  specify the pixel blend mode for the plane.
> 
> Signed-off-by: Takanari Hayama <taki@igel.co.jp>
> ---
>  tests/kmstest.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kmstest.py b/tests/kmstest.py
> index 224c160e32fa..a39ceab3891b 100755
> --- a/tests/kmstest.py
> +++ b/tests/kmstest.py
> @@ -395,7 +395,7 @@ class KMSTest(object):
>          else:
>              return req.commit(0, True)
>  
> -    def atomic_plane_set(self, plane, crtc, source, destination, fb, alpha=None, zpos=None, sync=False):
> +    def atomic_plane_set(self, plane, crtc, source, destination, fb, alpha=None, zpos=None, blendmode=None, sync=False):

I'll add a line break while at it as the line is getting long.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>          req = AtomicRequest(self)
>          req.add(plane, {
>                      'FB_ID': fb.id,
> @@ -413,6 +413,8 @@ class KMSTest(object):
>              req.add(plane, 'alpha', alpha)
>          if zpos is not None:
>              req.add(plane, 'zpos', zpos)
> +        if blendmode is not None:
> +            req.add(plane, 'pixel blend mode', blendmode)
>          if sync:
>              return req.commit_sync()
>          else:

-- 
Regards,

Laurent Pinchart