From: Johan Hovold <johan@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [RFC PATCH 2/5] gnss: ubx: use new helper to remove open coded regulator handling
Date: Tue, 20 Jun 2023 11:08:39 +0200 [thread overview]
Message-ID: <ZJFslwLFNMmd9cw4@hovoldconsulting.com> (raw)
In-Reply-To: <ZJFrm1KYVfEDD9s1@shikoro>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Tue, Jun 20, 2023 at 11:04:27AM +0200, Wolfram Sang wrote:
> > I'm a bit torn about this one as I'm generally sceptical of devres and
> > especially helpers that enable or register resources, which just tends to
> > lead to subtle bugs.
>
> It is good to think twice with devres, but I also really like this
> helper. En-/Disabling the regulator matches the life cycle of the device
> itself. The boilerplate code it removes tends also to be error prone.
So can the "trival" devres conversions be:
https://lore.kernel.org/lkml/ZJFqCQ8bbBoX3l1g@hovoldconsulting.com
I meant to CC you on my reply there.
Johan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-06-20 9:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 6:43 [RFC PATCH 0/5] gnss: updates to support the Renesas KingFisher board Wolfram Sang
2023-05-23 6:43 ` [RFC PATCH 1/5] WIP: gnss: merge MTK driver into UBX driver Wolfram Sang
2023-06-12 11:35 ` Wolfram Sang
2023-06-20 7:13 ` Johan Hovold
2023-06-20 9:00 ` Wolfram Sang
2023-06-20 10:21 ` Wolfram Sang
2023-06-20 14:50 ` Johan Hovold
2023-05-23 6:43 ` [RFC PATCH 2/5] gnss: ubx: use new helper to remove open coded regulator handling Wolfram Sang
2023-06-20 8:48 ` Johan Hovold
2023-06-20 9:04 ` Wolfram Sang
2023-06-20 9:08 ` Johan Hovold [this message]
2023-05-23 6:43 ` [RFC PATCH 3/5] gnss: ubx: 'vcc' can be optional Wolfram Sang
2023-06-20 7:15 ` Johan Hovold
2023-06-20 9:04 ` Wolfram Sang
2023-05-23 6:43 ` [RFC PATCH 4/5] gnss: ubx: add support for the reset gpio Wolfram Sang
2023-06-20 7:17 ` Johan Hovold
2023-06-20 9:06 ` Wolfram Sang
2023-06-20 9:12 ` Johan Hovold
2023-06-20 9:41 ` Wolfram Sang
2023-06-20 10:05 ` Johan Hovold
2023-06-20 10:14 ` Wolfram Sang
2023-05-23 6:43 ` [RFC PATCH 5/5] arm64: dts: renesas: ulcb-kf: add node for GPS Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJFslwLFNMmd9cw4@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox