From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Biju Das" <biju.das.jz@bp.renesas.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Andreas Helbech Kleist" <andreaskleist@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v2 1/2] Input: exc3000 - Simplify probe()
Date: Mon, 17 Jul 2023 11:28:12 -0700 [thread overview]
Message-ID: <ZLWIPPAfeR1+KbeH@google.com> (raw)
In-Reply-To: <66228ad3-c087-418c-925f-b9fd4a60fb16@sirena.org.uk>
On Mon, Jul 17, 2023 at 07:15:50PM +0100, Mark Brown wrote:
> On Mon, Jul 17, 2023 at 04:35:02PM +0000, Biju Das wrote:
>
> > The .device_get_match_data callbacks are missing for I2C and SPI bus subsystems.
> > Can you please throw some lights on this?
>
> It's the first time I've ever heard of that callback, I don't know why
> whoever added it wouldn't have done those buses in particular or if it
> just didn't happen. Try adding it and if it works send the patches?
I think there is a disconnect. Right now device_get_match_data callbacks
are part of fwnode_operations. I was proposing to add another optional
device_get_match_data callback to 'struct bus_type' to allow individual
buses control how match data is handled, before (or after) jumping into
the fwnode-backed device_get_match_data callbacks.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-07-17 18:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 13:17 [PATCH v2 0/2] exc3000 driver enhancements Biju Das
2023-07-17 13:17 ` [PATCH v2 1/2] Input: exc3000 - Simplify probe() Biju Das
2023-07-17 15:58 ` Dmitry Torokhov
2023-07-17 16:35 ` Biju Das
2023-07-17 18:15 ` Mark Brown
2023-07-17 18:27 ` Biju Das
2023-07-17 18:28 ` Dmitry Torokhov [this message]
2023-07-17 18:45 ` Biju Das
2023-07-18 18:36 ` Dmitry Torokhov
2023-07-19 6:43 ` Biju Das
2023-07-21 22:10 ` Dmitry Torokhov
2023-07-22 17:51 ` Biju Das
2023-07-23 1:17 ` Dmitry Torokhov
2023-07-23 6:05 ` Biju Das
2023-07-23 6:50 ` Biju Das
2023-07-23 20:06 ` Dmitry Torokhov
2023-07-17 18:49 ` Mark Brown
2023-07-17 13:17 ` [PATCH v2 2/2] Input: exc3000 - Drop enum eeti_dev_id and split exc3000_info[] Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLWIPPAfeR1+KbeH@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andreaskleist@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-input@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox