From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A20C04A6A for ; Thu, 3 Aug 2023 12:07:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235681AbjHCMHG (ORCPT ); Thu, 3 Aug 2023 08:07:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232662AbjHCMHD (ORCPT ); Thu, 3 Aug 2023 08:07:03 -0400 Received: from mgamail.intel.com (unknown [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90A4C30E0; Thu, 3 Aug 2023 05:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691064403; x=1722600403; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TAPgztHRobpBw6gzSgekudQ1pJARsoQRiCukcu60D2I=; b=cHOLNpifVfmVavJjpmpSMDuSS9rRioTgMEtHfardFs8jWVrubz+xXJPM J8XxCmyjxJKANYOMzQ0lrudRrfQ0WbRGVmfRa9Loi7XY/0n7aX0yoTPUu fuvvckRLGTmZM9w14L4lI/t0DOXRnssClIoqp1jhEZPzZdS3BOUGGh8jN gGbWhbqJJW7yH0k+BItwA9HWOn6/2smSiHF18UCGArXv7LeXEebUDC0vN Q5rf8xK6tC/KYgFGE663LuSvBXfK2Vx/JNQkWNUPgvjVH0Ef7T8gr8GXh TGjxNmGr99UArsA+KV8OgfLIlCw6jy7UCLJ5fcB0/U+wyHAiCvKPywjPW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="400793181" X-IronPort-AV: E=Sophos;i="6.01,252,1684825200"; d="scan'208";a="400793181" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 05:06:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="843572813" X-IronPort-AV: E=Sophos;i="6.01,252,1684825200"; d="scan'208";a="843572813" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 03 Aug 2023 05:06:34 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qRX69-00BSsM-19; Thu, 03 Aug 2023 15:06:33 +0300 Date: Thu, 3 Aug 2023 15:06:33 +0300 From: Andy Shevchenko To: Biju Das , Andi Shyti Cc: Wolfram Sang , linux-i2c@vger.kernel.org, Geert Uytterhoeven , Dmitry Torokhov , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v5 RESEND 2/4] i2c: Add i2c_device_get_match_data() callback Message-ID: References: <20230803103102.323987-1-biju.das.jz@bp.renesas.com> <20230803103102.323987-3-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230803103102.323987-3-biju.das.jz@bp.renesas.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Aug 03, 2023 at 11:31:00AM +0100, Biju Das wrote: > Add i2c_device_get_match_data() callback to struct bus_type(). > > While at it, introduced i2c_get_match_data_helper() to avoid code > duplication with i2c_get_match_data(). It seems you are missing to Cc Andi for all these... (not your fault, rather unfortunately). Yes, while he is not directly involved into core changes the drivers are pretty much should consider this change. ... > data = device_get_match_data(&client->dev); > - if (!data) { > - match = i2c_match_id(driver->id_table, client); > - if (!match) > - return NULL; > + if (data) > + return data; > > - data = (const void *)match->driver_data; > - } > - > - return data; Looking at this, it _might_ make sense to split another patch to prepare for better difference here. - if (!data) { - match = i2c_match_id(driver->id_table, client); - if (!match) - return NULL; + if (data) + return data; + + match = i2c_match_id(driver->id_table, client); + if (!match) + return NULL; + + return (const void *)match->driver_data; Just play with this idea. -- With Best Regards, Andy Shevchenko