From: Wolfram Sang <wsa@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Amit Kucheria" <amitk@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 21/31] thermal: rcar: Convert to platform remove callback returning void
Date: Wed, 27 Sep 2023 21:40:38 +0200 [thread overview]
Message-ID: <ZRSFNk0k8Pm2VWVF@shikoro> (raw)
In-Reply-To: <20230927193736.2236447-22-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Wed, Sep 27, 2023 at 09:37:26PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-09-27 19:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 19:37 [PATCH 00/31] thermal: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 20/31] thermal: rcar_gen3: " Uwe Kleine-König
2023-09-27 19:40 ` Wolfram Sang
2023-09-28 8:21 ` Geert Uytterhoeven
2023-09-28 15:26 ` Niklas Söderlund
2023-09-27 19:37 ` [PATCH 21/31] thermal: rcar: " Uwe Kleine-König
2023-09-27 19:40 ` Wolfram Sang [this message]
2023-09-28 8:22 ` Geert Uytterhoeven
2023-09-28 15:26 ` Niklas Söderlund
2023-09-27 19:45 ` [PATCH 00/31] thermal: " Rafael J. Wysocki
2023-09-28 7:05 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRSFNk0k8Pm2VWVF@shikoro \
--to=wsa@kernel.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).