[RFC PATCH 0/6] Allow DMA consumers to pass a cookie to providers' of_xlate

[RFC PATCH 0/6] Allow DMA consumers to pass a cookie to providers' of_xlate

[Konrad Dybcio]

The DMA subsystem attempts to make it theoretically possible to pair
any DMA block with any user. While that's convenient from a
codebase sanity perspective, some blocks are more intertwined.

One such case is the Qualcomm GENI, where each wrapper contains a
number of Serial Engine instances, each one of which can be programmed
to support a different protocol (such as I2C, I3C, SPI, UART, etc.).

The GPI DMA it's designed together with, needs to receive the ID of the
protocol that's in use, to adjust its behavior accordingly. Currently,
that's done through passing that ID through device tree, with each
Serial Engine expressed NUM_PROTOCOL times, resulting in terrible
dt-bindings that are full of useless copypasta.

Currently, the DT looks like:

i2c@foobar {
	compatible = "qcom,geni-i2c";
	dmas = <&gpi_dma1 0 0 QCOM_GPI_I2C>,
	       <&gpi_dma1 1 0 QCOM_GPI_I2C>;
	// actual hw description
};

spi@foobar {
        compatible = "qcom,geni-spi";
        dmas = <&gpi_dma1 0 1 QCOM_GPI_SPI>,
               <&gpi_dma1 1 1 QCOM_GPI_SPI>;
	// actual, identical hw description
};

Which is manageable when there's two of them. Unfortunately, we're
in the double digits range nowadays.

This series attempts to cut down on that through making the last cell
unnecessary, moving the purely-SW data that the current protocol ID is
into the driver.

The mass of_xlate signature change is a little unfortunate, let me know
if it can be avoided somehow..

Attaching the relevant dt-bindings change and converting one platform
over as an example.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Konrad Dybcio (6):
      dt-bindings: dma: qcom,gpi: Retire passing the protocol ID
      dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate
      dmaengine: qcom: gpi: Accept protocol ID hints
      i2c: qcom-geni: Hint GENI protocol ID to GPI DMA
      spi: geni-qcom: Hint GENI protocol ID to GPI DMA
      arm64: dts: qcom: x1e80100: Remove GENI protocol ID from DMA cells

 .../devicetree/bindings/dma/qcom,gpi.yaml          |   5 +-
 arch/arm64/boot/dts/qcom/x1e80100.dtsi             | 198 ++++++++++-----------
 drivers/dma/amba-pl08x.c                           |   3 +-
 drivers/dma/apple-admac.c                          |   3 +-
 drivers/dma/at_hdmac.c                             |   6 +-
 drivers/dma/at_xdmac.c                             |   3 +-
 drivers/dma/bcm2835-dma.c                          |   3 +-
 drivers/dma/dma-jz4780.c                           |   3 +-
 drivers/dma/dmaengine.c                            |  20 ++-
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c     |   3 +-
 drivers/dma/dw/of.c                                |   3 +-
 drivers/dma/ep93xx_dma.c                           |   6 +-
 drivers/dma/fsl-edma-main.c                        |   6 +-
 drivers/dma/img-mdc-dma.c                          |   3 +-
 drivers/dma/imx-dma.c                              |   3 +-
 drivers/dma/imx-sdma.c                             |   3 +-
 drivers/dma/lgm/lgm-dma.c                          |   3 +-
 drivers/dma/milbeaut-hdmac.c                       |   4 +-
 drivers/dma/mmp_pdma.c                             |   3 +-
 drivers/dma/mmp_tdma.c                             |   3 +-
 drivers/dma/moxart-dma.c                           |   3 +-
 drivers/dma/mxs-dma.c                              |   3 +-
 drivers/dma/nbpfaxi.c                              |   3 +-
 drivers/dma/of-dma.c                               |  18 +-
 drivers/dma/owl-dma.c                              |   3 +-
 drivers/dma/pl330.c                                |   3 +-
 drivers/dma/pxa_dma.c                              |   3 +-
 drivers/dma/qcom/bam_dma.c                         |   3 +-
 drivers/dma/qcom/gpi.c                             |  16 +-
 drivers/dma/qcom/qcom_adm.c                        |   3 +-
 drivers/dma/sh/rcar-dmac.c                         |   3 +-
 drivers/dma/sh/rz-dmac.c                           |   3 +-
 drivers/dma/sh/usb-dmac.c                          |   3 +-
 drivers/dma/st_fdma.c                              |   3 +-
 drivers/dma/ste_dma40.c                            |   3 +-
 drivers/dma/stm32/stm32-dma.c                      |   3 +-
 drivers/dma/stm32/stm32-dma3.c                     |   4 +-
 drivers/dma/stm32/stm32-mdma.c                     |   3 +-
 drivers/dma/sun4i-dma.c                            |   3 +-
 drivers/dma/sun6i-dma.c                            |   3 +-
 drivers/dma/tegra186-gpc-dma.c                     |   3 +-
 drivers/dma/tegra20-apb-dma.c                      |   3 +-
 drivers/dma/tegra210-adma.c                        |   3 +-
 drivers/dma/ti/cppi41.c                            |   3 +-
 drivers/dma/ti/edma.c                              |   3 +-
 drivers/dma/ti/k3-udma.c                           |   3 +-
 drivers/dma/uniphier-xdmac.c                       |   3 +-
 drivers/dma/xilinx/xilinx_dma.c                    |   3 +-
 drivers/dma/xilinx/xilinx_dpdma.c                  |   3 +-
 drivers/dma/xilinx/zynqmp_dma.c                    |   3 +-
 drivers/i2c/busses/i2c-qcom-geni.c                 |   4 +-
 drivers/spi/spi-geni-qcom.c                        |   4 +-
 include/linux/dmaengine.h                          |   7 +
 include/linux/of_dma.h                             |  16 +-
 sound/soc/apple/mca.c                              |   2 +-
 sound/soc/renesas/rcar/dma.c                       |   2 +-
 56 files changed, 261 insertions(+), 177 deletions(-)
---
base-commit: 79fb37f39b77bbf9a56304e9af843cd93a7a1916
change-id: 20250714-topic-dma_genise_cookie-66dcb07f3fd9

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

[PATCH RFC 1/6] dt-bindings: dma: qcom,gpi: Retire passing the protocol ID

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

This is a software construct that has no business being expressed in
dt-bindings. Drivers can be constructed to retrieve the protocol ID at
runtime or hardcode them per protocol.

Remove it, as a pre-requisite for further simplifying the GENI
bindings.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
index bbe4da2a11054f0d272017ddf5d5f7e47cf7a443..745613b93b210afd38946030f7477e91e08c907a 100644
--- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
@@ -61,14 +61,13 @@ properties:
     maxItems: 13
 
   "#dma-cells":
-    const: 3
+    const: 2
     description: >
       DMA clients must use the format described in dma.txt, giving a phandle
       to the DMA controller plus the following 3 integer cells:
       - channel: if set to 0xffffffff, any available channel will be allocated
         for the client. Otherwise, the exact channel specified will be used.
       - seid: serial id of the client as defined in the SoC documentation.
-      - client: type of the client as defined in dt-bindings/dma/qcom-gpi.h
 
   iommus:
     maxItems: 1
@@ -98,7 +97,7 @@ examples:
     #include <dt-bindings/dma/qcom-gpi.h>
     gpi_dma0: dma-controller@800000 {
         compatible = "qcom,sdm845-gpi-dma";
-        #dma-cells = <3>;
+        #dma-cells = <2>;
         reg = <0x00800000 0x60000>;
         iommus = <&apps_smmu 0x0016 0x0>;
         dma-channels = <13>;

-- 
2.50.1

Re: [PATCH RFC 1/6] dt-bindings: dma: qcom,gpi: Retire passing the protocol ID

[Rob Herring]

On Wed, Jul 30, 2025 at 11:33:28AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> This is a software construct that has no business being expressed in
> dt-bindings. Drivers can be constructed to retrieve the protocol ID at
> runtime or hardcode them per protocol.
> 
> Remove it, as a pre-requisite for further simplifying the GENI
> bindings.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> index bbe4da2a11054f0d272017ddf5d5f7e47cf7a443..745613b93b210afd38946030f7477e91e08c907a 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> @@ -61,14 +61,13 @@ properties:
>      maxItems: 13
>  
>    "#dma-cells":
> -    const: 3
> +    const: 2

I think you need to keep 3 and note it is deprecated. Does an existing 
kernel support this being 2 already. If not, ABI break...

>      description: >
>        DMA clients must use the format described in dma.txt, giving a phandle
>        to the DMA controller plus the following 3 integer cells:
>        - channel: if set to 0xffffffff, any available channel will be allocated
>          for the client. Otherwise, the exact channel specified will be used.
>        - seid: serial id of the client as defined in the SoC documentation.
> -      - client: type of the client as defined in dt-bindings/dma/qcom-gpi.h
>  
>    iommus:
>      maxItems: 1
> @@ -98,7 +97,7 @@ examples:
>      #include <dt-bindings/dma/qcom-gpi.h>
>      gpi_dma0: dma-controller@800000 {
>          compatible = "qcom,sdm845-gpi-dma";
> -        #dma-cells = <3>;
> +        #dma-cells = <2>;
>          reg = <0x00800000 0x60000>;
>          iommus = <&apps_smmu 0x0016 0x0>;
>          dma-channels = <13>;
> 
> -- 
> 2.50.1
> 

Re: [PATCH RFC 1/6] dt-bindings: dma: qcom,gpi: Retire passing the protocol ID

[Konrad Dybcio]

On 7/31/25 1:46 AM, Rob Herring wrote:
> On Wed, Jul 30, 2025 at 11:33:28AM +0200, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> This is a software construct that has no business being expressed in
>> dt-bindings. Drivers can be constructed to retrieve the protocol ID at
>> runtime or hardcode them per protocol.
>>
>> Remove it, as a pre-requisite for further simplifying the GENI
>> bindings.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
>> index bbe4da2a11054f0d272017ddf5d5f7e47cf7a443..745613b93b210afd38946030f7477e91e08c907a 100644
>> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
>> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
>> @@ -61,14 +61,13 @@ properties:
>>      maxItems: 13
>>  
>>    "#dma-cells":
>> -    const: 3
>> +    const: 2
> 
> I think you need to keep 3 and note it is deprecated. Does an existing 
> kernel support this being 2 already. If not, ABI break...

Hm, I thought this is a case of relaxing the requirements, although I
suppose some software might have had a "if n_cells != 3" (and not < 3)
check

Konrad

[PATCH RFC 2/6] dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

The DMA subsystem attempts to make it theoretically possible to pair
any DMA block with any user. While that's convenient from a
codebase sanity perspective, some blocks are more intertwined.

One such case is the Qualcomm GENI, where each wrapper contains a
number of Serial Engine instances, each one of which can be programmed
to support a different protocol (such as I2C, I3C, SPI, UART, etc.).

The GPI DMA it's designed together with, needs to receive the ID of the
protocol that's in use, to adjust its behavior accordingly. Currently,
that's done through passing that ID through device tree, with each
Serial Engine expressed NUM_PROTOCOL times, resulting in terrible
dt-bindings that are full of useless copypasta.

In a step to cut down on that, let the DMA user give the engine driver
a hint at request time.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 drivers/dma/amba-pl08x.c                       |  3 ++-
 drivers/dma/apple-admac.c                      |  3 ++-
 drivers/dma/at_hdmac.c                         |  6 ++++--
 drivers/dma/at_xdmac.c                         |  3 ++-
 drivers/dma/bcm2835-dma.c                      |  3 ++-
 drivers/dma/dma-jz4780.c                       |  3 ++-
 drivers/dma/dmaengine.c                        | 20 +++++++++++++++++---
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c |  3 ++-
 drivers/dma/dw/of.c                            |  3 ++-
 drivers/dma/ep93xx_dma.c                       |  6 ++++--
 drivers/dma/fsl-edma-main.c                    |  6 ++++--
 drivers/dma/img-mdc-dma.c                      |  3 ++-
 drivers/dma/imx-dma.c                          |  3 ++-
 drivers/dma/imx-sdma.c                         |  3 ++-
 drivers/dma/lgm/lgm-dma.c                      |  3 ++-
 drivers/dma/milbeaut-hdmac.c                   |  4 +++-
 drivers/dma/mmp_pdma.c                         |  3 ++-
 drivers/dma/mmp_tdma.c                         |  3 ++-
 drivers/dma/moxart-dma.c                       |  3 ++-
 drivers/dma/mxs-dma.c                          |  3 ++-
 drivers/dma/nbpfaxi.c                          |  3 ++-
 drivers/dma/of-dma.c                           | 18 +++++++++++-------
 drivers/dma/owl-dma.c                          |  3 ++-
 drivers/dma/pl330.c                            |  3 ++-
 drivers/dma/pxa_dma.c                          |  3 ++-
 drivers/dma/qcom/bam_dma.c                     |  3 ++-
 drivers/dma/qcom/gpi.c                         |  3 ++-
 drivers/dma/qcom/qcom_adm.c                    |  3 ++-
 drivers/dma/sh/rcar-dmac.c                     |  3 ++-
 drivers/dma/sh/rz-dmac.c                       |  3 ++-
 drivers/dma/sh/usb-dmac.c                      |  3 ++-
 drivers/dma/st_fdma.c                          |  3 ++-
 drivers/dma/ste_dma40.c                        |  3 ++-
 drivers/dma/stm32/stm32-dma.c                  |  3 ++-
 drivers/dma/stm32/stm32-dma3.c                 |  4 +++-
 drivers/dma/stm32/stm32-mdma.c                 |  3 ++-
 drivers/dma/sun4i-dma.c                        |  3 ++-
 drivers/dma/sun6i-dma.c                        |  3 ++-
 drivers/dma/tegra186-gpc-dma.c                 |  3 ++-
 drivers/dma/tegra20-apb-dma.c                  |  3 ++-
 drivers/dma/tegra210-adma.c                    |  3 ++-
 drivers/dma/ti/cppi41.c                        |  3 ++-
 drivers/dma/ti/edma.c                          |  3 ++-
 drivers/dma/ti/k3-udma.c                       |  3 ++-
 drivers/dma/uniphier-xdmac.c                   |  3 ++-
 drivers/dma/xilinx/xilinx_dma.c                |  3 ++-
 drivers/dma/xilinx/xilinx_dpdma.c              |  3 ++-
 drivers/dma/xilinx/zynqmp_dma.c                |  3 ++-
 include/linux/dmaengine.h                      |  7 +++++++
 include/linux/of_dma.h                         | 16 +++++++++-------
 sound/soc/apple/mca.c                          |  2 +-
 sound/soc/renesas/rcar/dma.c                   |  2 +-
 52 files changed, 146 insertions(+), 68 deletions(-)

diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 38cdbca59485ca22fbe2aa4c786c1d4a69bf8a86..6427367dd459d98a032bded3e915e989e3c4a699 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -2529,7 +2529,8 @@ static struct dma_chan *pl08x_find_chan_id(struct pl08x_driver_data *pl08x,
 }
 
 static struct dma_chan *pl08x_of_xlate(struct of_phandle_args *dma_spec,
-				       struct of_dma *ofdma)
+				       struct of_dma *ofdma,
+				       void *data)
 {
 	struct pl08x_driver_data *pl08x = ofdma->of_dma_data;
 	struct dma_chan *dma_chan;
diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c
index bd49f03742912198804a02a22e38da2c21093761..58507b9dab8c33defe60fa526f7b9dd34a18f6e5 100644
--- a/drivers/dma/apple-admac.c
+++ b/drivers/dma/apple-admac.c
@@ -579,7 +579,8 @@ static void admac_free_chan_resources(struct dma_chan *chan)
 }
 
 static struct dma_chan *admac_dma_of_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	struct admac_data *ad = (struct admac_data *) ofdma->of_dma_data;
 	unsigned int index;
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 2d147712cbc69b5d296001a4e50cf46277798b89..137409c33441b6bb338c552875f01fc67825e8ef 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1794,7 +1794,8 @@ static bool at_dma_filter(struct dma_chan *chan, void *slave)
 }
 
 static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
-				     struct of_dma *of_dma)
+				     struct of_dma *of_dma,
+				     void *data)
 {
 	struct dma_chan *chan;
 	struct at_dma_chan *atchan;
@@ -1861,7 +1862,8 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
 }
 #else
 static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
-				     struct of_dma *of_dma)
+				     struct of_dma *of_dma,
+				     void *data)
 {
 	return NULL;
 }
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index 3fbc74710a1336dfb0420fffdc9a1952da1a8f95..9f4c93cbc738e41fcf9042b2f974f8abde8a58f7 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -633,7 +633,8 @@ static inline void at_xdmac_increment_block_count(struct dma_chan *chan,
 }
 
 static struct dma_chan *at_xdmac_xlate(struct of_phandle_args *dma_spec,
-				       struct of_dma *of_dma)
+				       struct of_dma *of_dma,
+				       void *data)
 {
 	struct at_xdmac		*atxdmac = of_dma->of_dma_data;
 	struct at_xdmac_chan	*atchan;
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 0117bb2e8591be630d6682e9625574a1bcc80515..87069bca16328a29a175ab3f9b239f08149ad396 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -860,7 +860,8 @@ static const struct of_device_id bcm2835_dma_of_match[] = {
 MODULE_DEVICE_TABLE(of, bcm2835_dma_of_match);
 
 static struct dma_chan *bcm2835_dma_xlate(struct of_phandle_args *spec,
-					   struct of_dma *ofdma)
+					  struct of_dma *ofdma,
+					  void *data)
 {
 	struct bcm2835_dmadev *d = ofdma->of_dma_data;
 	struct dma_chan *chan;
diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
index 100057603fd4e1c4f11b678e5cf66517a509ec9b..b41d0b7ab936673812c0047e22dbbf1e743176f1 100644
--- a/drivers/dma/dma-jz4780.c
+++ b/drivers/dma/dma-jz4780.c
@@ -803,7 +803,8 @@ static bool jz4780_dma_filter_fn(struct dma_chan *chan, void *param)
 }
 
 static struct dma_chan *jz4780_of_dma_xlate(struct of_phandle_args *dma_spec,
-	struct of_dma *ofdma)
+					    struct of_dma *ofdma,
+					    void *data)
 {
 	struct jz4780_dma_dev *jzdma = ofdma->of_dma_data;
 	dma_cap_mask_t mask = jzdma->dma_device.cap_mask;
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index ca13cd39330ba4d822baaab412356a166b656350..a3f14c4da906e95a4dda07f09b2b2e19b3bab22d 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -806,20 +806,21 @@ static const struct dma_slave_map *dma_filter_match(struct dma_device *device,
 }
 
 /**
- * dma_request_chan - try to allocate an exclusive slave channel
+ * dma_request_chan_w_data - try to allocate an exclusive slave channel, with extra data
  * @dev:	pointer to client device structure
  * @name:	slave channel name
+ * @data:	pointer to producer-consumer specific data
  *
  * Returns pointer to appropriate DMA channel on success or an error pointer.
  */
-struct dma_chan *dma_request_chan(struct device *dev, const char *name)
+struct dma_chan *dma_request_chan_w_data(struct device *dev, const char *name, void *data)
 {
 	struct fwnode_handle *fwnode = dev_fwnode(dev);
 	struct dma_device *d, *_d;
 	struct dma_chan *chan = NULL;
 
 	if (is_of_node(fwnode))
-		chan = of_dma_request_slave_channel(to_of_node(fwnode), name);
+		chan = of_dma_request_slave_channel(to_of_node(fwnode), name, data);
 	else if (is_acpi_device_node(fwnode))
 		chan = acpi_dma_request_slave_chan_by_name(dev, name);
 
@@ -871,6 +872,19 @@ struct dma_chan *dma_request_chan(struct device *dev, const char *name)
 
 	return chan;
 }
+EXPORT_SYMBOL_GPL(dma_request_chan_w_data);
+
+/**
+ * dma_request_chan - try to allocate an exclusive slave channel
+ * @dev:	pointer to client device structure
+ * @name:	slave channel name
+ *
+ * Returns pointer to appropriate DMA channel on success or an error pointer.
+ */
+struct dma_chan *dma_request_chan(struct device *dev, const char *name)
+{
+	return dma_request_chan_w_data(dev, name, NULL);
+}
 EXPORT_SYMBOL_GPL(dma_request_chan);
 
 /**
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index b23536645ff7ccb59fa1363f500f742a41b7631f..fba3cc34a91d1017f4a5f69028e85a028bd9f94b 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -1358,7 +1358,8 @@ static int __maybe_unused axi_dma_runtime_resume(struct device *dev)
 }
 
 static struct dma_chan *dw_axi_dma_of_xlate(struct of_phandle_args *dma_spec,
-					    struct of_dma *ofdma)
+					    struct of_dma *ofdma,
+					    void *data)
 {
 	struct dw_axi_dma *dw = ofdma->of_dma_data;
 	struct axi_dma_chan *chan;
diff --git a/drivers/dma/dw/of.c b/drivers/dma/dw/of.c
index 523ca806837cb3c028f2ae7c1b3b7be7275344f1..92c320542fa6e9d60ac7abbda9ac8ec207017d34 100644
--- a/drivers/dma/dw/of.c
+++ b/drivers/dma/dw/of.c
@@ -14,7 +14,8 @@
 #include "internal.h"
 
 static struct dma_chan *dw_dma_of_xlate(struct of_phandle_args *dma_spec,
-					struct of_dma *ofdma)
+					struct of_dma *ofdma,
+					void *data)
 {
 	struct dw_dma *dw = ofdma->of_dma_data;
 	struct dw_dma_slave slave = {
diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index e424bb5c40e79c5784437c5b6e259c340fb30432..81e66580911c7894cad9558106a497f4a4c59bd4 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -1443,7 +1443,8 @@ static bool ep93xx_m2p_dma_filter(struct dma_chan *chan, void *filter_param)
 }
 
 static struct dma_chan *ep93xx_m2p_dma_of_xlate(struct of_phandle_args *dma_spec,
-					    struct of_dma *ofdma)
+						struct of_dma *ofdma,
+						void *data)
 {
 	struct ep93xx_dma_engine *edma = ofdma->of_dma_data;
 	dma_cap_mask_t mask = edma->dma_dev.cap_mask;
@@ -1474,7 +1475,8 @@ static bool ep93xx_m2m_dma_filter(struct dma_chan *chan, void *filter_param)
 }
 
 static struct dma_chan *ep93xx_m2m_dma_of_xlate(struct of_phandle_args *dma_spec,
-					    struct of_dma *ofdma)
+						struct of_dma *ofdma,
+						void *data)
 {
 	struct ep93xx_dma_engine *edma = ofdma->of_dma_data;
 	dma_cap_mask_t mask = edma->dma_dev.cap_mask;
diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index 97583c7d51a2e8e7a50c7eb4f5ff0582ac95798d..e9b2441779cee3278f0ab03c6a957c00a7f8d0be 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -249,7 +249,8 @@ static bool fsl_edma_srcid_in_use(struct fsl_edma_engine *fsl_edma, u32 srcid)
 }
 
 static struct dma_chan *fsl_edma_xlate(struct of_phandle_args *dma_spec,
-		struct of_dma *ofdma)
+				       struct of_dma *ofdma,
+				       void *data)
 {
 	struct fsl_edma_engine *fsl_edma = ofdma->of_dma_data;
 	struct dma_chan *chan, *_chan;
@@ -292,7 +293,8 @@ static struct dma_chan *fsl_edma_xlate(struct of_phandle_args *dma_spec,
 }
 
 static struct dma_chan *fsl_edma3_xlate(struct of_phandle_args *dma_spec,
-					struct of_dma *ofdma)
+					struct of_dma *ofdma,
+					void *data)
 {
 	struct fsl_edma_engine *fsl_edma = ofdma->of_dma_data;
 	struct dma_chan *chan, *_chan;
diff --git a/drivers/dma/img-mdc-dma.c b/drivers/dma/img-mdc-dma.c
index fd55bcd060ab89e7a871e4db26c4519985e90c2b..88a304af3ed2adfbb9566f161d8b12c39d7ce86a 100644
--- a/drivers/dma/img-mdc-dma.c
+++ b/drivers/dma/img-mdc-dma.c
@@ -805,7 +805,8 @@ static irqreturn_t mdc_chan_irq(int irq, void *dev_id)
 }
 
 static struct dma_chan *mdc_of_xlate(struct of_phandle_args *dma_spec,
-				     struct of_dma *ofdma)
+				     struct of_dma *ofdma,
+				     void *data)
 {
 	struct mdc_dma *mdma = ofdma->of_dma_data;
 	struct dma_chan *chan;
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index ba434657059a8b984849a058afa501a89320d494..d0bd11f73f74f59af2e4bf96d187fde459262e22 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -1016,7 +1016,8 @@ static bool imxdma_filter_fn(struct dma_chan *chan, void *param)
 }
 
 static struct dma_chan *imxdma_xlate(struct of_phandle_args *dma_spec,
-						struct of_dma *ofdma)
+				     struct of_dma *ofdma,
+				     void *data)
 {
 	int count = dma_spec->args_count;
 	struct imxdma_engine *imxdma = ofdma->of_dma_data;
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 02a85d6f1bea2df7d355858094c0c0b0bd07148e..76dbe21cfa2bf97c5fac0ef7e6c4f73927c9d7de 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -2207,7 +2207,8 @@ static bool sdma_filter_fn(struct dma_chan *chan, void *fn_param)
 }
 
 static struct dma_chan *sdma_xlate(struct of_phandle_args *dma_spec,
-				   struct of_dma *ofdma)
+				   struct of_dma *ofdma,
+				   void *data)
 {
 	struct sdma_engine *sdma = ofdma->of_dma_data;
 	dma_cap_mask_t mask = sdma->dma_device.cap_mask;
diff --git a/drivers/dma/lgm/lgm-dma.c b/drivers/dma/lgm/lgm-dma.c
index 8173c3f1075a629f54bb6172b9afd3579e51a91b..b51070fd2a7480321ac59258903200ae0bc0ecf0 100644
--- a/drivers/dma/lgm/lgm-dma.c
+++ b/drivers/dma/lgm/lgm-dma.c
@@ -1382,7 +1382,8 @@ update_client_configs(struct of_dma *ofdma, struct of_phandle_args *spec)
 }
 
 static struct dma_chan *ldma_xlate(struct of_phandle_args *spec,
-				   struct of_dma *ofdma)
+				   struct of_dma *ofdma,
+				   void *data)
 {
 	struct ldma_dev *d = ofdma->of_dma_data;
 	u32 chan_id =  spec->args[0];
diff --git a/drivers/dma/milbeaut-hdmac.c b/drivers/dma/milbeaut-hdmac.c
index 9a5ec247ed6d924f364e9232e8a6de5476db7825..b4cdb707303264224977e5e876a8fd5fd42d9eb5 100644
--- a/drivers/dma/milbeaut-hdmac.c
+++ b/drivers/dma/milbeaut-hdmac.c
@@ -400,7 +400,9 @@ static void milbeaut_hdmac_desc_free(struct virt_dma_desc *vd)
 }
 
 static struct dma_chan *
-milbeaut_hdmac_xlate(struct of_phandle_args *dma_spec, struct of_dma *of_dma)
+milbeaut_hdmac_xlate(struct of_phandle_args *dma_spec,
+		     struct of_dma *of_dma,
+		     void *data)
 {
 	struct milbeaut_hdmac_device *mdev = of_dma->of_dma_data;
 	struct milbeaut_hdmac_chan *mc;
diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
index a95d31103d3063a1d11177a1a37b89ac2fd213e9..d2cd00423d7871d93965210008ee5b16044ab8a6 100644
--- a/drivers/dma/mmp_pdma.c
+++ b/drivers/dma/mmp_pdma.c
@@ -1001,7 +1001,8 @@ static const struct of_device_id mmp_pdma_dt_ids[] = {
 MODULE_DEVICE_TABLE(of, mmp_pdma_dt_ids);
 
 static struct dma_chan *mmp_pdma_dma_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	struct mmp_pdma_device *d = ofdma->of_dma_data;
 	struct dma_chan *chan;
diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index b7fb843c67a6f247395296fc726f7b6cab7d223f..cb4db4b266df31702de8c2b8bb5b2206013d3284 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -607,7 +607,8 @@ static bool mmp_tdma_filter_fn(struct dma_chan *chan, void *fn_param)
 }
 
 static struct dma_chan *mmp_tdma_xlate(struct of_phandle_args *dma_spec,
-			       struct of_dma *ofdma)
+				       struct of_dma *ofdma,
+				       void *data)
 {
 	struct mmp_tdma_device *tdev = ofdma->of_dma_data;
 	dma_cap_mask_t mask = tdev->device.cap_mask;
diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
index de09e1ab77676d3ff2070dfb30c9d03a9bb63e0d..2ce3e5c3ca511ac2c5d5f0f29627819ecb518c96 100644
--- a/drivers/dma/moxart-dma.c
+++ b/drivers/dma/moxart-dma.c
@@ -321,7 +321,8 @@ static struct dma_async_tx_descriptor *moxart_prep_slave_sg(
 }
 
 static struct dma_chan *moxart_of_xlate(struct of_phandle_args *dma_spec,
-					struct of_dma *ofdma)
+					struct of_dma *ofdma,
+					void *data)
 {
 	struct moxart_dmadev *mdc = ofdma->of_dma_data;
 	struct dma_chan *chan;
diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index cfb9962417ef68e976ae03c3c6f3054dc89bd1e6..30209bf506fe93563423881610fdd5b259decdaa 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -722,7 +722,8 @@ static bool mxs_dma_filter_fn(struct dma_chan *chan, void *fn_param)
 }
 
 static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
-			       struct of_dma *ofdma)
+				      struct of_dma *ofdma,
+				      void *data)
 {
 	struct mxs_dma_engine *mxs_dma = ofdma->of_dma_data;
 	dma_cap_mask_t mask = mxs_dma->dma_device.cap_mask;
diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c
index 765462303de098c01ee38540ae7e1cf70570e92e..d9387f34b886631144d06ef2d8475672f9bc79fd 100644
--- a/drivers/dma/nbpfaxi.c
+++ b/drivers/dma/nbpfaxi.c
@@ -1098,7 +1098,8 @@ static void nbpf_free_chan_resources(struct dma_chan *dchan)
 }
 
 static struct dma_chan *nbpf_of_xlate(struct of_phandle_args *dma_spec,
-				      struct of_dma *ofdma)
+				      struct of_dma *ofdma,
+				      void *data)
 {
 	struct nbpf_device *nbpf = ofdma->of_dma_data;
 	struct dma_chan *dchan;
diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
index 423442e55d368d1e020b981306aa6b792c8b66b9..6cd8dd285c041dedb7ed61e18a1cd91316ed0dda 100644
--- a/drivers/dma/of-dma.c
+++ b/drivers/dma/of-dma.c
@@ -53,7 +53,8 @@ static struct of_dma *of_dma_find_controller(const struct of_phandle_args *dma_s
  * to request channel from the real DMA controller.
  */
 static struct dma_chan *of_dma_router_xlate(struct of_phandle_args *dma_spec,
-					    struct of_dma *ofdma)
+					    struct of_dma *ofdma,
+					    void *data)
 {
 	struct dma_chan		*chan;
 	struct of_dma		*ofdma_target;
@@ -74,7 +75,7 @@ static struct dma_chan *of_dma_router_xlate(struct of_phandle_args *dma_spec,
 		goto err;
 	}
 
-	chan = ofdma_target->of_dma_xlate(&dma_spec_target, ofdma_target);
+	chan = ofdma_target->of_dma_xlate(&dma_spec_target, ofdma_target, NULL);
 	if (IS_ERR_OR_NULL(chan)) {
 		ofdma->dma_router->route_free(ofdma->dma_router->dev,
 					      route_data);
@@ -117,7 +118,7 @@ static struct dma_chan *of_dma_router_xlate(struct of_phandle_args *dma_spec,
  */
 int of_dma_controller_register(struct device_node *np,
 				struct dma_chan *(*of_dma_xlate)
-				(struct of_phandle_args *, struct of_dma *),
+				(struct of_phandle_args *, struct of_dma *, void *),
 				void *data)
 {
 	struct of_dma	*ofdma;
@@ -249,7 +250,8 @@ static int of_dma_match_channel(struct device_node *np, const char *name,
  * Returns pointer to appropriate DMA channel on success or an error pointer.
  */
 struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
-					      const char *name)
+					      const char *name,
+					      void *data)
 {
 	struct of_phandle_args	dma_spec;
 	struct of_dma		*ofdma;
@@ -289,7 +291,7 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
 		ofdma = of_dma_find_controller(&dma_spec);
 
 		if (ofdma) {
-			chan = ofdma->of_dma_xlate(&dma_spec, ofdma);
+			chan = ofdma->of_dma_xlate(&dma_spec, ofdma, data);
 		} else {
 			ret_no_channel = -EPROBE_DEFER;
 			chan = NULL;
@@ -319,7 +321,8 @@ EXPORT_SYMBOL_GPL(of_dma_request_slave_channel);
  * pointer to appropriate dma channel on success or NULL on error.
  */
 struct dma_chan *of_dma_simple_xlate(struct of_phandle_args *dma_spec,
-						struct of_dma *ofdma)
+				     struct of_dma *ofdma,
+				     void *data)
 {
 	int count = dma_spec->args_count;
 	struct of_dma_filter_info *info = ofdma->of_dma_data;
@@ -349,7 +352,8 @@ EXPORT_SYMBOL_GPL(of_dma_simple_xlate);
  * Returns pointer to appropriate dma channel on success or NULL on error.
  */
 struct dma_chan *of_dma_xlate_by_chan_id(struct of_phandle_args *dma_spec,
-					 struct of_dma *ofdma)
+					 struct of_dma *ofdma,
+					 void *data)
 {
 	struct dma_device *dev = ofdma->of_dma_data;
 	struct dma_chan *chan, *candidate = NULL;
diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c
index 57cec757d8f5687d465f8b2a7997709f91f03335..b80ae8c3cff2a787cf22ee24b9bd7205c39ff997 100644
--- a/drivers/dma/owl-dma.c
+++ b/drivers/dma/owl-dma.c
@@ -1060,7 +1060,8 @@ static inline void owl_dma_free(struct owl_dma *od)
 }
 
 static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
-					 struct of_dma *ofdma)
+					 struct of_dma *ofdma,
+					 void *data)
 {
 	struct owl_dma *od = ofdma->of_dma_data;
 	struct owl_dma_vchan *vchan;
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 82a9fe88ad54c995616ceb9b4be63e3e884fa49f..0671cda5dcd767aa0a8492fc128a9a0be0992ec5 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2140,7 +2140,8 @@ static void pl330_tasklet(struct tasklet_struct *t)
 }
 
 static struct dma_chan *of_dma_pl330_xlate(struct of_phandle_args *dma_spec,
-						struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	int count = dma_spec->args_count;
 	struct pl330_dmac *pl330 = ofdma->of_dma_data;
diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c
index 249296389771cf685b65eb11e38fd0262c26679d..94b7ba1cd0aa57c4a5eaa76cf6b7fdd5c5b479ed 100644
--- a/drivers/dma/pxa_dma.c
+++ b/drivers/dma/pxa_dma.c
@@ -1281,7 +1281,8 @@ static const struct of_device_id pxad_dt_ids[] = {
 MODULE_DEVICE_TABLE(of, pxad_dt_ids);
 
 static struct dma_chan *pxad_dma_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+				       struct of_dma *ofdma,
+				       void *data)
 {
 	struct pxad_device *d = ofdma->of_dma_data;
 	struct dma_chan *chan;
diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
index bbc3276992bb012a1b79937bdbd069fc01f75331..471500951dc493cbf9e4f085352a37c11d0b9274 100644
--- a/drivers/dma/qcom/bam_dma.c
+++ b/drivers/dma/qcom/bam_dma.c
@@ -1165,7 +1165,8 @@ static void bam_dma_free_desc(struct virt_dma_desc *vd)
 }
 
 static struct dma_chan *bam_dma_xlate(struct of_phandle_args *dma_spec,
-		struct of_dma *of)
+				      struct of_dma *of,
+				      void *data)
 {
 	struct bam_device *bdev = container_of(of->of_dma_data,
 					struct bam_device, common);
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 8e87738086b25ac37edbdcd5e237447f3e832e8e..51d19494099dae09f4579ba8c3eddfa0487bf487 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2108,7 +2108,8 @@ static int gpi_find_avail_gpii(struct gpi_dev *gpi_dev, u32 seid)
 
 /* gpi_of_dma_xlate: open client requested channel */
 static struct dma_chan *gpi_of_dma_xlate(struct of_phandle_args *args,
-					 struct of_dma *of_dma)
+					 struct of_dma *of_dma,
+					 void *data)
 {
 	struct gpi_dev *gpi_dev = (struct gpi_dev *)of_dma->of_dma_data;
 	u32 seid, chid;
diff --git a/drivers/dma/qcom/qcom_adm.c b/drivers/dma/qcom/qcom_adm.c
index 6be54fddcee18f9be6b5fee9f55c4bbd9a99ca56..7702c1d904160cbaa73e79ce29408f576df6e1f4 100644
--- a/drivers/dma/qcom/qcom_adm.c
+++ b/drivers/dma/qcom/qcom_adm.c
@@ -716,7 +716,8 @@ static void adm_channel_init(struct adm_device *adev, struct adm_chan *achan,
  * Returns pointer to appropriate dma channel on success or NULL on error.
  */
 static struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec,
-			       struct of_dma *ofdma)
+				      struct of_dma *ofdma,
+				      void *data)
 {
 	struct dma_device *dev = ofdma->of_dma_data;
 	struct dma_chan *chan, *candidate = NULL;
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
index 0c45ce8c74aa2dedb2764856453da4d9944ab83f..510424bfb86b344ffa2ff2dc566a1d0fff826715 100644
--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -1700,7 +1700,8 @@ static bool rcar_dmac_chan_filter(struct dma_chan *chan, void *arg)
 }
 
 static struct dma_chan *rcar_dmac_of_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	struct rcar_dmac_chan *rchan;
 	struct dma_chan *chan;
diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c
index 1f687b08d6b8677d9300b5c7274559bfc9574643..381a00db75da5e84336a51852333efaa3001077e 100644
--- a/drivers/dma/sh/rz-dmac.c
+++ b/drivers/dma/sh/rz-dmac.c
@@ -767,7 +767,8 @@ static bool rz_dmac_chan_filter(struct dma_chan *chan, void *arg)
 }
 
 static struct dma_chan *rz_dmac_of_xlate(struct of_phandle_args *dma_spec,
-					 struct of_dma *ofdma)
+					 struct of_dma *ofdma,
+					 void *data)
 {
 	dma_cap_mask_t mask;
 
diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
index 7e2b6c97fa2f97f2d3dfe323f684f65278f012ee..c1c141cc49ff40ac367150fecb475a087cd8d827 100644
--- a/drivers/dma/sh/usb-dmac.c
+++ b/drivers/dma/sh/usb-dmac.c
@@ -646,7 +646,8 @@ static bool usb_dmac_chan_filter(struct dma_chan *chan, void *arg)
 }
 
 static struct dma_chan *usb_dmac_of_xlate(struct of_phandle_args *dma_spec,
-					  struct of_dma *ofdma)
+					  struct of_dma *ofdma,
+					  void *data)
 {
 	struct dma_chan *chan;
 	dma_cap_mask_t mask;
diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c
index c65ee0c7bfbdb2ade49e24618a5a83160440681d..cf78abb9654f4259a57faf63c0183212771dfae0 100644
--- a/drivers/dma/st_fdma.c
+++ b/drivers/dma/st_fdma.c
@@ -165,7 +165,8 @@ static irqreturn_t st_fdma_irq_handler(int irq, void *dev_id)
 }
 
 static struct dma_chan *st_fdma_of_xlate(struct of_phandle_args *dma_spec,
-					 struct of_dma *ofdma)
+					 struct of_dma *ofdma,
+					 void *data)
 {
 	struct st_fdma_dev *fdev = ofdma->of_dma_data;
 	struct dma_chan *chan;
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index d52e1685aed53ffa49c7c7f6d6a611a358e7f360..45ba20448354d840629495935b963bc4574003ec 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2365,7 +2365,8 @@ static void d40_set_prio_realtime(struct d40_chan *d40c)
 #define D40_DT_FLAGS_HIGH_PRIO(flags)  ((flags >> 4) & 0x1)
 
 static struct dma_chan *d40_xlate(struct of_phandle_args *dma_spec,
-				  struct of_dma *ofdma)
+				  struct of_dma *ofdma,
+				  void *data)
 {
 	struct stedma40_chan_cfg cfg;
 	dma_cap_mask_t cap;
diff --git a/drivers/dma/stm32/stm32-dma.c b/drivers/dma/stm32/stm32-dma.c
index 04389936c8a6a5970b43408173e3d9968e6b148c..a477030c2bbcf241d35b285af06c9fb8f980b625 100644
--- a/drivers/dma/stm32/stm32-dma.c
+++ b/drivers/dma/stm32/stm32-dma.c
@@ -1519,7 +1519,8 @@ static void stm32_dma_set_config(struct stm32_dma_chan *chan,
 }
 
 static struct dma_chan *stm32_dma_of_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	struct stm32_dma_device *dmadev = ofdma->of_dma_data;
 	struct device *dev = dmadev->ddev.dev;
diff --git a/drivers/dma/stm32/stm32-dma3.c b/drivers/dma/stm32/stm32-dma3.c
index 50e7106c5cb73394c1de52ad5f571f6db63750e6..c63bd9f5640aae458da9c1522e8d68f6290fe2c6 100644
--- a/drivers/dma/stm32/stm32-dma3.c
+++ b/drivers/dma/stm32/stm32-dma3.c
@@ -1582,7 +1582,9 @@ static bool stm32_dma3_filter_fn(struct dma_chan *c, void *fn_param)
 	return true;
 }
 
-static struct dma_chan *stm32_dma3_of_xlate(struct of_phandle_args *dma_spec, struct of_dma *ofdma)
+static struct dma_chan *stm32_dma3_of_xlate(struct of_phandle_args *dma_spec,
+					    struct of_dma *ofdma,
+					    void *data)
 {
 	struct stm32_dma3_ddata *ddata = ofdma->of_dma_data;
 	dma_cap_mask_t mask = ddata->dma_dev.cap_mask;
diff --git a/drivers/dma/stm32/stm32-mdma.c b/drivers/dma/stm32/stm32-mdma.c
index 080c1c725216cb627675c372591b4c0c227c3cea..8700ff0308ea71fff6a35f0c0c4071f3bd60d4a3 100644
--- a/drivers/dma/stm32/stm32-mdma.c
+++ b/drivers/dma/stm32/stm32-mdma.c
@@ -1539,7 +1539,8 @@ static bool stm32_mdma_filter_fn(struct dma_chan *c, void *fn_param)
 }
 
 static struct dma_chan *stm32_mdma_of_xlate(struct of_phandle_args *dma_spec,
-					    struct of_dma *ofdma)
+					    struct of_dma *ofdma,
+					    void *data)
 {
 	struct stm32_mdma_device *dmadev = ofdma->of_dma_data;
 	dma_cap_mask_t mask = dmadev->ddev.cap_mask;
diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
index 00d2fd38d17f65a5fcbb4d0ec57c2361f499d3c7..4a71f64439c83154f7699ba3a37dd6bcb706b85e 100644
--- a/drivers/dma/sun4i-dma.c
+++ b/drivers/dma/sun4i-dma.c
@@ -1018,7 +1018,8 @@ static int sun4i_dma_config(struct dma_chan *chan,
 }
 
 static struct dma_chan *sun4i_dma_of_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	struct sun4i_dma_dev *priv = ofdma->of_dma_data;
 	struct sun4i_dma_vchan *vchan;
diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
index 2215ff877bf7d024d1885c37c98187b519c75980..715d7ba6e681d9053eb0f31f0456e75938586a89 100644
--- a/drivers/dma/sun6i-dma.c
+++ b/drivers/dma/sun6i-dma.c
@@ -1029,7 +1029,8 @@ static void sun6i_dma_free_chan_resources(struct dma_chan *chan)
 }
 
 static struct dma_chan *sun6i_dma_of_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	struct sun6i_dma_dev *sdev = ofdma->of_dma_data;
 	struct sun6i_vchan *vchan;
diff --git a/drivers/dma/tegra186-gpc-dma.c b/drivers/dma/tegra186-gpc-dma.c
index 4d6fe0efa76e4b4270958e5cfeecdc7d5c762414..171ece174300553c39242a7fd691f5e8fd65ccf5 100644
--- a/drivers/dma/tegra186-gpc-dma.c
+++ b/drivers/dma/tegra186-gpc-dma.c
@@ -1289,7 +1289,8 @@ static void tegra_dma_free_chan_resources(struct dma_chan *dc)
 }
 
 static struct dma_chan *tegra_dma_of_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	struct tegra_dma *tdma = ofdma->of_dma_data;
 	struct tegra_dma_channel *tdc;
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 14a61e53a41b73f29bb2ab04ae9d95421280f51c..8d0976a50e6f035fe9765ef5259c2a8173060151 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -1343,7 +1343,8 @@ static void tegra_dma_free_chan_resources(struct dma_chan *dc)
 }
 
 static struct dma_chan *tegra_dma_of_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	struct tegra_dma *tdma = ofdma->of_dma_data;
 	struct tegra_dma_channel *tdc;
diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
index fad896ff29a2d3f5b2605ae2bc93e1b5b2349978..e8343d0264f729bffa919a1774d0df3fc78d6c0c 100644
--- a/drivers/dma/tegra210-adma.c
+++ b/drivers/dma/tegra210-adma.c
@@ -802,7 +802,8 @@ static void tegra_adma_free_chan_resources(struct dma_chan *dc)
 }
 
 static struct dma_chan *tegra_dma_of_xlate(struct of_phandle_args *dma_spec,
-					   struct of_dma *ofdma)
+					   struct of_dma *ofdma,
+					   void *data)
 {
 	struct tegra_adma *tdma = ofdma->of_dma_data;
 	struct tegra_adma_chan *tdc;
diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c
index 8d8c3d6038fcc20b43d1b31292092cde00dc123e..c0947a6a35b37868ed7c60a1466035d143896d7c 100644
--- a/drivers/dma/ti/cppi41.c
+++ b/drivers/dma/ti/cppi41.c
@@ -981,7 +981,8 @@ static struct of_dma_filter_info cpp41_dma_info = {
 };
 
 static struct dma_chan *cppi41_dma_xlate(struct of_phandle_args *dma_spec,
-		struct of_dma *ofdma)
+					 struct of_dma *ofdma,
+					 void *data)
 {
 	int count = dma_spec->args_count;
 	struct of_dma_filter_info *info = ofdma->of_dma_data;
diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
index 3ed406f08c442e1930aca4d15059d914eca4b55e..4fe6c0fae307e1bdb50a354d46c11ae38fe503db 100644
--- a/drivers/dma/ti/edma.c
+++ b/drivers/dma/ti/edma.c
@@ -2275,7 +2275,8 @@ static struct edma_soc_info *edma_setup_info_from_dt(struct device *dev,
 }
 
 static struct dma_chan *of_edma_xlate(struct of_phandle_args *dma_spec,
-				      struct of_dma *ofdma)
+				      struct of_dma *ofdma,
+				      void *data)
 {
 	return NULL;
 }
diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index aa2dc762140f6eee334f4506a592e72600ae9834..22e5a61a3a3364723c64bf4548337714d7b9bfa6 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -4250,7 +4250,8 @@ static bool udma_dma_filter_fn(struct dma_chan *chan, void *param)
 }
 
 static struct dma_chan *udma_of_xlate(struct of_phandle_args *dma_spec,
-				      struct of_dma *ofdma)
+				      struct of_dma *ofdma,
+				      void *data)
 {
 	struct udma_dev *ud = ofdma->of_dma_data;
 	struct udma_filter_param filter_param;
diff --git a/drivers/dma/uniphier-xdmac.c b/drivers/dma/uniphier-xdmac.c
index ceeb6171c9d1174cc643e9b5e7c70f6488884aec..ea8e8e244b3a994005e1e3b44bbb0dcc36886c92 100644
--- a/drivers/dma/uniphier-xdmac.c
+++ b/drivers/dma/uniphier-xdmac.c
@@ -464,7 +464,8 @@ static void uniphier_xdmac_chan_init(struct uniphier_xdmac_device *xdev,
 }
 
 static struct dma_chan *of_dma_uniphier_xlate(struct of_phandle_args *dma_spec,
-					      struct of_dma *ofdma)
+					      struct of_dma *ofdma,
+					      void *data)
 {
 	struct uniphier_xdmac_device *xdev = ofdma->of_dma_data;
 	int chan_id = dma_spec->args[0];
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index a34d8f0ceed8b18402954e5a27555e2a2978cb7b..359f419535140b980d003cf0a49bbcbeded906dc 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -3005,7 +3005,8 @@ static int xilinx_dma_child_probe(struct xilinx_dma_device *xdev,
  * Return: DMA channel pointer on success and NULL on error
  */
 static struct dma_chan *of_dma_xilinx_xlate(struct of_phandle_args *dma_spec,
-						struct of_dma *ofdma)
+					    struct of_dma *ofdma,
+					    void *data)
 {
 	struct xilinx_dma_device *xdev = ofdma->of_dma_data;
 	int chan_id = dma_spec->args[0];
diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index ee5d9fdbfd7fa84f82fd45970151c056275ce7d3..efa0dcb25fa016e76ef41f784d9b651065e1285f 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -1689,7 +1689,8 @@ static void xilinx_dpdma_chan_remove(struct xilinx_dpdma_chan *chan)
 }
 
 static struct dma_chan *of_dma_xilinx_xlate(struct of_phandle_args *dma_spec,
-					    struct of_dma *ofdma)
+					    struct of_dma *ofdma,
+					    void *data)
 {
 	struct xilinx_dpdma_device *xdev = ofdma->of_dma_data;
 	u32 chan_id = dma_spec->args[0];
diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
index d05fc5fcc77dcedd32cc23c99d084504647c31aa..717ab63f398a12c31035ca8bda78a9d4db9ce325 100644
--- a/drivers/dma/xilinx/zynqmp_dma.c
+++ b/drivers/dma/xilinx/zynqmp_dma.c
@@ -972,7 +972,8 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev,
  * Return: DMA channel pointer on success and NULL on error
  */
 static struct dma_chan *of_zynqmp_dma_xlate(struct of_phandle_args *dma_spec,
-					    struct of_dma *ofdma)
+					    struct of_dma *ofdma,
+					    void *data)
 {
 	struct zynqmp_dma_device *zdev = ofdma->of_dma_data;
 
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 6de7c05d6bd8c99e176fe2fde0a9c3b55d40b37c..586f871234e60cd2e042bda124db5c8aed5ea814 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -1522,6 +1522,7 @@ struct dma_chan *__dma_request_channel(const dma_cap_mask_t *mask,
 				       dma_filter_fn fn, void *fn_param,
 				       struct device_node *np);
 
+struct dma_chan *dma_request_chan_w_data(struct device *dev, const char *name, void *data);
 struct dma_chan *dma_request_chan(struct device *dev, const char *name);
 struct dma_chan *dma_request_chan_by_mask(const dma_cap_mask_t *mask);
 struct dma_chan *devm_dma_request_chan(struct device *dev, const char *name);
@@ -1551,6 +1552,12 @@ static inline struct dma_chan *__dma_request_channel(const dma_cap_mask_t *mask,
 {
 	return NULL;
 }
+struct dma_chan *dma_request_chan_w_data(struct device *dev,
+					 const char *name,
+					 void *data)
+{
+	return ERR_PTR(-ENODEV);
+}
 static inline struct dma_chan *dma_request_chan(struct device *dev,
 						const char *name)
 {
diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
index fd706cdf255c61c82ce30ef9a2c44930bef34bc8..9f9bc4207b85d48d73c25aad4b362e7c84c01756 100644
--- a/include/linux/of_dma.h
+++ b/include/linux/of_dma.h
@@ -19,7 +19,7 @@ struct of_dma {
 	struct list_head	of_dma_controllers;
 	struct device_node	*of_node;
 	struct dma_chan		*(*of_dma_xlate)
-				(struct of_phandle_args *, struct of_dma *);
+				(struct of_phandle_args *, struct of_dma *, void *);
 	void			*(*of_dma_route_allocate)
 				(struct of_phandle_args *, struct of_dma *);
 	struct dma_router	*dma_router;
@@ -34,7 +34,7 @@ struct of_dma_filter_info {
 #ifdef CONFIG_DMA_OF
 extern int of_dma_controller_register(struct device_node *np,
 		struct dma_chan *(*of_dma_xlate)
-		(struct of_phandle_args *, struct of_dma *),
+		(struct of_phandle_args *, struct of_dma *, void *),
 		void *data);
 extern void of_dma_controller_free(struct device_node *np);
 
@@ -45,16 +45,17 @@ extern int of_dma_router_register(struct device_node *np,
 #define of_dma_router_free of_dma_controller_free
 
 extern struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
-						     const char *name);
+						     const char *name,
+						     void *data);
 extern struct dma_chan *of_dma_simple_xlate(struct of_phandle_args *dma_spec,
-		struct of_dma *ofdma);
+		struct of_dma *ofdma, void *data);
 extern struct dma_chan *of_dma_xlate_by_chan_id(struct of_phandle_args *dma_spec,
-		struct of_dma *ofdma);
+		struct of_dma *ofdma, void *data);
 
 #else
 static inline int of_dma_controller_register(struct device_node *np,
 		struct dma_chan *(*of_dma_xlate)
-		(struct of_phandle_args *, struct of_dma *),
+		(struct of_phandle_args *, struct of_dma *, void *),
 		void *data)
 {
 	return -ENODEV;
@@ -75,7 +76,8 @@ static inline int of_dma_router_register(struct device_node *np,
 #define of_dma_router_free of_dma_controller_free
 
 static inline struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
-						     const char *name)
+							    const char *name,
+							    void *data)
 {
 	return ERR_PTR(-ENODEV);
 }
diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c
index 5dd24ab90d0f052bb48f451cf009dc2e9128014d..43d48e4ac8161ee9955120fe64f7b911bfdfe1ca 100644
--- a/sound/soc/apple/mca.c
+++ b/sound/soc/apple/mca.c
@@ -926,7 +926,7 @@ static struct dma_chan *mca_request_dma_channel(struct mca_cluster *cl, unsigned
 	char *name = devm_kasprintf(cl->host->dev, GFP_KERNEL,
 				    is_tx ? "tx%da" : "rx%db", cl->no);
 #endif
-	return of_dma_request_slave_channel(cl->host->dev->of_node, name);
+	return of_dma_request_slave_channel(cl->host->dev->of_node, name, NULL);
 
 }
 
diff --git a/sound/soc/renesas/rcar/dma.c b/sound/soc/renesas/rcar/dma.c
index 2035ce06fe4c4aeaa8620d817910a5319732fa58..dcbff2fc61a0472adea226371016a128563b3cd0 100644
--- a/sound/soc/renesas/rcar/dma.c
+++ b/sound/soc/renesas/rcar/dma.c
@@ -204,7 +204,7 @@ struct dma_chan *rsnd_dma_request_channel(struct device_node *of_node, char *nam
 		}
 
 		if (i == rsnd_mod_id_raw(mod) && (!chan))
-			chan = of_dma_request_slave_channel(np, x);
+			chan = of_dma_request_slave_channel(np, x, NULL);
 		i++;
 	}
 

-- 
2.50.1

Re: [PATCH RFC 2/6] dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate

[Frank Li]

On Wed, Jul 30, 2025 at 11:33:29AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> The DMA subsystem attempts to make it theoretically possible to pair
> any DMA block with any user. While that's convenient from a
> codebase sanity perspective, some blocks are more intertwined.
>
> One such case is the Qualcomm GENI, where each wrapper contains a
> number of Serial Engine instances, each one of which can be programmed
> to support a different protocol (such as I2C, I3C, SPI, UART, etc.).
>
> The GPI DMA it's designed together with, needs to receive the ID of the
> protocol that's in use, to adjust its behavior accordingly. Currently,
> that's done through passing that ID through device tree, with each
> Serial Engine expressed NUM_PROTOCOL times, resulting in terrible
> dt-bindings that are full of useless copypasta.
>
> In a step to cut down on that, let the DMA user give the engine driver
> a hint at request time.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  drivers/dma/amba-pl08x.c                       |  3 ++-
>  drivers/dma/apple-admac.c                      |  3 ++-
>  drivers/dma/at_hdmac.c                         |  6 ++++--
>  drivers/dma/at_xdmac.c                         |  3 ++-
>  drivers/dma/bcm2835-dma.c                      |  3 ++-
>  drivers/dma/dma-jz4780.c                       |  3 ++-
>  drivers/dma/dmaengine.c                        | 20 +++++++++++++++++---
>  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c |  3 ++-
>  drivers/dma/dw/of.c                            |  3 ++-
>  drivers/dma/ep93xx_dma.c                       |  6 ++++--
>  drivers/dma/fsl-edma-main.c                    |  6 ++++--
>  drivers/dma/img-mdc-dma.c                      |  3 ++-
>  drivers/dma/imx-dma.c                          |  3 ++-
>  drivers/dma/imx-sdma.c                         |  3 ++-
>  drivers/dma/lgm/lgm-dma.c                      |  3 ++-
>  drivers/dma/milbeaut-hdmac.c                   |  4 +++-
>  drivers/dma/mmp_pdma.c                         |  3 ++-
>  drivers/dma/mmp_tdma.c                         |  3 ++-
>  drivers/dma/moxart-dma.c                       |  3 ++-
>  drivers/dma/mxs-dma.c                          |  3 ++-
>  drivers/dma/nbpfaxi.c                          |  3 ++-
>  drivers/dma/of-dma.c                           | 18 +++++++++++-------
>  drivers/dma/owl-dma.c                          |  3 ++-
>  drivers/dma/pl330.c                            |  3 ++-
>  drivers/dma/pxa_dma.c                          |  3 ++-
>  drivers/dma/qcom/bam_dma.c                     |  3 ++-
>  drivers/dma/qcom/gpi.c                         |  3 ++-
>  drivers/dma/qcom/qcom_adm.c                    |  3 ++-
>  drivers/dma/sh/rcar-dmac.c                     |  3 ++-
>  drivers/dma/sh/rz-dmac.c                       |  3 ++-
>  drivers/dma/sh/usb-dmac.c                      |  3 ++-
>  drivers/dma/st_fdma.c                          |  3 ++-
>  drivers/dma/ste_dma40.c                        |  3 ++-
>  drivers/dma/stm32/stm32-dma.c                  |  3 ++-
>  drivers/dma/stm32/stm32-dma3.c                 |  4 +++-
>  drivers/dma/stm32/stm32-mdma.c                 |  3 ++-
>  drivers/dma/sun4i-dma.c                        |  3 ++-
>  drivers/dma/sun6i-dma.c                        |  3 ++-
>  drivers/dma/tegra186-gpc-dma.c                 |  3 ++-
>  drivers/dma/tegra20-apb-dma.c                  |  3 ++-
>  drivers/dma/tegra210-adma.c                    |  3 ++-
>  drivers/dma/ti/cppi41.c                        |  3 ++-
>  drivers/dma/ti/edma.c                          |  3 ++-
>  drivers/dma/ti/k3-udma.c                       |  3 ++-
>  drivers/dma/uniphier-xdmac.c                   |  3 ++-
>  drivers/dma/xilinx/xilinx_dma.c                |  3 ++-
>  drivers/dma/xilinx/xilinx_dpdma.c              |  3 ++-
>  drivers/dma/xilinx/zynqmp_dma.c                |  3 ++-
>  include/linux/dmaengine.h                      |  7 +++++++
>  include/linux/of_dma.h                         | 16 +++++++++-------
>  sound/soc/apple/mca.c                          |  2 +-
>  sound/soc/renesas/rcar/dma.c                   |  2 +-
>  52 files changed, 146 insertions(+), 68 deletions(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c

...

>  						const char *name)
>  {
> diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
> index fd706cdf255c61c82ce30ef9a2c44930bef34bc8..9f9bc4207b85d48d73c25aad4b362e7c84c01756 100644
> --- a/include/linux/of_dma.h
> +++ b/include/linux/of_dma.h
> @@ -19,7 +19,7 @@ struct of_dma {
>  	struct list_head	of_dma_controllers;
>  	struct device_node	*of_node;
>  	struct dma_chan		*(*of_dma_xlate)
> -				(struct of_phandle_args *, struct of_dma *);
> +				(struct of_phandle_args *, struct of_dma *, void *);

I suggest pass down more informaiton, like client's dev point. So we can
auto create device link between client's dev and dma chan's device.

DMA Engineer device
   DMA chan device
       consumer clients' device.

If consumer device runtime pm suspend can auto trigger DMA chan's device's
runtime pm function.

It will simplifly DMA engine's run time pm manage. Currently many DMA run
time pm implement as, runtime_pm_get() when alloc and runtime_pm_put() at
free channel.  But many devices request dma channel at probe, which make
dma engine work at always 'on' state.

But ideally, dma chan should be resume only when it is used to transfer.

Frank

>  	void			*(*of_dma_route_allocate)
>  				(struct of_phandle_args *, struct of_dma *);
>  	struct dma_router	*dma_router;
> @@ -34,7 +34,7 @@ struct of_dma_filter_info {
>  #ifdef CONFIG_DMA_OF
>  extern int of_dma_controller_register(struct device_node *np,
>  		struct dma_chan *(*of_dma_xlate)
> -		(struct of_phandle_args *, struct of_dma *),
> +		(struct of_phandle_args *, struct of_dma *, void *),
>  		void *data);
>  extern void of_dma_controller_free(struct device_node *np);
>
> @@ -45,16 +45,17 @@ extern int of_dma_router_register(struct device_node *np,
>  #define of_dma_router_free of_dma_controller_free
>
>  extern struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
> -						     const char *name);
> +						     const char *name,
> +						     void *data);
>  extern struct dma_chan *of_dma_simple_xlate(struct of_phandle_args *dma_spec,
> -		struct of_dma *ofdma);
> +		struct of_dma *ofdma, void *data);
>  extern struct dma_chan *of_dma_xlate_by_chan_id(struct of_phandle_args *dma_spec,
> -		struct of_dma *ofdma);
> +		struct of_dma *ofdma, void *data);
>
>  #else
>  static inline int of_dma_controller_register(struct device_node *np,
>  		struct dma_chan *(*of_dma_xlate)
> -		(struct of_phandle_args *, struct of_dma *),
> +		(struct of_phandle_args *, struct of_dma *, void *),
>  		void *data)
>  {
>  	return -ENODEV;
> @@ -75,7 +76,8 @@ static inline int of_dma_router_register(struct device_node *np,
>  #define of_dma_router_free of_dma_controller_free
>
>  static inline struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
> -						     const char *name)
> +							    const char *name,
> +							    void *data)
>  {
>  	return ERR_PTR(-ENODEV);
>  }
> diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c
> index 5dd24ab90d0f052bb48f451cf009dc2e9128014d..43d48e4ac8161ee9955120fe64f7b911bfdfe1ca 100644
> --- a/sound/soc/apple/mca.c
> +++ b/sound/soc/apple/mca.c
> @@ -926,7 +926,7 @@ static struct dma_chan *mca_request_dma_channel(struct mca_cluster *cl, unsigned
>  	char *name = devm_kasprintf(cl->host->dev, GFP_KERNEL,
>  				    is_tx ? "tx%da" : "rx%db", cl->no);
>  #endif
> -	return of_dma_request_slave_channel(cl->host->dev->of_node, name);
> +	return of_dma_request_slave_channel(cl->host->dev->of_node, name, NULL);
>
>  }
>
> diff --git a/sound/soc/renesas/rcar/dma.c b/sound/soc/renesas/rcar/dma.c
> index 2035ce06fe4c4aeaa8620d817910a5319732fa58..dcbff2fc61a0472adea226371016a128563b3cd0 100644
> --- a/sound/soc/renesas/rcar/dma.c
> +++ b/sound/soc/renesas/rcar/dma.c
> @@ -204,7 +204,7 @@ struct dma_chan *rsnd_dma_request_channel(struct device_node *of_node, char *nam
>  		}
>
>  		if (i == rsnd_mod_id_raw(mod) && (!chan))
> -			chan = of_dma_request_slave_channel(np, x);
> +			chan = of_dma_request_slave_channel(np, x, NULL);
>  		i++;
>  	}
>
>
> --
> 2.50.1
>

Re: [PATCH RFC 2/6] dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate

[Laurent Pinchart]

On Wed, Jul 30, 2025 at 12:39:43PM -0400, Frank Li wrote:
> On Wed, Jul 30, 2025 at 11:33:29AM +0200, Konrad Dybcio wrote:
> > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >
> > The DMA subsystem attempts to make it theoretically possible to pair
> > any DMA block with any user. While that's convenient from a
> > codebase sanity perspective, some blocks are more intertwined.
> >
> > One such case is the Qualcomm GENI, where each wrapper contains a
> > number of Serial Engine instances, each one of which can be programmed
> > to support a different protocol (such as I2C, I3C, SPI, UART, etc.).
> >
> > The GPI DMA it's designed together with, needs to receive the ID of the
> > protocol that's in use, to adjust its behavior accordingly. Currently,
> > that's done through passing that ID through device tree, with each
> > Serial Engine expressed NUM_PROTOCOL times, resulting in terrible
> > dt-bindings that are full of useless copypasta.
> >
> > In a step to cut down on that, let the DMA user give the engine driver
> > a hint at request time.
> >
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > ---
> >  drivers/dma/amba-pl08x.c                       |  3 ++-
> >  drivers/dma/apple-admac.c                      |  3 ++-
> >  drivers/dma/at_hdmac.c                         |  6 ++++--
> >  drivers/dma/at_xdmac.c                         |  3 ++-
> >  drivers/dma/bcm2835-dma.c                      |  3 ++-
> >  drivers/dma/dma-jz4780.c                       |  3 ++-
> >  drivers/dma/dmaengine.c                        | 20 +++++++++++++++++---
> >  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c |  3 ++-
> >  drivers/dma/dw/of.c                            |  3 ++-
> >  drivers/dma/ep93xx_dma.c                       |  6 ++++--
> >  drivers/dma/fsl-edma-main.c                    |  6 ++++--
> >  drivers/dma/img-mdc-dma.c                      |  3 ++-
> >  drivers/dma/imx-dma.c                          |  3 ++-
> >  drivers/dma/imx-sdma.c                         |  3 ++-
> >  drivers/dma/lgm/lgm-dma.c                      |  3 ++-
> >  drivers/dma/milbeaut-hdmac.c                   |  4 +++-
> >  drivers/dma/mmp_pdma.c                         |  3 ++-
> >  drivers/dma/mmp_tdma.c                         |  3 ++-
> >  drivers/dma/moxart-dma.c                       |  3 ++-
> >  drivers/dma/mxs-dma.c                          |  3 ++-
> >  drivers/dma/nbpfaxi.c                          |  3 ++-
> >  drivers/dma/of-dma.c                           | 18 +++++++++++-------
> >  drivers/dma/owl-dma.c                          |  3 ++-
> >  drivers/dma/pl330.c                            |  3 ++-
> >  drivers/dma/pxa_dma.c                          |  3 ++-
> >  drivers/dma/qcom/bam_dma.c                     |  3 ++-
> >  drivers/dma/qcom/gpi.c                         |  3 ++-
> >  drivers/dma/qcom/qcom_adm.c                    |  3 ++-
> >  drivers/dma/sh/rcar-dmac.c                     |  3 ++-
> >  drivers/dma/sh/rz-dmac.c                       |  3 ++-
> >  drivers/dma/sh/usb-dmac.c                      |  3 ++-
> >  drivers/dma/st_fdma.c                          |  3 ++-
> >  drivers/dma/ste_dma40.c                        |  3 ++-
> >  drivers/dma/stm32/stm32-dma.c                  |  3 ++-
> >  drivers/dma/stm32/stm32-dma3.c                 |  4 +++-
> >  drivers/dma/stm32/stm32-mdma.c                 |  3 ++-
> >  drivers/dma/sun4i-dma.c                        |  3 ++-
> >  drivers/dma/sun6i-dma.c                        |  3 ++-
> >  drivers/dma/tegra186-gpc-dma.c                 |  3 ++-
> >  drivers/dma/tegra20-apb-dma.c                  |  3 ++-
> >  drivers/dma/tegra210-adma.c                    |  3 ++-
> >  drivers/dma/ti/cppi41.c                        |  3 ++-
> >  drivers/dma/ti/edma.c                          |  3 ++-
> >  drivers/dma/ti/k3-udma.c                       |  3 ++-
> >  drivers/dma/uniphier-xdmac.c                   |  3 ++-
> >  drivers/dma/xilinx/xilinx_dma.c                |  3 ++-
> >  drivers/dma/xilinx/xilinx_dpdma.c              |  3 ++-
> >  drivers/dma/xilinx/zynqmp_dma.c                |  3 ++-
> >  include/linux/dmaengine.h                      |  7 +++++++
> >  include/linux/of_dma.h                         | 16 +++++++++-------
> >  sound/soc/apple/mca.c                          |  2 +-
> >  sound/soc/renesas/rcar/dma.c                   |  2 +-
> >  52 files changed, 146 insertions(+), 68 deletions(-)
> >
> > diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> 
> ...
> 
> >  						const char *name)
> >  {
> > diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
> > index fd706cdf255c61c82ce30ef9a2c44930bef34bc8..9f9bc4207b85d48d73c25aad4b362e7c84c01756 100644
> > --- a/include/linux/of_dma.h
> > +++ b/include/linux/of_dma.h
> > @@ -19,7 +19,7 @@ struct of_dma {
> >  	struct list_head	of_dma_controllers;
> >  	struct device_node	*of_node;
> >  	struct dma_chan		*(*of_dma_xlate)
> > -				(struct of_phandle_args *, struct of_dma *);
> > +				(struct of_phandle_args *, struct of_dma *, void *);
> 
> I suggest pass down more informaiton, like client's dev point. So we can
> auto create device link between client's dev and dma chan's device.

Is .of_dma_xlate() really the right place to do that ? If you want to
create a device link for PM reasons, isn't it better created when the
channel is requested ? It should also be removed when the channel is
freed.

> 
> DMA Engineer device
>    DMA chan device
>        consumer clients' device.
> 
> If consumer device runtime pm suspend can auto trigger DMA chan's device's
> runtime pm function.
> 
> It will simplifly DMA engine's run time pm manage. Currently many DMA run
> time pm implement as, runtime_pm_get() when alloc and runtime_pm_put() at
> free channel.  But many devices request dma channel at probe, which make
> dma engine work at always 'on' state.
> 
> But ideally, dma chan should be resume only when it is used to transfer.

This is exactly what I was going to mention after reading the last
paragraph. Is there anything that prevents a DMA engine driver to
perform a rutime PM get() when a transfer is submitted and a put() when
it completes ? (Logically speaking, the actual implementation would
likely be a bit different in drivers, but the result would be similar.)

> >  	void			*(*of_dma_route_allocate)
> >  				(struct of_phandle_args *, struct of_dma *);
> >  	struct dma_router	*dma_router;
> > @@ -34,7 +34,7 @@ struct of_dma_filter_info {
> >  #ifdef CONFIG_DMA_OF
> >  extern int of_dma_controller_register(struct device_node *np,
> >  		struct dma_chan *(*of_dma_xlate)
> > -		(struct of_phandle_args *, struct of_dma *),
> > +		(struct of_phandle_args *, struct of_dma *, void *),
> >  		void *data);
> >  extern void of_dma_controller_free(struct device_node *np);
> >
> > @@ -45,16 +45,17 @@ extern int of_dma_router_register(struct device_node *np,
> >  #define of_dma_router_free of_dma_controller_free
> >
> >  extern struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
> > -						     const char *name);
> > +						     const char *name,
> > +						     void *data);
> >  extern struct dma_chan *of_dma_simple_xlate(struct of_phandle_args *dma_spec,
> > -		struct of_dma *ofdma);
> > +		struct of_dma *ofdma, void *data);
> >  extern struct dma_chan *of_dma_xlate_by_chan_id(struct of_phandle_args *dma_spec,
> > -		struct of_dma *ofdma);
> > +		struct of_dma *ofdma, void *data);
> >
> >  #else
> >  static inline int of_dma_controller_register(struct device_node *np,
> >  		struct dma_chan *(*of_dma_xlate)
> > -		(struct of_phandle_args *, struct of_dma *),
> > +		(struct of_phandle_args *, struct of_dma *, void *),
> >  		void *data)
> >  {
> >  	return -ENODEV;
> > @@ -75,7 +76,8 @@ static inline int of_dma_router_register(struct device_node *np,
> >  #define of_dma_router_free of_dma_controller_free
> >
> >  static inline struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
> > -						     const char *name)
> > +							    const char *name,
> > +							    void *data)
> >  {
> >  	return ERR_PTR(-ENODEV);
> >  }
> > diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c
> > index 5dd24ab90d0f052bb48f451cf009dc2e9128014d..43d48e4ac8161ee9955120fe64f7b911bfdfe1ca 100644
> > --- a/sound/soc/apple/mca.c
> > +++ b/sound/soc/apple/mca.c
> > @@ -926,7 +926,7 @@ static struct dma_chan *mca_request_dma_channel(struct mca_cluster *cl, unsigned
> >  	char *name = devm_kasprintf(cl->host->dev, GFP_KERNEL,
> >  				    is_tx ? "tx%da" : "rx%db", cl->no);
> >  #endif
> > -	return of_dma_request_slave_channel(cl->host->dev->of_node, name);
> > +	return of_dma_request_slave_channel(cl->host->dev->of_node, name, NULL);
> >
> >  }
> >
> > diff --git a/sound/soc/renesas/rcar/dma.c b/sound/soc/renesas/rcar/dma.c
> > index 2035ce06fe4c4aeaa8620d817910a5319732fa58..dcbff2fc61a0472adea226371016a128563b3cd0 100644
> > --- a/sound/soc/renesas/rcar/dma.c
> > +++ b/sound/soc/renesas/rcar/dma.c
> > @@ -204,7 +204,7 @@ struct dma_chan *rsnd_dma_request_channel(struct device_node *of_node, char *nam
> >  		}
> >
> >  		if (i == rsnd_mod_id_raw(mod) && (!chan))
> > -			chan = of_dma_request_slave_channel(np, x);
> > +			chan = of_dma_request_slave_channel(np, x, NULL);
> >  		i++;
> >  	}
> >

-- 
Regards,

Laurent Pinchart

Re: [PATCH RFC 2/6] dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate

[Frank Li]

On Wed, Jul 30, 2025 at 09:04:17PM +0300, Laurent Pinchart wrote:
> On Wed, Jul 30, 2025 at 12:39:43PM -0400, Frank Li wrote:
> > On Wed, Jul 30, 2025 at 11:33:29AM +0200, Konrad Dybcio wrote:
> > > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > >
> > > The DMA subsystem attempts to make it theoretically possible to pair
> > > any DMA block with any user. While that's convenient from a
> > > codebase sanity perspective, some blocks are more intertwined.
> > >
> > > One such case is the Qualcomm GENI, where each wrapper contains a
> > > number of Serial Engine instances, each one of which can be programmed
> > > to support a different protocol (such as I2C, I3C, SPI, UART, etc.).
> > >
> > > The GPI DMA it's designed together with, needs to receive the ID of the
> > > protocol that's in use, to adjust its behavior accordingly. Currently,
> > > that's done through passing that ID through device tree, with each
> > > Serial Engine expressed NUM_PROTOCOL times, resulting in terrible
> > > dt-bindings that are full of useless copypasta.
> > >
> > > In a step to cut down on that, let the DMA user give the engine driver
> > > a hint at request time.
> > >
> > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > > ---
> > >  drivers/dma/amba-pl08x.c                       |  3 ++-
> > >  drivers/dma/apple-admac.c                      |  3 ++-
> > >  drivers/dma/at_hdmac.c                         |  6 ++++--
> > >  drivers/dma/at_xdmac.c                         |  3 ++-
> > >  drivers/dma/bcm2835-dma.c                      |  3 ++-
> > >  drivers/dma/dma-jz4780.c                       |  3 ++-
> > >  drivers/dma/dmaengine.c                        | 20 +++++++++++++++++---
> > >  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c |  3 ++-
> > >  drivers/dma/dw/of.c                            |  3 ++-
> > >  drivers/dma/ep93xx_dma.c                       |  6 ++++--
> > >  drivers/dma/fsl-edma-main.c                    |  6 ++++--
> > >  drivers/dma/img-mdc-dma.c                      |  3 ++-
> > >  drivers/dma/imx-dma.c                          |  3 ++-
> > >  drivers/dma/imx-sdma.c                         |  3 ++-
> > >  drivers/dma/lgm/lgm-dma.c                      |  3 ++-
> > >  drivers/dma/milbeaut-hdmac.c                   |  4 +++-
> > >  drivers/dma/mmp_pdma.c                         |  3 ++-
> > >  drivers/dma/mmp_tdma.c                         |  3 ++-
> > >  drivers/dma/moxart-dma.c                       |  3 ++-
> > >  drivers/dma/mxs-dma.c                          |  3 ++-
> > >  drivers/dma/nbpfaxi.c                          |  3 ++-
> > >  drivers/dma/of-dma.c                           | 18 +++++++++++-------
> > >  drivers/dma/owl-dma.c                          |  3 ++-
> > >  drivers/dma/pl330.c                            |  3 ++-
> > >  drivers/dma/pxa_dma.c                          |  3 ++-
> > >  drivers/dma/qcom/bam_dma.c                     |  3 ++-
> > >  drivers/dma/qcom/gpi.c                         |  3 ++-
> > >  drivers/dma/qcom/qcom_adm.c                    |  3 ++-
> > >  drivers/dma/sh/rcar-dmac.c                     |  3 ++-
> > >  drivers/dma/sh/rz-dmac.c                       |  3 ++-
> > >  drivers/dma/sh/usb-dmac.c                      |  3 ++-
> > >  drivers/dma/st_fdma.c                          |  3 ++-
> > >  drivers/dma/ste_dma40.c                        |  3 ++-
> > >  drivers/dma/stm32/stm32-dma.c                  |  3 ++-
> > >  drivers/dma/stm32/stm32-dma3.c                 |  4 +++-
> > >  drivers/dma/stm32/stm32-mdma.c                 |  3 ++-
> > >  drivers/dma/sun4i-dma.c                        |  3 ++-
> > >  drivers/dma/sun6i-dma.c                        |  3 ++-
> > >  drivers/dma/tegra186-gpc-dma.c                 |  3 ++-
> > >  drivers/dma/tegra20-apb-dma.c                  |  3 ++-
> > >  drivers/dma/tegra210-adma.c                    |  3 ++-
> > >  drivers/dma/ti/cppi41.c                        |  3 ++-
> > >  drivers/dma/ti/edma.c                          |  3 ++-
> > >  drivers/dma/ti/k3-udma.c                       |  3 ++-
> > >  drivers/dma/uniphier-xdmac.c                   |  3 ++-
> > >  drivers/dma/xilinx/xilinx_dma.c                |  3 ++-
> > >  drivers/dma/xilinx/xilinx_dpdma.c              |  3 ++-
> > >  drivers/dma/xilinx/zynqmp_dma.c                |  3 ++-
> > >  include/linux/dmaengine.h                      |  7 +++++++
> > >  include/linux/of_dma.h                         | 16 +++++++++-------
> > >  sound/soc/apple/mca.c                          |  2 +-
> > >  sound/soc/renesas/rcar/dma.c                   |  2 +-
> > >  52 files changed, 146 insertions(+), 68 deletions(-)
> > >
> > > diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> >
> > ...
> >
> > >  						const char *name)
> > >  {
> > > diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
> > > index fd706cdf255c61c82ce30ef9a2c44930bef34bc8..9f9bc4207b85d48d73c25aad4b362e7c84c01756 100644
> > > --- a/include/linux/of_dma.h
> > > +++ b/include/linux/of_dma.h
> > > @@ -19,7 +19,7 @@ struct of_dma {
> > >  	struct list_head	of_dma_controllers;
> > >  	struct device_node	*of_node;
> > >  	struct dma_chan		*(*of_dma_xlate)
> > > -				(struct of_phandle_args *, struct of_dma *);
> > > +				(struct of_phandle_args *, struct of_dma *, void *);
> >
> > I suggest pass down more informaiton, like client's dev point. So we can
> > auto create device link between client's dev and dma chan's device.
>
> Is .of_dma_xlate() really the right place to do that ? If you want to
> create a device link for PM reasons, isn't it better created when the
> channel is requested ? It should also be removed when the channel is
> freed.

I remember just need record client device pointer here.

>
> >
> > DMA Engineer device
> >    DMA chan device
> >        consumer clients' device.
> >
> > If consumer device runtime pm suspend can auto trigger DMA chan's device's
> > runtime pm function.
> >
> > It will simplifly DMA engine's run time pm manage. Currently many DMA run
> > time pm implement as, runtime_pm_get() when alloc and runtime_pm_put() at
> > free channel.  But many devices request dma channel at probe, which make
> > dma engine work at always 'on' state.
> >
> > But ideally, dma chan should be resume only when it is used to transfer.
>
> This is exactly what I was going to mention after reading the last
> paragraph. Is there anything that prevents a DMA engine driver to
> perform a rutime PM get() when a transfer is submitted

DMA description is a queue, It is hard to track each descriptor submit and
finished. espcially cycle buffer case.

And according to dma engine API defination, submit a descriptor not
neccessary to turn on clock, maybe just pure software operation, such as
enqueue it to a software list.

Many driver call dmaengine_submit() in irq context,  submit new descriptor
when previous descriptor finished. runtime_pm_get() can NOT be called in
atomic context.

And some driver submit many descripor advance. Only issue_transfer() is
actually trigger hardware to start transfer.

Some client use cycle descripor, such audio devices.  Some audio devices
have not free descriptor at their run time suspend function, just disable
audio devices's clocks.  Audio devices run time suspend, which means no
one use this dma channel, dma channel can auto suspend if built device link
between audio device and dma chan devices.

Some DMA client have not devices, such as memory to memory. for this kind
case, it need keep chan always on.

issue_transfer() can be call in atomic context. but trigger hardware transfer
need clock and runtime_pm_get() can't be called in atomic context.

Most case issue_transfer() is call in irq handle, which means device should
already be in runtime resume statue.  DMA engine can safely access their
register if using device link.

Frank

> and a put() when
> it completes ? (Logically speaking, the actual implementation would
> likely be a bit different in drivers, but the result would be similar.)
>
> > >  	void			*(*of_dma_route_allocate)
> > >  				(struct of_phandle_args *, struct of_dma *);
> > >  	struct dma_router	*dma_router;
> > > @@ -34,7 +34,7 @@ struct of_dma_filter_info {
> > >  #ifdef CONFIG_DMA_OF
> > >  extern int of_dma_controller_register(struct device_node *np,
> > >  		struct dma_chan *(*of_dma_xlate)
> > > -		(struct of_phandle_args *, struct of_dma *),
> > > +		(struct of_phandle_args *, struct of_dma *, void *),
> > >  		void *data);
> > >  extern void of_dma_controller_free(struct device_node *np);
> > >
> > > @@ -45,16 +45,17 @@ extern int of_dma_router_register(struct device_node *np,
> > >  #define of_dma_router_free of_dma_controller_free
> > >
> > >  extern struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
> > > -						     const char *name);
> > > +						     const char *name,
> > > +						     void *data);
> > >  extern struct dma_chan *of_dma_simple_xlate(struct of_phandle_args *dma_spec,
> > > -		struct of_dma *ofdma);
> > > +		struct of_dma *ofdma, void *data);
> > >  extern struct dma_chan *of_dma_xlate_by_chan_id(struct of_phandle_args *dma_spec,
> > > -		struct of_dma *ofdma);
> > > +		struct of_dma *ofdma, void *data);
> > >
> > >  #else
> > >  static inline int of_dma_controller_register(struct device_node *np,
> > >  		struct dma_chan *(*of_dma_xlate)
> > > -		(struct of_phandle_args *, struct of_dma *),
> > > +		(struct of_phandle_args *, struct of_dma *, void *),
> > >  		void *data)
> > >  {
> > >  	return -ENODEV;
> > > @@ -75,7 +76,8 @@ static inline int of_dma_router_register(struct device_node *np,
> > >  #define of_dma_router_free of_dma_controller_free
> > >
> > >  static inline struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
> > > -						     const char *name)
> > > +							    const char *name,
> > > +							    void *data)
> > >  {
> > >  	return ERR_PTR(-ENODEV);
> > >  }
> > > diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c
> > > index 5dd24ab90d0f052bb48f451cf009dc2e9128014d..43d48e4ac8161ee9955120fe64f7b911bfdfe1ca 100644
> > > --- a/sound/soc/apple/mca.c
> > > +++ b/sound/soc/apple/mca.c
> > > @@ -926,7 +926,7 @@ static struct dma_chan *mca_request_dma_channel(struct mca_cluster *cl, unsigned
> > >  	char *name = devm_kasprintf(cl->host->dev, GFP_KERNEL,
> > >  				    is_tx ? "tx%da" : "rx%db", cl->no);
> > >  #endif
> > > -	return of_dma_request_slave_channel(cl->host->dev->of_node, name);
> > > +	return of_dma_request_slave_channel(cl->host->dev->of_node, name, NULL);
> > >
> > >  }
> > >
> > > diff --git a/sound/soc/renesas/rcar/dma.c b/sound/soc/renesas/rcar/dma.c
> > > index 2035ce06fe4c4aeaa8620d817910a5319732fa58..dcbff2fc61a0472adea226371016a128563b3cd0 100644
> > > --- a/sound/soc/renesas/rcar/dma.c
> > > +++ b/sound/soc/renesas/rcar/dma.c
> > > @@ -204,7 +204,7 @@ struct dma_chan *rsnd_dma_request_channel(struct device_node *of_node, char *nam
> > >  		}
> > >
> > >  		if (i == rsnd_mod_id_raw(mod) && (!chan))
> > > -			chan = of_dma_request_slave_channel(np, x);
> > > +			chan = of_dma_request_slave_channel(np, x, NULL);
> > >  		i++;
> > >  	}
> > >
>
> --
> Regards,
>
> Laurent Pinchart

Re: [PATCH RFC 2/6] dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate

[Laurent Pinchart]

Hi Frank,

On Wed, Jul 30, 2025 at 02:37:54PM -0400, Frank Li wrote:
> On Wed, Jul 30, 2025 at 09:04:17PM +0300, Laurent Pinchart wrote:
> > On Wed, Jul 30, 2025 at 12:39:43PM -0400, Frank Li wrote:
> > > On Wed, Jul 30, 2025 at 11:33:29AM +0200, Konrad Dybcio wrote:
> > > > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > > >
> > > > The DMA subsystem attempts to make it theoretically possible to pair
> > > > any DMA block with any user. While that's convenient from a
> > > > codebase sanity perspective, some blocks are more intertwined.
> > > >
> > > > One such case is the Qualcomm GENI, where each wrapper contains a
> > > > number of Serial Engine instances, each one of which can be programmed
> > > > to support a different protocol (such as I2C, I3C, SPI, UART, etc.).
> > > >
> > > > The GPI DMA it's designed together with, needs to receive the ID of the
> > > > protocol that's in use, to adjust its behavior accordingly. Currently,
> > > > that's done through passing that ID through device tree, with each
> > > > Serial Engine expressed NUM_PROTOCOL times, resulting in terrible
> > > > dt-bindings that are full of useless copypasta.
> > > >
> > > > In a step to cut down on that, let the DMA user give the engine driver
> > > > a hint at request time.
> > > >
> > > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > > > ---
> > > >  drivers/dma/amba-pl08x.c                       |  3 ++-
> > > >  drivers/dma/apple-admac.c                      |  3 ++-
> > > >  drivers/dma/at_hdmac.c                         |  6 ++++--
> > > >  drivers/dma/at_xdmac.c                         |  3 ++-
> > > >  drivers/dma/bcm2835-dma.c                      |  3 ++-
> > > >  drivers/dma/dma-jz4780.c                       |  3 ++-
> > > >  drivers/dma/dmaengine.c                        | 20 +++++++++++++++++---
> > > >  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c |  3 ++-
> > > >  drivers/dma/dw/of.c                            |  3 ++-
> > > >  drivers/dma/ep93xx_dma.c                       |  6 ++++--
> > > >  drivers/dma/fsl-edma-main.c                    |  6 ++++--
> > > >  drivers/dma/img-mdc-dma.c                      |  3 ++-
> > > >  drivers/dma/imx-dma.c                          |  3 ++-
> > > >  drivers/dma/imx-sdma.c                         |  3 ++-
> > > >  drivers/dma/lgm/lgm-dma.c                      |  3 ++-
> > > >  drivers/dma/milbeaut-hdmac.c                   |  4 +++-
> > > >  drivers/dma/mmp_pdma.c                         |  3 ++-
> > > >  drivers/dma/mmp_tdma.c                         |  3 ++-
> > > >  drivers/dma/moxart-dma.c                       |  3 ++-
> > > >  drivers/dma/mxs-dma.c                          |  3 ++-
> > > >  drivers/dma/nbpfaxi.c                          |  3 ++-
> > > >  drivers/dma/of-dma.c                           | 18 +++++++++++-------
> > > >  drivers/dma/owl-dma.c                          |  3 ++-
> > > >  drivers/dma/pl330.c                            |  3 ++-
> > > >  drivers/dma/pxa_dma.c                          |  3 ++-
> > > >  drivers/dma/qcom/bam_dma.c                     |  3 ++-
> > > >  drivers/dma/qcom/gpi.c                         |  3 ++-
> > > >  drivers/dma/qcom/qcom_adm.c                    |  3 ++-
> > > >  drivers/dma/sh/rcar-dmac.c                     |  3 ++-
> > > >  drivers/dma/sh/rz-dmac.c                       |  3 ++-
> > > >  drivers/dma/sh/usb-dmac.c                      |  3 ++-
> > > >  drivers/dma/st_fdma.c                          |  3 ++-
> > > >  drivers/dma/ste_dma40.c                        |  3 ++-
> > > >  drivers/dma/stm32/stm32-dma.c                  |  3 ++-
> > > >  drivers/dma/stm32/stm32-dma3.c                 |  4 +++-
> > > >  drivers/dma/stm32/stm32-mdma.c                 |  3 ++-
> > > >  drivers/dma/sun4i-dma.c                        |  3 ++-
> > > >  drivers/dma/sun6i-dma.c                        |  3 ++-
> > > >  drivers/dma/tegra186-gpc-dma.c                 |  3 ++-
> > > >  drivers/dma/tegra20-apb-dma.c                  |  3 ++-
> > > >  drivers/dma/tegra210-adma.c                    |  3 ++-
> > > >  drivers/dma/ti/cppi41.c                        |  3 ++-
> > > >  drivers/dma/ti/edma.c                          |  3 ++-
> > > >  drivers/dma/ti/k3-udma.c                       |  3 ++-
> > > >  drivers/dma/uniphier-xdmac.c                   |  3 ++-
> > > >  drivers/dma/xilinx/xilinx_dma.c                |  3 ++-
> > > >  drivers/dma/xilinx/xilinx_dpdma.c              |  3 ++-
> > > >  drivers/dma/xilinx/zynqmp_dma.c                |  3 ++-
> > > >  include/linux/dmaengine.h                      |  7 +++++++
> > > >  include/linux/of_dma.h                         | 16 +++++++++-------
> > > >  sound/soc/apple/mca.c                          |  2 +-
> > > >  sound/soc/renesas/rcar/dma.c                   |  2 +-
> > > >  52 files changed, 146 insertions(+), 68 deletions(-)
> > > >
> > > > diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> > >
> > > ...
> > >
> > > >  						const char *name)
> > > >  {
> > > > diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
> > > > index fd706cdf255c61c82ce30ef9a2c44930bef34bc8..9f9bc4207b85d48d73c25aad4b362e7c84c01756 100644
> > > > --- a/include/linux/of_dma.h
> > > > +++ b/include/linux/of_dma.h
> > > > @@ -19,7 +19,7 @@ struct of_dma {
> > > >  	struct list_head	of_dma_controllers;
> > > >  	struct device_node	*of_node;
> > > >  	struct dma_chan		*(*of_dma_xlate)
> > > > -				(struct of_phandle_args *, struct of_dma *);
> > > > +				(struct of_phandle_args *, struct of_dma *, void *);
> > >
> > > I suggest pass down more informaiton, like client's dev point. So we can
> > > auto create device link between client's dev and dma chan's device.
> >
> > Is .of_dma_xlate() really the right place to do that ? If you want to
> > create a device link for PM reasons, isn't it better created when the
> > channel is requested ? It should also be removed when the channel is
> > freed.
> 
> I remember just need record client device pointer here.
> 
> > >
> > > DMA Engineer device
> > >    DMA chan device
> > >        consumer clients' device.
> > >
> > > If consumer device runtime pm suspend can auto trigger DMA chan's device's
> > > runtime pm function.
> > >
> > > It will simplifly DMA engine's run time pm manage. Currently many DMA run
> > > time pm implement as, runtime_pm_get() when alloc and runtime_pm_put() at
> > > free channel.  But many devices request dma channel at probe, which make
> > > dma engine work at always 'on' state.
> > >
> > > But ideally, dma chan should be resume only when it is used to transfer.
> >
> > This is exactly what I was going to mention after reading the last
> > paragraph. Is there anything that prevents a DMA engine driver to
> > perform a rutime PM get() when a transfer is submitted
> 
> DMA description is a queue, It is hard to track each descriptor submit and
> finished. espcially cycle buffer case.
> 
> And according to dma engine API defination, submit a descriptor not
> neccessary to turn on clock, maybe just pure software operation, such as
> enqueue it to a software list.
> 
> Many driver call dmaengine_submit() in irq context,  submit new descriptor
> when previous descriptor finished. runtime_pm_get() can NOT be called in
> atomic context.
> 
> And some driver submit many descripor advance. Only issue_transfer() is
> actually trigger hardware to start transfer.
> 
> Some client use cycle descripor, such audio devices.  Some audio devices
> have not free descriptor at their run time suspend function, just disable
> audio devices's clocks.  Audio devices run time suspend, which means no
> one use this dma channel, dma channel can auto suspend if built device link
> between audio device and dma chan devices.
> 
> Some DMA client have not devices, such as memory to memory. for this kind
> case, it need keep chan always on.
> 
> issue_transfer() can be call in atomic context. but trigger hardware transfer
> need clock and runtime_pm_get() can't be called in atomic context.
> 
> Most case issue_transfer() is call in irq handle, which means device should
> already be in runtime resume statue.  DMA engine can safely access their
> register if using device link.

You have good points there, in particular the fact the issue_transfer()
can be called in interrupt context.

For me this calls for new DMA engine operations to "start/stop" the DMA
engine (better names are likely needed) from a client perspective.

> > and a put() when
> > it completes ? (Logically speaking, the actual implementation would
> > likely be a bit different in drivers, but the result would be similar.)
> >
> > > >  	void			*(*of_dma_route_allocate)
> > > >  				(struct of_phandle_args *, struct of_dma *);
> > > >  	struct dma_router	*dma_router;
> > > > @@ -34,7 +34,7 @@ struct of_dma_filter_info {
> > > >  #ifdef CONFIG_DMA_OF
> > > >  extern int of_dma_controller_register(struct device_node *np,
> > > >  		struct dma_chan *(*of_dma_xlate)
> > > > -		(struct of_phandle_args *, struct of_dma *),
> > > > +		(struct of_phandle_args *, struct of_dma *, void *),
> > > >  		void *data);
> > > >  extern void of_dma_controller_free(struct device_node *np);
> > > >
> > > > @@ -45,16 +45,17 @@ extern int of_dma_router_register(struct device_node *np,
> > > >  #define of_dma_router_free of_dma_controller_free
> > > >
> > > >  extern struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
> > > > -						     const char *name);
> > > > +						     const char *name,
> > > > +						     void *data);
> > > >  extern struct dma_chan *of_dma_simple_xlate(struct of_phandle_args *dma_spec,
> > > > -		struct of_dma *ofdma);
> > > > +		struct of_dma *ofdma, void *data);
> > > >  extern struct dma_chan *of_dma_xlate_by_chan_id(struct of_phandle_args *dma_spec,
> > > > -		struct of_dma *ofdma);
> > > > +		struct of_dma *ofdma, void *data);
> > > >
> > > >  #else
> > > >  static inline int of_dma_controller_register(struct device_node *np,
> > > >  		struct dma_chan *(*of_dma_xlate)
> > > > -		(struct of_phandle_args *, struct of_dma *),
> > > > +		(struct of_phandle_args *, struct of_dma *, void *),
> > > >  		void *data)
> > > >  {
> > > >  	return -ENODEV;
> > > > @@ -75,7 +76,8 @@ static inline int of_dma_router_register(struct device_node *np,
> > > >  #define of_dma_router_free of_dma_controller_free
> > > >
> > > >  static inline struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
> > > > -						     const char *name)
> > > > +							    const char *name,
> > > > +							    void *data)
> > > >  {
> > > >  	return ERR_PTR(-ENODEV);
> > > >  }
> > > > diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c
> > > > index 5dd24ab90d0f052bb48f451cf009dc2e9128014d..43d48e4ac8161ee9955120fe64f7b911bfdfe1ca 100644
> > > > --- a/sound/soc/apple/mca.c
> > > > +++ b/sound/soc/apple/mca.c
> > > > @@ -926,7 +926,7 @@ static struct dma_chan *mca_request_dma_channel(struct mca_cluster *cl, unsigned
> > > >  	char *name = devm_kasprintf(cl->host->dev, GFP_KERNEL,
> > > >  				    is_tx ? "tx%da" : "rx%db", cl->no);
> > > >  #endif
> > > > -	return of_dma_request_slave_channel(cl->host->dev->of_node, name);
> > > > +	return of_dma_request_slave_channel(cl->host->dev->of_node, name, NULL);
> > > >
> > > >  }
> > > >
> > > > diff --git a/sound/soc/renesas/rcar/dma.c b/sound/soc/renesas/rcar/dma.c
> > > > index 2035ce06fe4c4aeaa8620d817910a5319732fa58..dcbff2fc61a0472adea226371016a128563b3cd0 100644
> > > > --- a/sound/soc/renesas/rcar/dma.c
> > > > +++ b/sound/soc/renesas/rcar/dma.c
> > > > @@ -204,7 +204,7 @@ struct dma_chan *rsnd_dma_request_channel(struct device_node *of_node, char *nam
> > > >  		}
> > > >
> > > >  		if (i == rsnd_mod_id_raw(mod) && (!chan))
> > > > -			chan = of_dma_request_slave_channel(np, x);
> > > > +			chan = of_dma_request_slave_channel(np, x, NULL);
> > > >  		i++;
> > > >  	}
> > > >

-- 
Regards,

Laurent Pinchart

Re: [PATCH RFC 2/6] dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate

[Konrad Dybcio]

On 8/1/25 2:00 PM, Laurent Pinchart wrote:
> Hi Frank,
> 
> On Wed, Jul 30, 2025 at 02:37:54PM -0400, Frank Li wrote:
>> On Wed, Jul 30, 2025 at 09:04:17PM +0300, Laurent Pinchart wrote:
>>> On Wed, Jul 30, 2025 at 12:39:43PM -0400, Frank Li wrote:
>>>> On Wed, Jul 30, 2025 at 11:33:29AM +0200, Konrad Dybcio wrote:
>>>>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>>>>
>>>>> The DMA subsystem attempts to make it theoretically possible to pair
>>>>> any DMA block with any user. While that's convenient from a
>>>>> codebase sanity perspective, some blocks are more intertwined.
>>>>>
>>>>> One such case is the Qualcomm GENI, where each wrapper contains a
>>>>> number of Serial Engine instances, each one of which can be programmed
>>>>> to support a different protocol (such as I2C, I3C, SPI, UART, etc.).
>>>>>
>>>>> The GPI DMA it's designed together with, needs to receive the ID of the
>>>>> protocol that's in use, to adjust its behavior accordingly. Currently,
>>>>> that's done through passing that ID through device tree, with each
>>>>> Serial Engine expressed NUM_PROTOCOL times, resulting in terrible
>>>>> dt-bindings that are full of useless copypasta.
>>>>>
>>>>> In a step to cut down on that, let the DMA user give the engine driver
>>>>> a hint at request time.
>>>>>
>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>>>> ---

[...]

>>>>> diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
>>>>> index fd706cdf255c61c82ce30ef9a2c44930bef34bc8..9f9bc4207b85d48d73c25aad4b362e7c84c01756 100644
>>>>> --- a/include/linux/of_dma.h
>>>>> +++ b/include/linux/of_dma.h
>>>>> @@ -19,7 +19,7 @@ struct of_dma {
>>>>>  	struct list_head	of_dma_controllers;
>>>>>  	struct device_node	*of_node;
>>>>>  	struct dma_chan		*(*of_dma_xlate)
>>>>> -				(struct of_phandle_args *, struct of_dma *);
>>>>> +				(struct of_phandle_args *, struct of_dma *, void *);
>>>>
>>>> I suggest pass down more informaiton, like client's dev point. So we can
>>>> auto create device link between client's dev and dma chan's device.
>>>
>>> Is .of_dma_xlate() really the right place to do that ? If you want to
>>> create a device link for PM reasons, isn't it better created when the
>>> channel is requested ? It should also be removed when the channel is
>>> freed.
>>
>> I remember just need record client device pointer here.
>>
>>>>
>>>> DMA Engineer device
>>>>    DMA chan device
>>>>        consumer clients' device.
>>>>
>>>> If consumer device runtime pm suspend can auto trigger DMA chan's device's
>>>> runtime pm function.
>>>>
>>>> It will simplifly DMA engine's run time pm manage. Currently many DMA run
>>>> time pm implement as, runtime_pm_get() when alloc and runtime_pm_put() at
>>>> free channel.  But many devices request dma channel at probe, which make
>>>> dma engine work at always 'on' state.
>>>>
>>>> But ideally, dma chan should be resume only when it is used to transfer.
>>>
>>> This is exactly what I was going to mention after reading the last
>>> paragraph. Is there anything that prevents a DMA engine driver to
>>> perform a rutime PM get() when a transfer is submitted
>>
>> DMA description is a queue, It is hard to track each descriptor submit and
>> finished. espcially cycle buffer case.
>>
>> And according to dma engine API defination, submit a descriptor not
>> neccessary to turn on clock, maybe just pure software operation, such as
>> enqueue it to a software list.
>>
>> Many driver call dmaengine_submit() in irq context,  submit new descriptor
>> when previous descriptor finished. runtime_pm_get() can NOT be called in
>> atomic context.
>>
>> And some driver submit many descripor advance. Only issue_transfer() is
>> actually trigger hardware to start transfer.
>>
>> Some client use cycle descripor, such audio devices.  Some audio devices
>> have not free descriptor at their run time suspend function, just disable
>> audio devices's clocks.  Audio devices run time suspend, which means no
>> one use this dma channel, dma channel can auto suspend if built device link
>> between audio device and dma chan devices.
>>
>> Some DMA client have not devices, such as memory to memory. for this kind
>> case, it need keep chan always on.
>>
>> issue_transfer() can be call in atomic context. but trigger hardware transfer
>> need clock and runtime_pm_get() can't be called in atomic context.
>>
>> Most case issue_transfer() is call in irq handle, which means device should
>> already be in runtime resume statue.  DMA engine can safely access their
>> register if using device link.
> 
> You have good points there, in particular the fact the issue_transfer()
> can be called in interrupt context.
> 
> For me this calls for new DMA engine operations to "start/stop" the DMA
> engine (better names are likely needed) from a client perspective.
> 
>>> and a put() when
>>> it completes ? (Logically speaking, the actual implementation would
>>> likely be a bit different in drivers, but the result would be similar.)

So.. do you folks want me to alter the patch in any way?

Konrad

Re: [PATCH RFC 2/6] dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate

[Laurent Pinchart]

On Sat, Aug 02, 2025 at 02:37:54PM +0200, Konrad Dybcio wrote:
> On 8/1/25 2:00 PM, Laurent Pinchart wrote:
> > On Wed, Jul 30, 2025 at 02:37:54PM -0400, Frank Li wrote:
> >> On Wed, Jul 30, 2025 at 09:04:17PM +0300, Laurent Pinchart wrote:
> >>> On Wed, Jul 30, 2025 at 12:39:43PM -0400, Frank Li wrote:
> >>>> On Wed, Jul 30, 2025 at 11:33:29AM +0200, Konrad Dybcio wrote:
> >>>>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >>>>>
> >>>>> The DMA subsystem attempts to make it theoretically possible to pair
> >>>>> any DMA block with any user. While that's convenient from a
> >>>>> codebase sanity perspective, some blocks are more intertwined.
> >>>>>
> >>>>> One such case is the Qualcomm GENI, where each wrapper contains a
> >>>>> number of Serial Engine instances, each one of which can be programmed
> >>>>> to support a different protocol (such as I2C, I3C, SPI, UART, etc.).
> >>>>>
> >>>>> The GPI DMA it's designed together with, needs to receive the ID of the
> >>>>> protocol that's in use, to adjust its behavior accordingly. Currently,
> >>>>> that's done through passing that ID through device tree, with each
> >>>>> Serial Engine expressed NUM_PROTOCOL times, resulting in terrible
> >>>>> dt-bindings that are full of useless copypasta.
> >>>>>
> >>>>> In a step to cut down on that, let the DMA user give the engine driver
> >>>>> a hint at request time.
> >>>>>
> >>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >>>>> ---
> 
> [...]
> 
> >>>>> diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
> >>>>> index fd706cdf255c61c82ce30ef9a2c44930bef34bc8..9f9bc4207b85d48d73c25aad4b362e7c84c01756 100644
> >>>>> --- a/include/linux/of_dma.h
> >>>>> +++ b/include/linux/of_dma.h
> >>>>> @@ -19,7 +19,7 @@ struct of_dma {
> >>>>>  	struct list_head	of_dma_controllers;
> >>>>>  	struct device_node	*of_node;
> >>>>>  	struct dma_chan		*(*of_dma_xlate)
> >>>>> -				(struct of_phandle_args *, struct of_dma *);
> >>>>> +				(struct of_phandle_args *, struct of_dma *, void *);
> >>>>
> >>>> I suggest pass down more informaiton, like client's dev point. So we can
> >>>> auto create device link between client's dev and dma chan's device.
> >>>
> >>> Is .of_dma_xlate() really the right place to do that ? If you want to
> >>> create a device link for PM reasons, isn't it better created when the
> >>> channel is requested ? It should also be removed when the channel is
> >>> freed.
> >>
> >> I remember just need record client device pointer here.
> >>
> >>>>
> >>>> DMA Engineer device
> >>>>    DMA chan device
> >>>>        consumer clients' device.
> >>>>
> >>>> If consumer device runtime pm suspend can auto trigger DMA chan's device's
> >>>> runtime pm function.
> >>>>
> >>>> It will simplifly DMA engine's run time pm manage. Currently many DMA run
> >>>> time pm implement as, runtime_pm_get() when alloc and runtime_pm_put() at
> >>>> free channel.  But many devices request dma channel at probe, which make
> >>>> dma engine work at always 'on' state.
> >>>>
> >>>> But ideally, dma chan should be resume only when it is used to transfer.
> >>>
> >>> This is exactly what I was going to mention after reading the last
> >>> paragraph. Is there anything that prevents a DMA engine driver to
> >>> perform a rutime PM get() when a transfer is submitted
> >>
> >> DMA description is a queue, It is hard to track each descriptor submit and
> >> finished. espcially cycle buffer case.
> >>
> >> And according to dma engine API defination, submit a descriptor not
> >> neccessary to turn on clock, maybe just pure software operation, such as
> >> enqueue it to a software list.
> >>
> >> Many driver call dmaengine_submit() in irq context,  submit new descriptor
> >> when previous descriptor finished. runtime_pm_get() can NOT be called in
> >> atomic context.
> >>
> >> And some driver submit many descripor advance. Only issue_transfer() is
> >> actually trigger hardware to start transfer.
> >>
> >> Some client use cycle descripor, such audio devices.  Some audio devices
> >> have not free descriptor at their run time suspend function, just disable
> >> audio devices's clocks.  Audio devices run time suspend, which means no
> >> one use this dma channel, dma channel can auto suspend if built device link
> >> between audio device and dma chan devices.
> >>
> >> Some DMA client have not devices, such as memory to memory. for this kind
> >> case, it need keep chan always on.
> >>
> >> issue_transfer() can be call in atomic context. but trigger hardware transfer
> >> need clock and runtime_pm_get() can't be called in atomic context.
> >>
> >> Most case issue_transfer() is call in irq handle, which means device should
> >> already be in runtime resume statue.  DMA engine can safely access their
> >> register if using device link.
> > 
> > You have good points there, in particular the fact the issue_transfer()
> > can be called in interrupt context.
> > 
> > For me this calls for new DMA engine operations to "start/stop" the DMA
> > engine (better names are likely needed) from a client perspective.
> > 
> >>> and a put() when
> >>> it completes ? (Logically speaking, the actual implementation would
> >>> likely be a bit different in drivers, but the result would be similar.)
> 
> So.. do you folks want me to alter the patch in any way?

I think the runtime PM issue is orthogonal to the problem this series
addresses. It can be addressed separately.

That being said, I'm not a big fan of passing a void pointer to
.of_xlate() to carry device-specific information, in a device-specific
format. This seems prone to mismatch between clients and DMA engines.
.of_xlate() also seems the wrong place to do this. It would be cleaner
if we could use another operation, such as dmaengine_slave_config() for
instance.

-- 
Regards,

Laurent Pinchart

Re: [PATCH RFC 2/6] dmaengine: Make of_dma_request_slave_channel pass a cookie to of_xlate

[Konrad Dybcio]

On 8/5/25 1:51 AM, Laurent Pinchart wrote:
> On Sat, Aug 02, 2025 at 02:37:54PM +0200, Konrad Dybcio wrote:
>> On 8/1/25 2:00 PM, Laurent Pinchart wrote:
>>> On Wed, Jul 30, 2025 at 02:37:54PM -0400, Frank Li wrote:
>>>> On Wed, Jul 30, 2025 at 09:04:17PM +0300, Laurent Pinchart wrote:
>>>>> On Wed, Jul 30, 2025 at 12:39:43PM -0400, Frank Li wrote:
>>>>>> On Wed, Jul 30, 2025 at 11:33:29AM +0200, Konrad Dybcio wrote:
>>>>>>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>>>>>>
>>>>>>> The DMA subsystem attempts to make it theoretically possible to pair
>>>>>>> any DMA block with any user. While that's convenient from a
>>>>>>> codebase sanity perspective, some blocks are more intertwined.
>>>>>>>
>>>>>>> One such case is the Qualcomm GENI, where each wrapper contains a
>>>>>>> number of Serial Engine instances, each one of which can be programmed
>>>>>>> to support a different protocol (such as I2C, I3C, SPI, UART, etc.).
>>>>>>>
>>>>>>> The GPI DMA it's designed together with, needs to receive the ID of the
>>>>>>> protocol that's in use, to adjust its behavior accordingly. Currently,
>>>>>>> that's done through passing that ID through device tree, with each
>>>>>>> Serial Engine expressed NUM_PROTOCOL times, resulting in terrible
>>>>>>> dt-bindings that are full of useless copypasta.
>>>>>>>
>>>>>>> In a step to cut down on that, let the DMA user give the engine driver
>>>>>>> a hint at request time.
>>>>>>>
>>>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>>>>>> ---

[...]

>> So.. do you folks want me to alter the patch in any way?
> 
> I think the runtime PM issue is orthogonal to the problem this series
> addresses. It can be addressed separately.
> 
> That being said, I'm not a big fan of passing a void pointer to
> .of_xlate() to carry device-specific information, in a device-specific
> format. This seems prone to mismatch between clients and DMA engines.
> .of_xlate() also seems the wrong place to do this. It would be cleaner
> if we could use another operation, such as dmaengine_slave_config() for
> instance.

Right, I noticed that the drivers in question already apparently do the
very same thing (passing data through a voidptr), inside slave_config
(via the peripheral_config/_size fields)..
But that doesn't solve the issue this series is trying to tackle, since
every DMA consumer driver passes its own structure (or NULL).

My immediate idea is to add yet another field, but that's lame. The other
immediate idea would be to put an `u8 variant` at the start of all of 
these structs ("we have tagged enums at home"), but that's lame *and*
dangerous.

Ideas?

Konrad

[PATCH RFC 3/6] dmaengine: qcom: gpi: Accept protocol ID hints

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Client drivers may now pass hints to dmaengine drivers. GPI DMA's only
consumers (GENI SEs) need to pass a protocol (I2C, I3C, SPI, etc.) ID
to the DMA engine driver, for it to take different actions.

Currently, that's done through passing that ID through device tree,
with each Serial Engine expressed NUM_PROTOCOL times, resulting in
terrible dt-bindings that are full of useless copypasta.

To help get rid of that, accept the driver cookie instead, while
keeping backwards compatibility.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 drivers/dma/qcom/gpi.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 51d19494099dae09f4579ba8c3eddfa0487bf487..de9e564dc21b2230c9446dfb881135003721a750 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -17,6 +17,8 @@
 #include "../dmaengine.h"
 #include "../virt-dma.h"
 
+#include <linux/soc/qcom/geni-se.h>
+
 #define TRE_TYPE_DMA		0x10
 #define TRE_TYPE_IMMEDIATE_DMA	0x11
 #define TRE_TYPE_GO		0x20
@@ -2109,15 +2111,19 @@ static int gpi_find_avail_gpii(struct gpi_dev *gpi_dev, u32 seid)
 /* gpi_of_dma_xlate: open client requested channel */
 static struct dma_chan *gpi_of_dma_xlate(struct of_phandle_args *args,
 					 struct of_dma *of_dma,
-					 void *data)
+					 void *proto)
 {
 	struct gpi_dev *gpi_dev = (struct gpi_dev *)of_dma->of_dma_data;
 	u32 seid, chid;
 	int gpii;
 	struct gchan *gchan;
 
-	if (args->args_count < 3) {
-		dev_err(gpi_dev->dev, "gpii require minimum 2 args, client passed:%d args\n",
+	/* The protocol ID has been historically stored in the third cell */
+	if (!proto && args->args_count < 3)
+		return NULL;
+
+	if (args->args_count < 2) {
+		dev_err(gpi_dev->dev, "gpii requires minimum 2 args, client passed:%d args\n",
 			args->args_count);
 		return NULL;
 	}
@@ -2145,7 +2151,8 @@ static struct dma_chan *gpi_of_dma_xlate(struct of_phandle_args *args,
 	}
 
 	gchan->seid = seid;
-	gchan->protocol = args->args[2];
+	/* The protocol ID is in the teens range, simply ignore the higher bits */
+	gchan->protocol = (u32)((u64)proto);
 
 	return dma_get_slave_channel(&gchan->vc.chan);
 }

-- 
2.50.1

Re: [PATCH RFC 3/6] dmaengine: qcom: gpi: Accept protocol ID hints

[Geert Uytterhoeven]

Hi Konrad,

On Wed, 30 Jul 2025 at 11:35, Konrad Dybcio <konradybcio@kernel.org> wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Client drivers may now pass hints to dmaengine drivers. GPI DMA's only
> consumers (GENI SEs) need to pass a protocol (I2C, I3C, SPI, etc.) ID
> to the DMA engine driver, for it to take different actions.
>
> Currently, that's done through passing that ID through device tree,
> with each Serial Engine expressed NUM_PROTOCOL times, resulting in
> terrible dt-bindings that are full of useless copypasta.
>
> To help get rid of that, accept the driver cookie instead, while
> keeping backwards compatibility.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Thanks for your patch!

> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -2145,7 +2151,8 @@ static struct dma_chan *gpi_of_dma_xlate(struct of_phandle_args *args,
>         }
>
>         gchan->seid = seid;
> -       gchan->protocol = args->args[2];
> +       /* The protocol ID is in the teens range, simply ignore the higher bits */
> +       gchan->protocol = (u32)((u64)proto);

A single cast "(uintptr_t)" should be sufficient.
Casing the pointer to u64 on 32-bit may trigger:

    warning: cast from pointer to integer of different size
[-Wpointer-to-int-cast]

>
>         return dma_get_slave_channel(&gchan->vc.chan);
>  }

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH RFC 3/6] dmaengine: qcom: gpi: Accept protocol ID hints

[Konrad Dybcio]

On 7/30/25 1:32 PM, Geert Uytterhoeven wrote:
> Hi Konrad,
> 
> On Wed, 30 Jul 2025 at 11:35, Konrad Dybcio <konradybcio@kernel.org> wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> Client drivers may now pass hints to dmaengine drivers. GPI DMA's only
>> consumers (GENI SEs) need to pass a protocol (I2C, I3C, SPI, etc.) ID
>> to the DMA engine driver, for it to take different actions.
>>
>> Currently, that's done through passing that ID through device tree,
>> with each Serial Engine expressed NUM_PROTOCOL times, resulting in
>> terrible dt-bindings that are full of useless copypasta.
>>
>> To help get rid of that, accept the driver cookie instead, while
>> keeping backwards compatibility.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Thanks for your patch!
> 
>> --- a/drivers/dma/qcom/gpi.c
>> +++ b/drivers/dma/qcom/gpi.c
>> @@ -2145,7 +2151,8 @@ static struct dma_chan *gpi_of_dma_xlate(struct of_phandle_args *args,
>>         }
>>
>>         gchan->seid = seid;
>> -       gchan->protocol = args->args[2];
>> +       /* The protocol ID is in the teens range, simply ignore the higher bits */
>> +       gchan->protocol = (u32)((u64)proto);
> 
> A single cast "(uintptr_t)" should be sufficient.
> Casing the pointer to u64 on 32-bit may trigger:
> 
>     warning: cast from pointer to integer of different size
> [-Wpointer-to-int-cast]

Good point, not compiling for 32-bit always ends up biting.. thanks

Konrad

Re: [PATCH RFC 3/6] dmaengine: qcom: gpi: Accept protocol ID hints

[Andy Shevchenko]

On Wed, Jul 30, 2025 at 01:32:58PM +0200, Geert Uytterhoeven wrote:
> On Wed, 30 Jul 2025 at 11:35, Konrad Dybcio <konradybcio@kernel.org> wrote:

...

> > +       /* The protocol ID is in the teens range, simply ignore the higher bits */
> > +       gchan->protocol = (u32)((u64)proto);
> 
> A single cast "(uintptr_t)" should be sufficient.

FWIW, this means (unsigned long) as Torvalds is quite against uintptr_t in the kernel.

> Casing the pointer to u64 on 32-bit may trigger:
> 
>     warning: cast from pointer to integer of different size
> [-Wpointer-to-int-cast]
> 
> >         return dma_get_slave_channel(&gchan->vc.chan);
> >  }

-- 
With Best Regards,
Andy Shevchenko

[PATCH RFC 4/6] i2c: qcom-geni: Hint GENI protocol ID to GPI DMA

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

With the API in place, request the correct protocol ID with the GPI DMA
to avoid having to hardcode this obvious information in the device
tree.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 drivers/i2c/busses/i2c-qcom-geni.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index ff2289b52c84ccf9ef786c2618bd869453c5f611..4c702ee728d6cc9282688bc278bd401f3de3266a 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -754,14 +754,14 @@ static int setup_gpi_dma(struct geni_i2c_dev *gi2c)
 	int ret;
 
 	geni_se_select_mode(&gi2c->se, GENI_GPI_DMA);
-	gi2c->tx_c = dma_request_chan(gi2c->se.dev, "tx");
+	gi2c->tx_c = dma_request_chan_w_data(gi2c->se.dev, "tx", (void *)GENI_SE_I2C);
 	if (IS_ERR(gi2c->tx_c)) {
 		ret = dev_err_probe(gi2c->se.dev, PTR_ERR(gi2c->tx_c),
 				    "Failed to get tx DMA ch\n");
 		goto err_tx;
 	}
 
-	gi2c->rx_c = dma_request_chan(gi2c->se.dev, "rx");
+	gi2c->rx_c = dma_request_chan_w_data(gi2c->se.dev, "rx", (void *)GENI_SE_I2C);
 	if (IS_ERR(gi2c->rx_c)) {
 		ret = dev_err_probe(gi2c->se.dev, PTR_ERR(gi2c->rx_c),
 				    "Failed to get rx DMA ch\n");

-- 
2.50.1

[PATCH RFC 5/6] spi: geni-qcom: Hint GENI protocol ID to GPI DMA

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

With the API in place, request the correct protocol ID with the GPI DMA
to avoid having to hardcode this obvious information in the device
tree.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 drivers/spi/spi-geni-qcom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c
index 768d7482102adec9b7178077724dc3976a2760c8..0ea157ac06e12012e1a36218bf3a4058a9db6048 100644
--- a/drivers/spi/spi-geni-qcom.c
+++ b/drivers/spi/spi-geni-qcom.c
@@ -623,14 +623,14 @@ static int spi_geni_grab_gpi_chan(struct spi_geni_master *mas)
 {
 	int ret;
 
-	mas->tx = dma_request_chan(mas->dev, "tx");
+	mas->tx = dma_request_chan_w_data(mas->dev, "tx", (void *)GENI_SE_SPI);
 	if (IS_ERR(mas->tx)) {
 		ret = dev_err_probe(mas->dev, PTR_ERR(mas->tx),
 				    "Failed to get tx DMA ch\n");
 		goto err_tx;
 	}
 
-	mas->rx = dma_request_chan(mas->dev, "rx");
+	mas->rx = dma_request_chan_w_data(mas->dev, "rx", (void *)GENI_SE_SPI);
 	if (IS_ERR(mas->rx)) {
 		ret = dev_err_probe(mas->dev, PTR_ERR(mas->rx),
 				    "Failed to get rx DMA ch\n");

-- 
2.50.1

Re: [PATCH RFC 5/6] spi: geni-qcom: Hint GENI protocol ID to GPI DMA

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

On Wed, Jul 30, 2025 at 11:33:32AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> With the API in place, request the correct protocol ID with the GPI DMA
> to avoid having to hardcode this obvious information in the device
> tree.

Acked-by: Mark Brown <broonie@kernel.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH RFC 6/6] arm64: dts: qcom: x1e80100: Remove GENI protocol ID from DMA cells

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

In preparation for coalescing the duplicate nodes referring to the same
GENI serial engines running different protocol firmware, remove the no
longer necessary protocol IDs from each of the GPI DMA consumers.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 198 ++++++++++++++++-----------------
 1 file changed, 99 insertions(+), 99 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 5e9a8fa3cf96468b12775f91192cbd779d5ce946..0dc055c9660501f3e5e3ba87e1560125eba67730 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -844,7 +844,7 @@ gpi_dma2: dma-controller@800000 {
 
 			dma-channels = <12>;
 			dma-channel-mask = <0x3e>;
-			#dma-cells = <3>;
+			#dma-cells = <2>;
 
 			iommus = <&apps_smmu 0x436 0x0>;
 
@@ -890,8 +890,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma2 0 0 QCOM_GPI_I2C>,
-				       <&gpi_dma2 1 0 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma2 0 0>,
+				       <&gpi_dma2 1 0>;
 				dma-names = "tx",
 					    "rx";
 
@@ -926,8 +926,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_120mhz>;
 
-				dmas = <&gpi_dma2 0 0 QCOM_GPI_SPI>,
-				       <&gpi_dma2 1 0 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma2 0 0>,
+				       <&gpi_dma2 1 0>;
 				dma-names = "tx",
 					    "rx";
 
@@ -962,8 +962,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma2 0 1 QCOM_GPI_I2C>,
-				       <&gpi_dma2 1 1 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma2 0 1>,
+				       <&gpi_dma2 1 1>;
 				dma-names = "tx",
 					    "rx";
 
@@ -998,8 +998,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_120mhz>;
 
-				dmas = <&gpi_dma2 0 1 QCOM_GPI_SPI>,
-				       <&gpi_dma2 1 1 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma2 0 1>,
+				       <&gpi_dma2 1 1>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1034,8 +1034,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma2 0 2 QCOM_GPI_I2C>,
-				       <&gpi_dma2 1 2 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma2 0 2>,
+				       <&gpi_dma2 1 2>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1070,8 +1070,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma2 0 2 QCOM_GPI_SPI>,
-				       <&gpi_dma2 1 2 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma2 0 2>,
+				       <&gpi_dma2 1 2>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1106,8 +1106,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma2 0 3 QCOM_GPI_I2C>,
-				       <&gpi_dma2 1 3 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma2 0 3>,
+				       <&gpi_dma2 1 3>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1142,8 +1142,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma2 0 3 QCOM_GPI_SPI>,
-				       <&gpi_dma2 1 3 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma2 0 3>,
+				       <&gpi_dma2 1 3>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1178,8 +1178,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma2 0 4 QCOM_GPI_I2C>,
-				       <&gpi_dma2 1 4 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma2 0 4>,
+				       <&gpi_dma2 1 4>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1214,8 +1214,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma2 0 4 QCOM_GPI_SPI>,
-				       <&gpi_dma2 1 4 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma2 0 4>,
+				       <&gpi_dma2 1 4>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1250,8 +1250,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma2 0 5 QCOM_GPI_I2C>,
-				       <&gpi_dma2 1 5 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma2 0 5>,
+				       <&gpi_dma2 1 5>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1286,8 +1286,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma2 0 5 QCOM_GPI_SPI>,
-				       <&gpi_dma2 1 5 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma2 0 5>,
+				       <&gpi_dma2 1 5>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1347,8 +1347,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma2 0 6 QCOM_GPI_I2C>,
-				       <&gpi_dma2 1 6 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma2 0 6>,
+				       <&gpi_dma2 1 6>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1383,8 +1383,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma2 0 6 QCOM_GPI_SPI>,
-				       <&gpi_dma2 1 6 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma2 0 6>,
+				       <&gpi_dma2 1 6>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1419,8 +1419,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma2 0 7 QCOM_GPI_I2C>,
-				       <&gpi_dma2 1 7 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma2 0 7>,
+				       <&gpi_dma2 1 7>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1455,8 +1455,8 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma2 0 7 QCOM_GPI_SPI>,
-				       <&gpi_dma2 1 7 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma2 0 7>,
+				       <&gpi_dma2 1 7>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1489,7 +1489,7 @@ gpi_dma1: dma-controller@a00000 {
 
 			dma-channels = <12>;
 			dma-channel-mask = <0x3e>;
-			#dma-cells = <3>;
+			#dma-cells = <2>;
 
 			iommus = <&apps_smmu 0x136 0x0>;
 
@@ -1535,8 +1535,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma1 0 0 QCOM_GPI_I2C>,
-				       <&gpi_dma1 1 0 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma1 0 0>,
+				       <&gpi_dma1 1 0>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1571,8 +1571,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_120mhz>;
 
-				dmas = <&gpi_dma1 0 0 QCOM_GPI_SPI>,
-				       <&gpi_dma1 1 0 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma1 0 0>,
+				       <&gpi_dma1 1 0>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1607,8 +1607,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma1 0 1 QCOM_GPI_I2C>,
-				       <&gpi_dma1 1 1 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma1 0 1>,
+				       <&gpi_dma1 1 1>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1643,8 +1643,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_120mhz>;
 
-				dmas = <&gpi_dma1 0 1 QCOM_GPI_SPI>,
-				       <&gpi_dma1 1 1 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma1 0 1>,
+				       <&gpi_dma1 1 1>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1679,8 +1679,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma1 0 2 QCOM_GPI_I2C>,
-				       <&gpi_dma1 1 2 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma1 0 2>,
+				       <&gpi_dma1 1 2>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1715,8 +1715,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma1 0 2 QCOM_GPI_SPI>,
-				       <&gpi_dma1 1 2 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma1 0 2>,
+				       <&gpi_dma1 1 2>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1751,8 +1751,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma1 0 3 QCOM_GPI_I2C>,
-				       <&gpi_dma1 1 3 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma1 0 3>,
+				       <&gpi_dma1 1 3>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1787,8 +1787,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma1 0 3 QCOM_GPI_SPI>,
-				       <&gpi_dma1 1 3 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma1 0 3>,
+				       <&gpi_dma1 1 3>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1823,8 +1823,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma1 0 4 QCOM_GPI_I2C>,
-				       <&gpi_dma1 1 4 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma1 0 4>,
+				       <&gpi_dma1 1 4>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1859,8 +1859,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma1 0 4 QCOM_GPI_SPI>,
-				       <&gpi_dma1 1 4 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma1 0 4>,
+				       <&gpi_dma1 1 4>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1895,8 +1895,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma1 0 5 QCOM_GPI_I2C>,
-				       <&gpi_dma1 1 5 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma1 0 5>,
+				       <&gpi_dma1 1 5>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1931,8 +1931,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma1 0 5 QCOM_GPI_SPI>,
-				       <&gpi_dma1 1 5 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma1 0 5>,
+				       <&gpi_dma1 1 5>;
 				dma-names = "tx",
 					    "rx";
 
@@ -1967,8 +1967,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma1 0 6 QCOM_GPI_I2C>,
-				       <&gpi_dma1 1 6 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma1 0 6>,
+				       <&gpi_dma1 1 6>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2003,8 +2003,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma1 0 6 QCOM_GPI_SPI>,
-				       <&gpi_dma1 1 6 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma1 0 6>,
+				       <&gpi_dma1 1 6>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2064,8 +2064,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma1 0 7 QCOM_GPI_I2C>,
-				       <&gpi_dma1 1 7 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma1 0 7>,
+				       <&gpi_dma1 1 7>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2100,8 +2100,8 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma1 0 7 QCOM_GPI_SPI>,
-				       <&gpi_dma1 1 7 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma1 0 7>,
+				       <&gpi_dma1 1 7>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2134,7 +2134,7 @@ gpi_dma0: dma-controller@b00000  {
 
 			dma-channels = <12>;
 			dma-channel-mask = <0x3e>;
-			#dma-cells = <3>;
+			#dma-cells = <2>;
 
 			iommus = <&apps_smmu 0x456 0x0>;
 
@@ -2179,8 +2179,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma0 0 0 QCOM_GPI_I2C>,
-				       <&gpi_dma0 1 0 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma0 0 0>,
+				       <&gpi_dma0 1 0>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2215,8 +2215,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_120mhz>;
 
-				dmas = <&gpi_dma0 0 0 QCOM_GPI_SPI>,
-				       <&gpi_dma0 1 0 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma0 0 0>,
+				       <&gpi_dma0 1 0>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2251,8 +2251,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma0 0 1 QCOM_GPI_I2C>,
-				       <&gpi_dma0 1 1 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma0 0 1>,
+				       <&gpi_dma0 1 1>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2287,8 +2287,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_120mhz>;
 
-				dmas = <&gpi_dma0 0 1 QCOM_GPI_SPI>,
-				       <&gpi_dma0 1 1 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma0 0 1>,
+				       <&gpi_dma0 1 1>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2323,8 +2323,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma0 0 2 QCOM_GPI_I2C>,
-				       <&gpi_dma0 1 2 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma0 0 2>,
+				       <&gpi_dma0 1 2>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2384,8 +2384,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma0 0 2 QCOM_GPI_SPI>,
-				       <&gpi_dma0 1 2 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma0 0 2>,
+				       <&gpi_dma0 1 2>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2420,8 +2420,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma0 0 3 QCOM_GPI_I2C>,
-				       <&gpi_dma0 1 3 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma0 0 3>,
+				       <&gpi_dma0 1 3>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2456,8 +2456,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma0 0 3 QCOM_GPI_SPI>,
-				       <&gpi_dma0 1 3 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma0 0 3>,
+				       <&gpi_dma0 1 3>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2492,8 +2492,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma0 0 4 QCOM_GPI_I2C>,
-				       <&gpi_dma0 1 4 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma0 0 4>,
+				       <&gpi_dma0 1 4>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2528,8 +2528,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma0 0 4 QCOM_GPI_SPI>,
-				       <&gpi_dma0 1 4 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma0 0 4>,
+				       <&gpi_dma0 1 4>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2564,8 +2564,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma0 0 5 QCOM_GPI_I2C>,
-				       <&gpi_dma0 1 5 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma0 0 5>,
+				       <&gpi_dma0 1 5>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2600,8 +2600,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma0 0 5 QCOM_GPI_SPI>,
-				       <&gpi_dma0 1 5 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma0 0 5>,
+				       <&gpi_dma0 1 5>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2636,8 +2636,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma0 0 6 QCOM_GPI_I2C>,
-				       <&gpi_dma0 1 6 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma0 0 6>,
+				       <&gpi_dma0 1 6>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2672,8 +2672,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma0 0 6 QCOM_GPI_SPI>,
-				       <&gpi_dma0 1 6 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma0 0 6>,
+				       <&gpi_dma0 1 6>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2708,8 +2708,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				required-opps = <&rpmhpd_opp_low_svs>;
 
-				dmas = <&gpi_dma0 0 7 QCOM_GPI_I2C>,
-				       <&gpi_dma0 1 7 QCOM_GPI_I2C>;
+				dmas = <&gpi_dma0 0 7>,
+				       <&gpi_dma0 1 7>;
 				dma-names = "tx",
 					    "rx";
 
@@ -2744,8 +2744,8 @@ &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ACTIVE_ONLY>,
 				power-domains = <&rpmhpd RPMHPD_CX>;
 				operating-points-v2 = <&qup_opp_table_100mhz>;
 
-				dmas = <&gpi_dma0 0 7 QCOM_GPI_SPI>,
-				       <&gpi_dma0 1 7 QCOM_GPI_SPI>;
+				dmas = <&gpi_dma0 0 7>,
+				       <&gpi_dma0 1 7>;
 				dma-names = "tx",
 					    "rx";
 

-- 
2.50.1