From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A65E72BD5B5; Thu, 24 Jul 2025 11:52:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753357968; cv=none; b=pfDf6WePQgcA82JtYgasubleLI3NyvKc5MGH253/O6ZyS4x8mnKy81iCtGrOZ2Oz+oLUB1aal25wkv5jHEq31+iP1CisYvfgymUXf3h1LAw9tfI0eE3NVWSxg9dAR3TeksQuw93Ueq46Tm6VNPas9wMkle1PUPWaJ35WSd7W9zM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753357968; c=relaxed/simple; bh=skduPBA0XOiRRFwQNtjlPasZ0GUfqz6drj8febfSOhY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kla6PgZuAqxM7OdewCFjajlpdjvaKZnUIYcHC+39UAzZmZRAaYp0oUW8bNkeVGOUOqpgd7swmPDAWL9Oed7JluVS55y0QRmELwEP3/yu9aXEMQa76ogOm01dvkFKp1mfXI9aq9kny3d6hC/8LEGLBxxefZzw9ts1ekm1HEdwMew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LB7bc/Hb; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LB7bc/Hb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753357967; x=1784893967; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=skduPBA0XOiRRFwQNtjlPasZ0GUfqz6drj8febfSOhY=; b=LB7bc/Hbo81gIBp8JKhBQ6KMocGkhnEEyEr21+TdL8b27T1zyZrqeOuo y/vvK5nTt2HsMXCq85We0HTQB3P/P0hJWrXEB241r+8neVIMaHPxP710K pn6Tkwm14hnBJsSyS/hNU+qDLnmM549B7/ZbdhREuO1kz5G6wVUlm1lUV myh0h9IhIQ6bXFpzCyJ20isX/aiWcl9JuO1bIeg1qSMynOSzF8RYsFZgy cBYAu3N6CRO+DLORslJBoqoDITmz7KEAO8ROJkKAlt2ZgSUzxsW0tweAA 2nmAsvI9SjaJxrEsNd1nBOUEqSZfPOM7TscElfUGplh/j78J/vYyNtfOE g==; X-CSE-ConnectionGUID: pgf3WXWBSayHguckRosE8g== X-CSE-MsgGUID: aM42GNHIRwC6Ju/0gK6tOA== X-IronPort-AV: E=McAfee;i="6800,10657,11501"; a="59473460" X-IronPort-AV: E=Sophos;i="6.16,337,1744095600"; d="scan'208";a="59473460" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2025 04:52:46 -0700 X-CSE-ConnectionGUID: gH3texk5RoaLOe2vbIi/aw== X-CSE-MsgGUID: lF7KjgBaRhmOljQc+wknEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,337,1744095600"; d="scan'208";a="164253907" Received: from smile.fi.intel.com ([10.237.72.52]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2025 04:52:36 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1ueuUx-00000000Yl0-3pfo; Thu, 24 Jul 2025 14:52:31 +0300 Date: Thu, 24 Jul 2025 14:52:31 +0300 From: Andy Shevchenko To: Lorenzo Stoakes Cc: Andy Shevchenko , Bartosz Golaszewski , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Alexey Klimov , Lorenzo Bianconi , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Paul Cercueil , Kees Cook , Andy Shevchenko , Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , NXP S32 Linux Team , Sascha Hauer , Tony Lindgren , Haojian Zhuang , Geert Uytterhoeven , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v3 01/15] lib: provide kmemdup_const() Message-ID: References: <20250724-pinctrl-gpio-pinfuncs-v3-0-af4db9302de4@linaro.org> <20250724-pinctrl-gpio-pinfuncs-v3-1-af4db9302de4@linaro.org> <5c7edf57-bf13-4633-8348-791e0620cc79@lucifer.local> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5c7edf57-bf13-4633-8348-791e0620cc79@lucifer.local> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Jul 24, 2025 at 12:15:11PM +0100, Lorenzo Stoakes wrote: > On Thu, Jul 24, 2025 at 01:12:49PM +0200, Andy Shevchenko wrote: > > On Thu, Jul 24, 2025 at 1:10 PM Lorenzo Stoakes > > wrote: > > > On Thu, Jul 24, 2025 at 11:24:29AM +0200, Bartosz Golaszewski wrote: > > > > +extern const void *kmemdup_const(const void *src, size_t len, gfp_t gfp); > > > > > > Please drop extern, it's unnecessary. > > > > It's all over the header. This should be done as a precursor patch and > > I know that usually people push back on doing that. I gave up on this. > > Kernel is going to rot sooner or later... :-( > > In mm we just update as we go, this is probably the best approach to avoid > unnecessary churn. I agree on the idea of eliminating it, but also I agree on the consistency over redundancy. That's why I prefer to see this done at once for all (in the same header) than doing one-by-one. And this approach got a lot of pushes back, while the former even more pushed back on the (in)consistency matters. -- With Best Regards, Andy Shevchenko