* [PATCH] i3c: renesas: Simplify return statement in 'renesas_i3c_daa'
@ 2025-08-03 21:12 Wolfram Sang
2025-08-04 8:57 ` Tommaso Merciai
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2025-08-03 21:12 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Dan Carpenter, Tommaso Merciai, Alexandre Belloni,
Frank Li, linux-i3c
There was already a bail out for 'ret < 0', so we can always return
success at the end of the function.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/aIyzJ7HOENL1qp1l@stanley.mountain
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i3c/master/renesas-i3c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
index 174d3dc5d276..275f7b924288 100644
--- a/drivers/i3c/master/renesas-i3c.c
+++ b/drivers/i3c/master/renesas-i3c.c
@@ -679,7 +679,7 @@ static int renesas_i3c_daa(struct i3c_master_controller *m)
i3c_master_add_i3c_dev_locked(m, i3c->addrs[pos]);
}
- return ret < 0 ? ret : 0;
+ return 0;
}
static bool renesas_i3c_supports_ccc_cmd(struct i3c_master_controller *m,
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i3c: renesas: Simplify return statement in 'renesas_i3c_daa'
2025-08-03 21:12 [PATCH] i3c: renesas: Simplify return statement in 'renesas_i3c_daa' Wolfram Sang
@ 2025-08-04 8:57 ` Tommaso Merciai
0 siblings, 0 replies; 2+ messages in thread
From: Tommaso Merciai @ 2025-08-04 8:57 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Dan Carpenter, Alexandre Belloni, Frank Li,
linux-i3c
Hi Wolfram,
Thanks for your patch!
On Sun, Aug 03, 2025 at 11:12:57PM +0200, Wolfram Sang wrote:
> There was already a bail out for 'ret < 0', so we can always return
> success at the end of the function.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/aIyzJ7HOENL1qp1l@stanley.mountain
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
> drivers/i3c/master/renesas-i3c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
> index 174d3dc5d276..275f7b924288 100644
> --- a/drivers/i3c/master/renesas-i3c.c
> +++ b/drivers/i3c/master/renesas-i3c.c
> @@ -679,7 +679,7 @@ static int renesas_i3c_daa(struct i3c_master_controller *m)
> i3c_master_add_i3c_dev_locked(m, i3c->addrs[pos]);
> }
>
> - return ret < 0 ? ret : 0;
> + return 0;
> }
>
> static bool renesas_i3c_supports_ccc_cmd(struct i3c_master_controller *m,
> --
> 2.47.2
>
>
Thanks & Regards,
Tommaso
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-04 8:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-03 21:12 [PATCH] i3c: renesas: Simplify return statement in 'renesas_i3c_daa' Wolfram Sang
2025-08-04 8:57 ` Tommaso Merciai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).