Re: [PATCH v4 7/8] soc: renesas: Add support for Renesas RZ/N1 GPIO Interrupt Multiplexer

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Hi Herve,

On Mon, Sep 22, 2025 at 05:26:38PM +0200, Herve Codina (Schneider Electric) wrote:
> On the Renesas RZ/N1 SoC, GPIOs can generate interruptions. Those
> interruption lines are multiplexed by the GPIO Interrupt Multiplexer in
> order to map 32 * 3 GPIO interrupt lines to 8 GIC interrupt lines.
> 
> The GPIO interrupt multiplexer IP does nothing but select 8 GPIO
> IRQ lines out of the 96 available to wire them to the GIC input lines.
> 
> Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@bootlin.com>

Thanks for improving the driver and removing the requirement of a fixed
ordering!

> +static u32 rzn1_irqmux_output_lines[] = {

const?

> +	103, 104, 105, 106, 107, 108, 109, 110
> +};

...

> +	for (i = 0; i < ARRAY_SIZE(rzn1_irqmux_output_lines); i++) {
> +		if (parent_args->args[1] == rzn1_irqmux_output_lines[i])
> +			return i;
> +	}

Do we want a check here if the index has already been used in cases of
an improper 'interrupt-map'? I'd think it would be nice to have but I
would also not really require it.

...

> +	ret = rzn1_irqmux_setup(dev, np, regs);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "failed to setup mux\n");
> +
> +	return 0;

Maybe just

	return rzn1_irqmux_setup(dev, np, regs);

The driver core will report a failed probe already.

It still works, so:

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]