Re: Sashiko review feedback (was Re: [PATCH 2/3] soc: renesas: Add Renesas R-Car MFIS driver)

Wolfram Sang
2026-03-31T07:18:09Z

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

Hi Ted,

> I was thinking about proposing some tagging convention such as:
>
> Suggested-by: Sashiko:Gemini 3.1 Pro
> or
> Reviewed-by: Sashiko:Gemini 3.1 Pro
>
> to Documentation/process/coding-assistants.rst. Alas, neither is
> perfect.

Yes, maybe an email is not so much needed and the information about
Sashiko and Gemini is much more relevant.

> Suggested-by: is generlly used when someone inspires a particular
> commit. This might apply if Sashiko found a problem as an incidental
> finding, which we then fixed in a subsequent commit. An example of
> this might be[1], or in the case which you suggested above. But what

What about Reported-by? The required closes by would then link to the
actual report:

Reported-by: Sashiko:Gemini 3.1 Pro
Closes: https://sashiko.dev/#/patchset/20260319105947.6237-1-wsa%2Brenesas%40sang-engineering.com

The drawback currently is that only the whole report for the patchset
can be linked. But probably Sashiko-reports could have some more HTML
tags to reference only the paragraph needed.

Happy hacking,

Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]