From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3F19B429014 for ; Fri, 21 Aug 2026 11:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787311615; cv=none; b=t7Xq3OT9cSHkTZc3jdW06YqRfkjzMibI1DOpNeQbYKD4d1oXabkziXjr9ZK1CokvnbgQJBU8rWT6XyV7tRG8UebKPo3Dk905H1tG+EVi/ha4f45sewqrZ6Ri0eYjd64rYhydtEFI8F8Ck0/U19INB8CkJnjSM/LXlzwNYe2Q4io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787311615; c=relaxed/simple; bh=qAWvudYMdASPXPfSTaqms42rgycSdo6rtQ42Q6DlQlc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lPHjjYT9FJapXIl+VXLXywgaiENWPgFjxRuiwb1ztmMY8ZWYYdyK2HzQQs4Hpj34IGBVUxaH1ENAxin6QQMbyVe+H7DK97BJ8KVYv5ppjdS8/apc7H3wBK7Rd7PpAOeQHMWDJkOLjltU2BGMd4iyU5QAoICWJsfNqJDU/jh8hk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=DXfBaBze; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="DXfBaBze" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 703F822D9 for ; Fri, 21 Aug 2026 04:26:47 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 139343F763 for ; Fri, 21 Aug 2026 04:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1787311611; bh=qAWvudYMdASPXPfSTaqms42rgycSdo6rtQ42Q6DlQlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DXfBaBzeWmrq0aj+CPRsgfs/yoiUPB4qNVwv7pyFwF2y2LlptKPjSgHcnb/PVZI5i avRO7zGtBvK5bF0yjBqxWdrfAt+LqMc4ROZzJdDuNHRVS99nQwfsOFZDF2lCdT5fYH JtyhBC0h9CSq9Z+OMGp2d62n+9+UOyjb3n5K3/fw= Date: Fri, 21 Aug 2026 12:25:30 +0100 From: Liviu Dudau To: Geert Uytterhoeven Cc: Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?utf-8?B?TMOzcGV6?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 05/45] clk: cdce925: Make sure clk_init_data is fully initialized Message-ID: References: <308a33a0e63241d94ee08a08a6de6cffa739556e.1787239813.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <308a33a0e63241d94ee08a08a6de6cffa739556e.1787239813.git.geert+renesas@glider.be> On Fri, Aug 21, 2026 at 10:53:15AM +0200, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Liviu Dudau Best regards, Liviu > --- > Compile-tested only. > --- > drivers/clk/clk-cdce925.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c > index 30d0493c771818ff..4d49cc1659c07be2 100644 > --- a/drivers/clk/clk-cdce925.c > +++ b/drivers/clk/clk-cdce925.c > @@ -620,7 +620,7 @@ static int cdce925_probe(struct i2c_client *client) > struct device_node *node = client->dev.of_node; > const char *parent_name; > const char *pll_clk_name[MAX_NUMBER_OF_PLLS] = {NULL,}; > - struct clk_init_data init; > + struct clk_init_data init = {}; > u32 value; > int i; > int err; > -- > 2.43.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯