From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DDEF423E87 for ; Mon, 24 Aug 2026 13:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787577410; cv=none; b=ICHdE12x03jAOCIoB2sVQQ0EcKtZFaj8ViAeqWCyXGZDjRMc8jaAKuhO4eaRzPeU1vpLviRzhX0NZB4Cdg3EnPYT+8D4EElLR2at6QkDMTpVVoDQJLQ6NtXQ/WIvgfReEq9sj8GT2LIGys0hj4WafIUx+M6mKbg/OWgfsUbo6NE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787577410; c=relaxed/simple; bh=u69iDQDh65gTSQHaopk712AakCgClJSI2Zoo/JrTLeU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NFAvg87u/yL0km0ZwjPCf81Di1Dn8w7+r6iX8/zoj7tn/6qWG1v9p4fmpoV2AcDhzzElu/ca1xgWlV5/U8JsEr2xcK9CpZkjA51l2QOfkLTQLGP8dKl83aMz6cq9TZfrF0SXKRLZ/M8BOn830vD5siKEpIiSF5hgOi3ynkLpz0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f9i6g8WY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nDRNjzCs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f9i6g8WY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nDRNjzCs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787577407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=f9i6g8WYKFlUJLESA7Ct2vPrwX534hsFqsSBjvPPxcuB7DDlvnlwzK9lle6Fu0E8t2vDX+ wtwYCioYofana1LZCBhahff5vfVt0uo/kNMDUO6yD66sbnFUIF40RuNY34sR5K5nKHYhd4 9rQGOLnQlXRWth7paertuCsmzIOI2xE= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-FV1w0kBoOMe5mC2xF_Y22g-1; Mon, 24 Aug 2026 09:16:44 -0400 X-MC-Unique: FV1w0kBoOMe5mC2xF_Y22g-1 X-Mimecast-MFC-AGG-ID: FV1w0kBoOMe5mC2xF_Y22g_1787577403 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-836c9f68dcbso59404447b3.0 for ; Mon, 24 Aug 2026 06:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787577403; x=1788182203; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=nDRNjzCsNeafHgg4aSqZ9DFAxbEbEAmNgVuoOKhKxlM0EV4gIIhIBciaWWiUM5a58i hWBhLd8Fr/DCaXnbI3GgkY67wxWVfHyI8wz8rUB9WYMcMqHfZT2PLK3Az4YxWunC1p+K jzVurhIatDSxYDhRp8ExsURushVWlP2RfJb+TPP/w3DpH8BYw+4bGJ5ulIbQi+1cuMjP /HYXPo/QkSou00keMR1jOhHTQYisB142KFZ1yKhjuGZYcjHBzMRLyHaGlBz8hpK9nWL6 qGj/dLHYL6+xPF55vde8lOj53kBgKgAbWzbSKjIazgpWLlQPjmQy4zL6OmThnCj7xnKo na6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787577403; x=1788182203; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a5uoZNVB2XRKnrTBdvCmJrG8M4XSoSEJo8KaXU4b4e8=; b=F1moL/DX7/p89UfdCEwkItfbHxJOLWNNfstQcRoVC76Xo1EKTwQj9Qv5v/auaJ0Ko7 uaei0ZNE6BsSmI4Y7l0tcx9Vy9nTNCovAiIPqPKrRgfBGFZ+azO2ROkWYaA/cGCFHnJa 1xihk15vFrXAPASNGJmfBshXlEeMH/tJOlUIyFz+80B6f7IUerogKf1bjQTcRzpvuVdY cp2IFNGJH6mL8U8nUhGjWCppuSpmBGZxlkWpL3LArVQYK+JyRu+scCljiusR87incXIl mbDe7UE+WDx1esvE/1gHakEKFGICiu/CbtPKZ3Meu663F+eASIhcOD5RDq8I4vxobihM MLLg== X-Forwarded-Encrypted: i=1; AHgh+RqMHL5bwkWUKJnnr4NKUEgoeg0ZAb1fjAxkKVRfs/Im1ZjltZnMO23dImHLJOhvfDYOchHiMK6wuJcdmWcj1daJQA==@vger.kernel.org X-Gm-Message-State: AFuF++nAgnAfdn7YPmA3xnEwO0LpMGmtK32g9D/8QazaQtyOSvZ3AvXN hU20iX650IGzgBJ/sSNe7LuFuCCzTHfV2M01Lo4LrPPdjDy+e3VKGA1EUvP2MZ6HsZ62h3VTBNt C1dO4f2kOQ/+MhwEjIZjY8X6VZAfRU244Rzm9RgVBbGnpAQGw4rfCmCNWzpq+Vc7uQ32vsebd X-Gm-Gg: AR+sD135iis5kCaJVGLeq/lv2A8GEsoIu4eqbySla5vX8NcS1P/MLeHJgiVvAK8ValG SUvOxNGw0/NoXpvlAksiosZgPEoY+vMo73cN3V2NQ3UIQyPQ2i/BqW+5M0MM+U3ocohYPZwUzdk s8fE7WYWpc/idVL9zoXuXYuYNkayqDiYVc6JCHYbT2W4x3zNBnp4UMBbcbW1B6PVYHNHTYlNYbJ ofClwmB3jzTRfezZgXZM/USbHtUqSldePbb+G1ZltXEIPvGRAKKEZcdx4lQM7lQ1Xhxiy+58U4I lrsqlrk+nC5lFBVcJ8WG6VK5xgD5rNdTl0iI20lzbpaQa3Dt0rpo+ReMD+G3SQKqLq86oHGMPC/ nGK4T1MgpIrkxd9bQLGPhie+YAeFYH5gXPC4= X-Received: by 2002:a05:690c:e0c1:10b0:81e:a4cf:131b with SMTP id 00721157ae682-849f4a7cc91mr76172757b3.22.1787577403083; Mon, 24 Aug 2026 06:16:43 -0700 (PDT) X-Received: by 2002:a05:690c:e0c1:10b0:81e:a4cf:131b with SMTP id 00721157ae682-849f4a7cc91mr76172227b3.22.1787577402495; Mon, 24 Aug 2026 06:16:42 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84ca5d254adsm33243617b3.16.2026.08.24.06.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 06:16:41 -0700 (PDT) Date: Mon, 24 Aug 2026 09:16:34 -0400 From: Brian Masney To: Krzysztof Kozlowski Cc: Geert Uytterhoeven , Ryan Chen , Joel Stanley , Stephen Boyd , Brian Masney , Jerome Brunet , Andrew Jeffery , Billy Tsai , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Taichi Sugaya , Takao Orito , Linus Walleij , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Sudeep Holla , Cristian Marussi , David Lechner , Abel Vesa , Peng Fan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Santosh Shilimkar , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Zapolskiy , Heiko Stuebner , Sylwester Nawrocki , Chanwoo Choi , Peter Griffin , Alim Akhtar , Dinh Nguyen , Viresh Kumar , Maxime Coquelin , Alexandre Torgue , Emilio =?iso-8859-1?Q?L=F3pez?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Ulf Hansson , Liviu Dudau , Lorenzo Pieralisi , Michal Simek , Matthias Brugger , linux-clk@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, arm-scmi@vger.kernel.org, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 29/45] clk: samsung: Make sure clk_init_data is fully initialized Message-ID: References: <87b3e83137e1a987f3c69d214706e93ef3898cab.1787239813.git.geert+renesas@glider.be> <60a8d05a-76fa-43c3-a0f7-fb26a3b659b8@kernel.org> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60a8d05a-76fa-43c3-a0f7-fb26a3b659b8@kernel.org> User-Agent: Mutt/2.4.0 (2026-06-19) Hi Krzysztof, On Fri, Aug 21, 2026 at 01:04:01PM +0200, Krzysztof Kozlowski wrote: > On 21/08/2026 10:53, Geert Uytterhoeven wrote: > > The clk_init_data structure contains several mutually-exclusive members > > for different methods to specify the possible parents of a clock, > > prompting drivers to initialize only the members they need. However, > > not initializing all members may cause subtle issues, which are only > > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > > enabled. > > > > Make sure all members are fully initialized, to avoid such bugs, and to > > prevent future breakage when converting drivers to a different method > > for specifying the parents. > > > > Signed-off-by: Geert Uytterhoeven > > --- > > Compile-tested only. > > --- > > drivers/clk/samsung/clk-cpu.c | 2 +- > > drivers/clk/samsung/clk-pll.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > Reviewed-by: Krzysztof Kozlowski > > Let me know if I should take it via Samsung SoC clock tree. I assume by > default this will go directly via clock tree. Please take it through your Samsung tree to avoid merge conflicts if there are other changes to these files during this development cycle. Brian