From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] pinctrl: renesas: rzt2h: reuse helpers
Date: Sun, 13 Sep 2026 10:07:55 +0200 [thread overview]
Message-ID: <aqZZ29nvQb-A627J@black.igk.intel.com> (raw)
In-Reply-To: <20260910160226.489183-5-cosmin-gabriel.tanislav.xa@renesas.com>
On Thu, Sep 10, 2026 at 07:02:26PM +0300, Cosmin Tanislav wrote:
> The PMCm peripheral-mode test, the PFCm function read, the PINm input
> read, the PMm write, and the PMm read are open-coded in several places.
> Reuse the already existing helpers.
...
> - reg64 = rzt2h_pinctrl_readq(pctrl, port, PFC(port));
> - reg64 = (reg64 >> (bit * 8)) & PFC_MASK;
> - if (reg64 == PFC_FUNC_INTERRUPT)
> + if (rzt2h_pin_read_pfc(pctrl, port, bit) == PFC_FUNC_INTERRUPT)
> return GPIO_LINE_DIRECTION_IN;
Basically this part with the helper should be split into a separate patch w/o
Fixes tag.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-09-13 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 16:02 [PATCH v2 0/4] Renesas RZ/T2H pinctrl fixes and cleanups Cosmin Tanislav
2026-09-10 16:02 ` [PATCH v2 1/4] pinctrl: renesas: rzt2h: restore correct pin mode on IRQ free Cosmin Tanislav
2026-09-10 16:02 ` [PATCH v2 2/4] pinctrl: renesas: rzt2h: setup IRQ in .irq_{request,release}_resources() Cosmin Tanislav
2026-09-10 16:02 ` [PATCH v2 3/4] pinctrl: renesas: rzt2h: fix reading pin value in IRQ function Cosmin Tanislav
2026-09-13 7:51 ` Andy Shevchenko
2026-09-13 7:55 ` Cosmin-Gabriel Tanislav
2026-09-10 16:02 ` [PATCH v2 4/4] pinctrl: renesas: rzt2h: reuse helpers Cosmin Tanislav
2026-09-13 8:07 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqZZ29nvQb-A627J@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@kernel.org \
--cc=cosmin-gabriel.tanislav.xa@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox