Re: [PATCH v4 4/5] arm64: dts: renesas: r9a09g057: Add IVC and ISP nodes

[Jacopo Mondi <jacopo.mondi@ideasonboard.com>]

On Wed, Oct 28, 2026 at 09:38:05AM +0100, Linus Walleij wrote:
> On Tue, Oct 27, 2026 at 7:39 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> > The driver uses Runtime PM, but I see no calls to
> > pm_runtime_resume_and_get()?
>
> It gets grabbed in *params.c and *stats.c:
>

pm_runtime_resume_and_get() is called in the .start_streaming handler
for all video nodes (capture, params and stats)

> linux/drivers/media/platform/arm/mali-c55$ git grep pm_runtime*
> mali-c55-capture.c:#include <linux/pm_runtime.h>
> mali-c55-capture.c:     ret = pm_runtime_resume_and_get(mali_c55->dev);
> mali-c55-capture.c:     pm_runtime_put_autosuspend(mali_c55->dev);
> mali-c55-capture.c:     pm_runtime_put_autosuspend(mali_c55->dev);
> mali-c55-core.c:#include <linux/pm_runtime.h>
> mali-c55-core.c:        SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> mali-c55-core.c:                                pm_runtime_force_resume)
> mali-c55-core.c:        pm_runtime_set_autosuspend_delay(&pdev->dev, 2000);
> mali-c55-core.c:        pm_runtime_use_autosuspend(&pdev->dev);
> mali-c55-core.c:        pm_runtime_set_active(&pdev->dev);
> mali-c55-core.c:        pm_runtime_enable(&pdev->dev);
> mali-c55-core.c:                goto err_pm_runtime_disable;
> mali-c55-core.c:        pm_runtime_idle(&pdev->dev);
> mali-c55-core.c:err_pm_runtime_disable:
> mali-c55-core.c:        pm_runtime_set_suspended(&pdev->dev);
> mali-c55-core.c:        pm_runtime_disable(&pdev->dev);
> mali-c55-core.c:        if (!pm_runtime_suspended(&pdev->dev)) {
> mali-c55-core.c:                pm_runtime_set_suspended(&pdev->dev);
> mali-c55-core.c:        pm_runtime_disable(&pdev->dev);
> mali-c55-params.c:#include <linux/pm_runtime.h>
> mali-c55-params.c:      ret = pm_runtime_resume_and_get(mali_c55->dev);
> mali-c55-params.c:      pm_runtime_put_autosuspend(mali_c55->dev);
> mali-c55-params.c:      pm_runtime_put_autosuspend(params->mali_c55->dev);
> mali-c55-stats.c:#include <linux/pm_runtime.h>
> mali-c55-stats.c:       ret = pm_runtime_resume_and_get(mali_c55->dev);
> mali-c55-stats.c:       pm_runtime_put_autosuspend(mali_c55->dev);
> mali-c55-stats.c:       pm_runtime_put_autosuspend(stats->mali_c55->dev);
> mali-c55-tpg.c:#include <linux/pm_runtime.h>
> mali-c55-tpg.c: if (!pm_runtime_get_if_in_use(mali_c55->dev))
> mali-c55-tpg.c: pm_runtime_put_autosuspend(mali_c55->dev);
>
> So are you saying these runpaths are not necessarily getting exercised,

They are when you start streaming on those video devices, if I got
what you mean here.


> so the reference doesn't go up on normal use cases?
>
> Yours,
> Linus Walleij
>