From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] sh_eth: fix EESIPR values for SH77{34|63}
Date: Wed, 4 Jan 2017 22:27:02 +0300 [thread overview]
Message-ID: <c2525f66-c5e7-0e2e-92de-d22d82d81920@cogentembedded.com> (raw)
In-Reply-To: <1819012.0ROIJmx7mp@wasted.cogentembedded.com>
On 01/04/2017 10:18 PM, Sergei Shtylyov wrote:
> As the SH77{34|63} manuals are freely available, I've checked the EESIPR
> values written against the manuals, and they appeared to set the reserved
> bits 11-15 (which should be 0 on write). Fix those EESIPR values.
>
> Fixes: 380af9e390ec ("net: sh_eth: CPU dependency code collect to "struct sh_eth_cpu_data"")
For SH7763 the bug is older than this commit but the code was common for
all SH SoCs supported back then and so couldn't be fixed w/o affecting other
SoCs. However, I suspect that the mask was incorrect even for the other SoCs...
> Fixes: f5d12767c8fd ("sh_eth: get SH77{34|63} support out of #ifdef")
That's the point where SH7734/63 data were split...
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2017-01-04 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 19:18 [PATCH] sh_eth: fix EESIPR values for SH77{34|63} Sergei Shtylyov
2017-01-04 19:27 ` Sergei Shtylyov [this message]
2017-01-06 20:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2525f66-c5e7-0e2e-92de-d22d82d81920@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).