* [PATCH 00/15] arm: dts: Fix OPP and cooling device properties @ 2018-05-25 10:31 Viresh Kumar 2018-05-25 10:31 ` [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs Viresh Kumar 0 siblings, 1 reply; 11+ messages in thread From: Viresh Kumar @ 2018-05-25 10:31 UTC (permalink / raw) To: arm, Andrew Lunn, Andy Gross, Benoît Cousson, Chen-Yu Tsai, David Brown, Fabio Estevam, Gregory Clement, Heiko Stuebner, Jason Cooper, Jisheng Zhang, Krzysztof Kozlowski, Kukjin Kim, Magnus Damm, Mark Rutland, Masahiro Yamada, Matthias Brugger, Maxime Ripard, Pengutronix Kernel Team, Rob Herring, Rob Herring, Sascha Hauer, Sebastian Hesselbarth, Shawn Guo, Simon Horman, Tony Lindgren Cc: Viresh Kumar, Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath, devicetree, linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek, linux-omap, linux-renesas-soc, linux-rockchip, linux-samsung-soc, linux-soc This fixes missing OPP and cooling device properties for CPUs for the ARM 32 bit platforms. This is build tested by the zero day testing infrastructure as well. Individual maintainers can pick the patches to their SoC trees or I will ask ARM SoC maintainers to pick them up later. -- viresh Viresh Kumar (15): arm: dts: armada: Fix "#cooling-cells" property's name arm: dts: ls1021a: Add missing cooling device properties for CPUs arm: dts: mediatek: Add missing cooling device properties for CPUs arm: dts: rk322x: Add missing cooling device properties for CPUs arm: dts: uniphier: Add missing cooling device properties for CPUs arm: dts: sun: Add missing cooling device properties for CPUs arm: dts: exynos: Add missing cooling device properties for CPUs arm: dts: dra74x: Add missing cooling device properties for CPUs arm: dts: omap: Add missing cooling device properties for CPUs arm: dts: rk3288: Add missing cooling device properties for CPUs arm: dts: berlin: Add missing OPP properties for CPUs arm: dts: highbank: Add missing OPP properties for CPUs arm: dts: r8a7743: Add missing OPP properties for CPUs arm: dts: qcom: Add missing OPP properties for CPUs arm: dts: imx: Add missing OPP properties for CPUs arch/arm/boot/dts/armada-385-synology-ds116.dts | 2 +- arch/arm/boot/dts/berlin2.dtsi | 10 +++ arch/arm/boot/dts/berlin2q.dtsi | 33 ++++++++++ arch/arm/boot/dts/dra74x.dtsi | 10 +++ arch/arm/boot/dts/exynos3250.dtsi | 16 +++++ arch/arm/boot/dts/exynos4210.dtsi | 13 ++++ arch/arm/boot/dts/exynos4412.dtsi | 9 +++ arch/arm/boot/dts/exynos5250.dtsi | 23 +++++++ arch/arm/boot/dts/highbank.dts | 30 +++++++++ arch/arm/boot/dts/imx6dl.dtsi | 23 +++++++ arch/arm/boot/dts/imx6q-cm-fx6.dts | 66 +++++++++++++++++++ arch/arm/boot/dts/imx6q.dtsi | 87 ++++++++++++++++++++++++- arch/arm/boot/dts/imx7d.dtsi | 5 ++ arch/arm/boot/dts/ls1021a.dtsi | 1 + arch/arm/boot/dts/mt7623.dtsi | 3 + arch/arm/boot/dts/omap5.dtsi | 14 ++++ arch/arm/boot/dts/qcom-ipq4019.dtsi | 24 +++++++ arch/arm/boot/dts/r8a7743.dtsi | 9 +++ arch/arm/boot/dts/rk322x.dtsi | 3 + arch/arm/boot/dts/rk3288.dtsi | 54 +++++++++++++++ arch/arm/boot/dts/sun6i-a31.dtsi | 30 +++++++++ arch/arm/boot/dts/sun7i-a20.dtsi | 13 ++++ arch/arm/boot/dts/sun8i-a33.dtsi | 9 +++ arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++ arch/arm/boot/dts/uniphier-pxs2.dtsi | 3 + 25 files changed, 495 insertions(+), 4 deletions(-) -- 2.15.0.194.g9af6a3dea062 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs 2018-05-25 10:31 [PATCH 00/15] arm: dts: Fix OPP and cooling device properties Viresh Kumar @ 2018-05-25 10:31 ` Viresh Kumar 2018-05-28 9:23 ` Simon Horman 2018-05-30 4:46 ` [PATCH V2 13/15] arm: dts: r8a77xx: " Viresh Kumar 0 siblings, 2 replies; 11+ messages in thread From: Viresh Kumar @ 2018-05-25 10:31 UTC (permalink / raw) To: arm, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: Viresh Kumar, Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath, linux-renesas-soc, devicetree, linux-kernel The OPP properties, like "operating-points", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can create an OPP table. Add such missing properties. Fix other missing property (clock latency) as well to make it all work. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- arch/arm/boot/dts/r8a7743.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 142949d7066f..e4fb31c4f0ee 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -98,8 +98,17 @@ reg = <1>; clock-frequency = <1500000000>; clocks = <&cpg CPG_CORE R8A7743_CLK_Z>; + clock-latency = <300000>; /* 300 us */ power-domains = <&sysc R8A7743_PD_CA15_CPU1>; next-level-cache = <&L2_CA15>; + + /* kHz - uV - OPPs unknown yet */ + operating-points = <1500000 1000000>, + <1312500 1000000>, + <1125000 1000000>, + < 937500 1000000>, + < 750000 1000000>, + < 375000 1000000>; }; L2_CA15: cache-controller-0 { -- 2.15.0.194.g9af6a3dea062 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs 2018-05-25 10:31 ` [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs Viresh Kumar @ 2018-05-28 9:23 ` Simon Horman 2018-05-28 10:58 ` Viresh Kumar 2018-05-30 4:46 ` [PATCH V2 13/15] arm: dts: r8a77xx: " Viresh Kumar 1 sibling, 1 reply; 11+ messages in thread From: Simon Horman @ 2018-05-28 9:23 UTC (permalink / raw) To: Viresh Kumar Cc: arm, Magnus Damm, Rob Herring, Mark Rutland, Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath, linux-renesas-soc, devicetree, linux-kernel, Biju Das [Cc Biju Das] On Fri, May 25, 2018 at 04:01:59PM +0530, Viresh Kumar wrote: > The OPP properties, like "operating-points", should either be present > for all the CPUs of a cluster or none. If these are present only for a > subset of CPUs of a cluster then things will start falling apart as soon > as the CPUs are brought online in a different order. For example, this > will happen because the operating system looks for such properties in > the CPU node it is trying to bring up, so that it can create an OPP > table. > > Add such missing properties. > > Fix other missing property (clock latency) as well to make it all > work. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Thanks, this looks good to me and it looks like it should have: Fixes: 0417814ea140 ("ARM: dts: r8a7743: Add OPP table for frequency scaling") Biju, as the author of the above patch could you take a look over this fix? > --- > arch/arm/boot/dts/r8a7743.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 142949d7066f..e4fb31c4f0ee 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -98,8 +98,17 @@ > reg = <1>; > clock-frequency = <1500000000>; > clocks = <&cpg CPG_CORE R8A7743_CLK_Z>; > + clock-latency = <300000>; /* 300 us */ > power-domains = <&sysc R8A7743_PD_CA15_CPU1>; > next-level-cache = <&L2_CA15>; > + > + /* kHz - uV - OPPs unknown yet */ > + operating-points = <1500000 1000000>, > + <1312500 1000000>, > + <1125000 1000000>, > + < 937500 1000000>, > + < 750000 1000000>, > + < 375000 1000000>; > }; > > L2_CA15: cache-controller-0 { > -- > 2.15.0.194.g9af6a3dea062 > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs 2018-05-28 9:23 ` Simon Horman @ 2018-05-28 10:58 ` Viresh Kumar 2018-05-28 11:58 ` Simon Horman 0 siblings, 1 reply; 11+ messages in thread From: Viresh Kumar @ 2018-05-28 10:58 UTC (permalink / raw) To: Simon Horman Cc: arm, Magnus Damm, Rob Herring, Mark Rutland, Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath, linux-renesas-soc, devicetree, linux-kernel, Biju Das On 28-05-18, 11:23, Simon Horman wrote: > [Cc Biju Das] > > On Fri, May 25, 2018 at 04:01:59PM +0530, Viresh Kumar wrote: > > The OPP properties, like "operating-points", should either be present > > for all the CPUs of a cluster or none. If these are present only for a > > subset of CPUs of a cluster then things will start falling apart as soon > > as the CPUs are brought online in a different order. For example, this > > will happen because the operating system looks for such properties in > > the CPU node it is trying to bring up, so that it can create an OPP > > table. > > > > Add such missing properties. > > > > Fix other missing property (clock latency) as well to make it all > > work. > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > Thanks, this looks good to me and it looks like it should have: > > Fixes: 0417814ea140 ("ARM: dts: r8a7743: Add OPP table for frequency scaling") Sure. Will you be picking this patch directly and send it part of your pull request ? Maybe add Fixes tag then only ? -- viresh ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs 2018-05-28 10:58 ` Viresh Kumar @ 2018-05-28 11:58 ` Simon Horman 2018-05-29 13:33 ` Biju Das 0 siblings, 1 reply; 11+ messages in thread From: Simon Horman @ 2018-05-28 11:58 UTC (permalink / raw) To: Viresh Kumar Cc: arm, Magnus Damm, Rob Herring, Mark Rutland, Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath, linux-renesas-soc, devicetree, linux-kernel, Biju Das On Mon, May 28, 2018 at 04:28:31PM +0530, Viresh Kumar wrote: > On 28-05-18, 11:23, Simon Horman wrote: > > [Cc Biju Das] > > > > On Fri, May 25, 2018 at 04:01:59PM +0530, Viresh Kumar wrote: > > > The OPP properties, like "operating-points", should either be present > > > for all the CPUs of a cluster or none. If these are present only for a > > > subset of CPUs of a cluster then things will start falling apart as soon > > > as the CPUs are brought online in a different order. For example, this > > > will happen because the operating system looks for such properties in > > > the CPU node it is trying to bring up, so that it can create an OPP > > > table. > > > > > > Add such missing properties. > > > > > > Fix other missing property (clock latency) as well to make it all > > > work. > > > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > > > Thanks, this looks good to me and it looks like it should have: > > > > Fixes: 0417814ea140 ("ARM: dts: r8a7743: Add OPP table for frequency scaling") > > Sure. > > Will you be picking this patch directly and send it part of your pull > request ? Maybe add Fixes tag then only ? Yes, that is my plan. I can handle adding the Fixes tag. But I'll wait to see if Bjiu has an feedback first. ^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs 2018-05-28 11:58 ` Simon Horman @ 2018-05-29 13:33 ` Biju Das 2018-05-30 4:47 ` Viresh Kumar 0 siblings, 1 reply; 11+ messages in thread From: Biju Das @ 2018-05-29 13:33 UTC (permalink / raw) To: Simon Horman, Viresh Kumar Cc: arm@kernel.org, Magnus Damm, Rob Herring, Mark Rutland, Vincent Guittot, ionela.voinescu@arm.com, Daniel Lezcano, chris.redpath@arm.com, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Hi All, I have tested this patch on RZ/G1M and I didn't find any issues. r8a7743 is similar to r8a7791. So I assume you will apply the same patch for other R-SoC devices as well. Apart from this, maybe we need to update the OPP binding documentation. i.e., extend the operating- point usage to other cores in the cluster (Binding 1: operating-points). Regards, Biju > -----Original Message----- > From: Simon Horman [mailto:horms@verge.net.au] > Sent: 28 May 2018 12:59 > To: Viresh Kumar <viresh.kumar@linaro.org> > Cc: arm@kernel.org; Magnus Damm <magnus.damm@gmail.com>; Rob > Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; > Vincent Guittot <vincent.guittot@linaro.org>; ionela.voinescu@arm.com; > Daniel Lezcano <daniel.lezcano@linaro.org>; chris.redpath@arm.com; linux- > renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; Biju Das <biju.das@bp.renesas.com> > Subject: Re: [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for > CPUs > > On Mon, May 28, 2018 at 04:28:31PM +0530, Viresh Kumar wrote: > > On 28-05-18, 11:23, Simon Horman wrote: > > > [Cc Biju Das] > > > > > > On Fri, May 25, 2018 at 04:01:59PM +0530, Viresh Kumar wrote: > > > > The OPP properties, like "operating-points", should either be > > > > present for all the CPUs of a cluster or none. If these are > > > > present only for a subset of CPUs of a cluster then things will > > > > start falling apart as soon as the CPUs are brought online in a > > > > different order. For example, this will happen because the > > > > operating system looks for such properties in the CPU node it is > > > > trying to bring up, so that it can create an OPP table. > > > > > > > > Add such missing properties. > > > > > > > > Fix other missing property (clock latency) as well to make it all > > > > work. > > > > > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > > > > > Thanks, this looks good to me and it looks like it should have: > > > > > > Fixes: 0417814ea140 ("ARM: dts: r8a7743: Add OPP table for frequency > > > scaling") > > > > Sure. > > > > Will you be picking this patch directly and send it part of your pull > > request ? Maybe add Fixes tag then only ? > > Yes, that is my plan. I can handle adding the Fixes tag. > But I'll wait to see if Bjiu has an feedback first. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs 2018-05-29 13:33 ` Biju Das @ 2018-05-30 4:47 ` Viresh Kumar 0 siblings, 0 replies; 11+ messages in thread From: Viresh Kumar @ 2018-05-30 4:47 UTC (permalink / raw) To: Biju Das Cc: Simon Horman, arm@kernel.org, Magnus Damm, Rob Herring, Mark Rutland, Vincent Guittot, ionela.voinescu@arm.com, Daniel Lezcano, chris.redpath@arm.com, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org On 29-05-18, 13:33, Biju Das wrote: > Hi All, > > I have tested this patch on RZ/G1M and I didn't find any issues. > r8a7743 is similar to r8a7791. So I assume you will apply the same > patch for other R-SoC devices as well. Okay, I have sent V2 for this and it fixes all those platforms as well. > Apart from this, maybe we need to update the OPP binding > documentation. i.e., extend the operating- point usage to other > cores in the cluster (Binding 1: operating-points). Its already done, you need to start using operating-points-v2 property to avoid duplication like this. -- viresh ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH V2 13/15] arm: dts: r8a77xx: Add missing OPP properties for CPUs 2018-05-25 10:31 ` [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs Viresh Kumar 2018-05-28 9:23 ` Simon Horman @ 2018-05-30 4:46 ` Viresh Kumar 2018-05-31 14:24 ` Simon Horman ` (2 more replies) 1 sibling, 3 replies; 11+ messages in thread From: Viresh Kumar @ 2018-05-30 4:46 UTC (permalink / raw) To: arm, biju.das, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: Viresh Kumar, Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath, linux-renesas-soc, devicetree, linux-kernel The OPP properties, like "operating-points", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can create an OPP table. Add such missing properties. Fix other missing properties (like, clock latency, voltage tolerance, etc) as well to make it all work. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- arch/arm/boot/dts/r8a7743.dtsi | 9 +++++++++ arch/arm/boot/dts/r8a7790.dtsi | 34 ++++++++++++++++++++++++++++++++-- arch/arm/boot/dts/r8a7791.dtsi | 14 ++++++++++++-- arch/arm/boot/dts/r8a7793.dtsi | 15 +++++++++++++-- 4 files changed, 66 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 142949d7066f..e4fb31c4f0ee 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -98,8 +98,17 @@ reg = <1>; clock-frequency = <1500000000>; clocks = <&cpg CPG_CORE R8A7743_CLK_Z>; + clock-latency = <300000>; /* 300 us */ power-domains = <&sysc R8A7743_PD_CA15_CPU1>; next-level-cache = <&L2_CA15>; + + /* kHz - uV - OPPs unknown yet */ + operating-points = <1500000 1000000>, + <1312500 1000000>, + <1125000 1000000>, + < 937500 1000000>, + < 750000 1000000>, + < 375000 1000000>; }; L2_CA15: cache-controller-0 { diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 4d06b154bd7e..c4324b1a2ec4 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -79,12 +79,12 @@ compatible = "arm,cortex-a15"; reg = <0>; clock-frequency = <1300000000>; - voltage-tolerance = <1>; /* 1% */ clocks = <&cpg CPG_CORE R8A7790_CLK_Z>; - clock-latency = <300000>; /* 300 us */ power-domains = <&sysc R8A7790_PD_CA15_CPU0>; next-level-cache = <&L2_CA15>; capacity-dmips-mhz = <1024>; + voltage-tolerance = <1>; /* 1% */ + clock-latency = <300000>; /* 300 us */ /* kHz - uV - OPPs unknown yet */ operating-points = <1400000 1000000>, @@ -104,6 +104,16 @@ power-domains = <&sysc R8A7790_PD_CA15_CPU1>; next-level-cache = <&L2_CA15>; capacity-dmips-mhz = <1024>; + voltage-tolerance = <1>; /* 1% */ + clock-latency = <300000>; /* 300 us */ + + /* kHz - uV - OPPs unknown yet */ + operating-points = <1400000 1000000>, + <1225000 1000000>, + <1050000 1000000>, + < 875000 1000000>, + < 700000 1000000>, + < 350000 1000000>; }; cpu2: cpu@2 { @@ -115,6 +125,16 @@ power-domains = <&sysc R8A7790_PD_CA15_CPU2>; next-level-cache = <&L2_CA15>; capacity-dmips-mhz = <1024>; + voltage-tolerance = <1>; /* 1% */ + clock-latency = <300000>; /* 300 us */ + + /* kHz - uV - OPPs unknown yet */ + operating-points = <1400000 1000000>, + <1225000 1000000>, + <1050000 1000000>, + < 875000 1000000>, + < 700000 1000000>, + < 350000 1000000>; }; cpu3: cpu@3 { @@ -126,6 +146,16 @@ power-domains = <&sysc R8A7790_PD_CA15_CPU3>; next-level-cache = <&L2_CA15>; capacity-dmips-mhz = <1024>; + voltage-tolerance = <1>; /* 1% */ + clock-latency = <300000>; /* 300 us */ + + /* kHz - uV - OPPs unknown yet */ + operating-points = <1400000 1000000>, + <1225000 1000000>, + <1050000 1000000>, + < 875000 1000000>, + < 700000 1000000>, + < 350000 1000000>; }; cpu4: cpu@100 { diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi index 6e1dd7ad7bd6..d1d726a1364a 100644 --- a/arch/arm/boot/dts/r8a7791.dtsi +++ b/arch/arm/boot/dts/r8a7791.dtsi @@ -78,11 +78,11 @@ compatible = "arm,cortex-a15"; reg = <0>; clock-frequency = <1500000000>; - voltage-tolerance = <1>; /* 1% */ clocks = <&cpg CPG_CORE R8A7791_CLK_Z>; - clock-latency = <300000>; /* 300 us */ power-domains = <&sysc R8A7791_PD_CA15_CPU0>; next-level-cache = <&L2_CA15>; + voltage-tolerance = <1>; /* 1% */ + clock-latency = <300000>; /* 300 us */ /* kHz - uV - OPPs unknown yet */ operating-points = <1500000 1000000>, @@ -101,6 +101,16 @@ clocks = <&cpg CPG_CORE R8A7791_CLK_Z>; power-domains = <&sysc R8A7791_PD_CA15_CPU1>; next-level-cache = <&L2_CA15>; + voltage-tolerance = <1>; /* 1% */ + clock-latency = <300000>; /* 300 us */ + + /* kHz - uV - OPPs unknown yet */ + operating-points = <1500000 1000000>, + <1312500 1000000>, + <1125000 1000000>, + < 937500 1000000>, + < 750000 1000000>, + < 375000 1000000>; }; L2_CA15: cache-controller-0 { diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi index 4abecfc0ca98..1e6439b85a6b 100644 --- a/arch/arm/boot/dts/r8a7793.dtsi +++ b/arch/arm/boot/dts/r8a7793.dtsi @@ -70,10 +70,10 @@ compatible = "arm,cortex-a15"; reg = <0>; clock-frequency = <1500000000>; - voltage-tolerance = <1>; /* 1% */ clocks = <&cpg CPG_CORE R8A7793_CLK_Z>; - clock-latency = <300000>; /* 300 us */ power-domains = <&sysc R8A7793_PD_CA15_CPU0>; + voltage-tolerance = <1>; /* 1% */ + clock-latency = <300000>; /* 300 us */ /* kHz - uV - OPPs unknown yet */ operating-points = <1500000 1000000>, @@ -92,6 +92,17 @@ clock-frequency = <1500000000>; clocks = <&cpg CPG_CORE R8A7793_CLK_Z>; power-domains = <&sysc R8A7793_PD_CA15_CPU1>; + voltage-tolerance = <1>; /* 1% */ + clock-latency = <300000>; /* 300 us */ + + /* kHz - uV - OPPs unknown yet */ + operating-points = <1500000 1000000>, + <1312500 1000000>, + <1125000 1000000>, + < 937500 1000000>, + < 750000 1000000>, + < 375000 1000000>; + next-level-cache = <&L2_CA15>; }; L2_CA15: cache-controller-0 { -- 2.15.0.194.g9af6a3dea062 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH V2 13/15] arm: dts: r8a77xx: Add missing OPP properties for CPUs 2018-05-30 4:46 ` [PATCH V2 13/15] arm: dts: r8a77xx: " Viresh Kumar @ 2018-05-31 14:24 ` Simon Horman 2018-06-04 9:57 ` Simon Horman 2018-06-11 9:26 ` Geert Uytterhoeven 2 siblings, 0 replies; 11+ messages in thread From: Simon Horman @ 2018-05-31 14:24 UTC (permalink / raw) To: Viresh Kumar Cc: arm, biju.das, Magnus Damm, Rob Herring, Mark Rutland, Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath, linux-renesas-soc, devicetree, linux-kernel On Wed, May 30, 2018 at 10:16:58AM +0530, Viresh Kumar wrote: > The OPP properties, like "operating-points", should either be present > for all the CPUs of a cluster or none. If these are present only for a > subset of CPUs of a cluster then things will start falling apart as soon > as the CPUs are brought online in a different order. For example, this > will happen because the operating system looks for such properties in > the CPU node it is trying to bring up, so that it can create an OPP > table. > > Add such missing properties. > > Fix other missing properties (like, clock latency, voltage tolerance, > etc) as well to make it all work. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> This looks fine but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman <horms+renesas@verge.net.au> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 13/15] arm: dts: r8a77xx: Add missing OPP properties for CPUs 2018-05-30 4:46 ` [PATCH V2 13/15] arm: dts: r8a77xx: " Viresh Kumar 2018-05-31 14:24 ` Simon Horman @ 2018-06-04 9:57 ` Simon Horman 2018-06-11 9:26 ` Geert Uytterhoeven 2 siblings, 0 replies; 11+ messages in thread From: Simon Horman @ 2018-06-04 9:57 UTC (permalink / raw) To: Viresh Kumar Cc: arm, biju.das, Magnus Damm, Rob Herring, Mark Rutland, Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath, linux-renesas-soc, devicetree, linux-kernel On Wed, May 30, 2018 at 10:16:58AM +0530, Viresh Kumar wrote: > The OPP properties, like "operating-points", should either be present > for all the CPUs of a cluster or none. If these are present only for a > subset of CPUs of a cluster then things will start falling apart as soon > as the CPUs are brought online in a different order. For example, this > will happen because the operating system looks for such properties in > the CPU node it is trying to bring up, so that it can create an OPP > table. > > Add such missing properties. > > Fix other missing properties (like, clock latency, voltage tolerance, > etc) as well to make it all work. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Thanks, I took the liberty of changing the prefix of this patch to "ARM: dts: r8a77(43|9[013]):" when applying this patch. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH V2 13/15] arm: dts: r8a77xx: Add missing OPP properties for CPUs 2018-05-30 4:46 ` [PATCH V2 13/15] arm: dts: r8a77xx: " Viresh Kumar 2018-05-31 14:24 ` Simon Horman 2018-06-04 9:57 ` Simon Horman @ 2018-06-11 9:26 ` Geert Uytterhoeven 2 siblings, 0 replies; 11+ messages in thread From: Geert Uytterhoeven @ 2018-06-11 9:26 UTC (permalink / raw) To: Viresh Kumar Cc: arm, Biju Das, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland, Vincent Guittot, ionela.voinescu, Daniel Lezcano, chris.redpath, Linux-Renesas, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Linux Kernel Mailing List On Wed, May 30, 2018 at 6:47 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > The OPP properties, like "operating-points", should either be present > for all the CPUs of a cluster or none. If these are present only for a > subset of CPUs of a cluster then things will start falling apart as soon > as the CPUs are brought online in a different order. For example, this > will happen because the operating system looks for such properties in > the CPU node it is trying to bring up, so that it can create an OPP > table. > > Add such missing properties. > > Fix other missing properties (like, clock latency, voltage tolerance, > etc) as well to make it all work. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-06-11 9:26 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-05-25 10:31 [PATCH 00/15] arm: dts: Fix OPP and cooling device properties Viresh Kumar 2018-05-25 10:31 ` [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs Viresh Kumar 2018-05-28 9:23 ` Simon Horman 2018-05-28 10:58 ` Viresh Kumar 2018-05-28 11:58 ` Simon Horman 2018-05-29 13:33 ` Biju Das 2018-05-30 4:47 ` Viresh Kumar 2018-05-30 4:46 ` [PATCH V2 13/15] arm: dts: r8a77xx: " Viresh Kumar 2018-05-31 14:24 ` Simon Horman 2018-06-04 9:57 ` Simon Horman 2018-06-11 9:26 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).