From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Simon Horman" <horms+renesas@verge.net.au>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices
Date: Wed, 14 Dec 2016 16:37:48 +0300 [thread overview]
Message-ID: <eeff27f9-25eb-a981-33a9-15aa98ce9db1@cogentembedded.com> (raw)
In-Reply-To: <20161212160931.6478-3-niklas.soderlund+renesas@ragnatech.se>
Hello!
You forgot "R-Car" before "Gen2" in the subject.
On 12/12/2016 07:09 PM, Niklas Söderlund wrote:
> Tested on Gen2 r8a7791/Koelsch.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 87640b9..348ed22 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -624,8 +624,9 @@ static struct sh_eth_cpu_data r8a779x_data = {
>
> .register_type = SH_ETH_REG_FAST_RCAR,
>
> - .ecsr_value = ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD,
> - .ecsipr_value = ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP,
> + .ecsr_value = ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD | ECSR_MPD,
> + .ecsipr_value = ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP |
> + ECSIPR_MPDIP,
These expressions seem to have been sorted by the bit # before your patch,
now they aren't... care to fix? :-)
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-12-14 13:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 16:09 [PATCHv2 0/5] sh_eth: add wake-on-lan support via magic packet Niklas Söderlund
2016-12-12 16:09 ` [PATCHv2 1/5] sh_eth: add generic " Niklas Söderlund
2016-12-13 13:03 ` Geert Uytterhoeven
2016-12-13 16:27 ` Niklas Söderlund
2016-12-17 21:50 ` Sergei Shtylyov
2016-12-19 16:41 ` Niklas Söderlund
2016-12-19 16:56 ` Sergei Shtylyov
2016-12-18 20:26 ` Sergei Shtylyov
2016-12-19 16:39 ` Niklas Söderlund
2016-12-19 17:11 ` Geert Uytterhoeven
2016-12-24 21:53 ` Sergei Shtylyov
2016-12-12 16:09 ` [PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices Niklas Söderlund
2016-12-13 12:52 ` Geert Uytterhoeven
2016-12-14 13:37 ` Sergei Shtylyov [this message]
2016-12-17 21:52 ` Sergei Shtylyov
2016-12-12 16:09 ` [PATCHv2 3/5] sh_eth: enable wake-on-lan for r8a7740/armadillo Niklas Söderlund
2016-12-13 12:51 ` Geert Uytterhoeven
2016-12-12 16:09 ` [PATCHv2 4/5] sh_eth: enable wake-on-lan for sh7743 Niklas Söderlund
2016-12-13 10:59 ` Geert Uytterhoeven
2016-12-12 16:09 ` [PATCHv2 5/5] sh_eth: enable wake-on-lan for sh7763 Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeff27f9-25eb-a981-33a9-15aa98ce9db1@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).