From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f48.google.com ([209.85.215.48]:32780 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754063AbcESRhn (ORCPT ); Thu, 19 May 2016 13:37:43 -0400 Received: by mail-lf0-f48.google.com with SMTP id y84so40333208lfc.0 for ; Thu, 19 May 2016 10:37:43 -0700 (PDT) Subject: Re: [PATCH v3 3/6] ARM: dts: r8a7794: add MSTP10 clocks To: Geert Uytterhoeven References: <2378837.cigT3tNQPe@wasted.cogentembedded.com> <3321354.LNTkVAhXvF@wasted.cogentembedded.com> Cc: Simon Horman , linux-renesas-soc@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , Magnus Damm , Russell King , "linux-arm-kernel@lists.infradead.org" From: Sergei Shtylyov Message-ID: Date: Thu, 19 May 2016 20:37:39 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hello. On 05/19/2016 07:44 PM, Geert Uytterhoeven wrote: >> Add MSTP10 clocks to the R8A7794 device tree. >> >> This patch is based on the commit ee9141522dcf ("ARM: shmobile: r8a7791: >> add MSTP10 support on DTSI"). >> >> Signed-off-by: Sergei Shtylyov >> [...] >> Index: renesas/include/dt-bindings/clock/r8a7794-clock.h >> =================================================================== >> --- renesas.orig/include/dt-bindings/clock/r8a7794-clock.h >> +++ renesas/include/dt-bindings/clock/r8a7794-clock.h >> @@ -109,6 +109,34 @@ >> #define R8A7794_CLK_I2C1 30 >> #define R8A7794_CLK_I2C0 31 >> >> +/* MSTP10 */ >> +#define R8A7794_CLK_SSI_ALL 5 >> +#define R8A7794_CLK_SSI9 6 >> +#define R8A7794_CLK_SSI8 7 >> +#define R8A7794_CLK_SSI7 8 >> +#define R8A7794_CLK_SSI6 9 >> +#define R8A7794_CLK_SSI5 10 >> +#define R8A7794_CLK_SSI4 11 >> +#define R8A7794_CLK_SSI3 12 >> +#define R8A7794_CLK_SSI2 13 >> +#define R8A7794_CLK_SSI1 14 >> +#define R8A7794_CLK_SSI0 15 >> +#define R8A7794_CLK_SCU_ALL 17 >> +#define R8A7794_CLK_SCU_DVC1 18 >> +#define R8A7794_CLK_SCU_DVC0 19 >> +#define R8A7794_CLK_SCU_CTU1_MIX1 20 >> +#define R8A7794_CLK_SCU_CTU0_MIX0 21 >> +#define R8A7794_CLK_SCU_SRC9 22 >> +#define R8A7794_CLK_SCU_SRC8 23 >> +#define R8A7794_CLK_SCU_SRC7 24 > > R-Car E2 does not have SRC7, SRC8, SRC9, ... > >> +#define R8A7794_CLK_SCU_SRC6 25 >> +#define R8A7794_CLK_SCU_SRC5 26 >> +#define R8A7794_CLK_SCU_SRC4 27 >> +#define R8A7794_CLK_SCU_SRC3 28 >> +#define R8A7794_CLK_SCU_SRC2 29 >> +#define R8A7794_CLK_SCU_SRC1 30 >> +#define R8A7794_CLK_SCU_SRC0 31 > > ... and SRC0. Yet table 7A.12 in the rev1.02 manual lists them all. Your manual doesn't? MBR, Sergei