From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f52.google.com ([209.85.215.52]:35306 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbcLQVxC (ORCPT ); Sat, 17 Dec 2016 16:53:02 -0500 Received: by mail-lf0-f52.google.com with SMTP id b14so30723599lfg.2 for ; Sat, 17 Dec 2016 13:53:01 -0800 (PST) Subject: Re: [PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Simon Horman , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20161212160931.6478-1-niklas.soderlund+renesas@ragnatech.se> <20161212160931.6478-3-niklas.soderlund+renesas@ragnatech.se> Cc: Geert Uytterhoeven From: Sergei Shtylyov Message-ID: Date: Sun, 18 Dec 2016 00:52:58 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On 12/14/2016 04:37 PM, Sergei Shtylyov wrote: >> Tested on Gen2 r8a7791/Koelsch. >> >> Signed-off-by: Niklas Söderlund >> --- >> drivers/net/ethernet/renesas/sh_eth.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/renesas/sh_eth.c >> b/drivers/net/ethernet/renesas/sh_eth.c >> index 87640b9..348ed22 100644 >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> @@ -624,8 +624,9 @@ static struct sh_eth_cpu_data r8a779x_data = { >> >> .register_type = SH_ETH_REG_FAST_RCAR, >> >> - .ecsr_value = ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD, >> - .ecsipr_value = ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP, >> + .ecsr_value = ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD | ECSR_MPD, >> + .ecsipr_value = ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP | >> + ECSIPR_MPDIP, > > These expressions seem to have been sorted by the bit # before your patch, > now they aren't... care to fix? :-) After looking at the SH7743/64 code, nevermind this request. Sorry. :-) MBR, Sergei