From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Paul Walmsley'" <paul.walmsley@sifive.com>,
"'Palmer Dabbelt'" <palmer@dabbelt.com>,
"'Albert Ou'" <aou@eecs.berkeley.edu>
Cc: <linux-riscv@lists.infradead.org>
Subject: RE: [PATCH] riscv: defconfig: Regenerate defconfig
Date: Mon, 30 Oct 2023 19:06:54 +0900 [thread overview]
Message-ID: <007701da0b18$cf5a8e70$6e0fab50$@samsung.com> (raw)
In-Reply-To: <df5d83c6-00c4-43fa-bd83-10c3389689df@kernel.org>
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Sunday, October 29, 2023 4:50 PM
> To: Chanho Park <chanho61.park@samsung.com>; Paul Walmsley
> <paul.walmsley@sifive.com>; Palmer Dabbelt <palmer@dabbelt.com>; Albert Ou
> <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> Subject: Re: [PATCH] riscv: defconfig: Regenerate defconfig
>
> On 27/10/2023 13:35, Chanho Park wrote:
> > Run 'make defconfig savedefconfig' and copy the defconfig file to
> > arch/riscv/configs/defconfig.
> >
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> > arch/riscv/configs/defconfig | 10 +---------
> > 1 file changed, 1 insertion(+), 9 deletions(-)
> >
> > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> > index ab86ec3b9eab..83fa02611284 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -27,15 +27,12 @@ CONFIG_EXPERT=y
> > CONFIG_PROFILING=y
> > CONFIG_SOC_MICROCHIP_POLARFIRE=y
> > CONFIG_ARCH_RENESAS=y
> > -CONFIG_ARCH_THEAD=y
> > CONFIG_SOC_SIFIVE=y
> > CONFIG_SOC_STARFIVE=y
> > CONFIG_ARCH_SUNXI=y
> > +CONFIG_ARCH_THEAD=y
> > CONFIG_SOC_VIRT=y
> > CONFIG_SMP=y
> > -CONFIG_HOTPLUG_CPU=y
> > -CONFIG_PM=y
>
> User-selectible options should not be removed from defconfig via
> savedefconfig. Please do not run blind savedefconfig, unless you are
> okay with actually loosing these options. We discussed this multiple
> times...
>
> https://lore.kernel.org/all/20201130202501.GA32878@kozik-lap/
> and some other threads
>
I see. When I run savedefconfig, I always checked .config changes between old and new to avoid such missing.
I thought there were some things that needed to be fixed manually, which could lead to mistakes.
Also, if you make a mess with a manual update, it makes the next update harder.
Thanks for pointing that out and explaining the history :)
Best Regards,
Chanho Park
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2023-10-30 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231027113547epcas2p1c6b08e800408ee234230d3d02b8301d0@epcas2p1.samsung.com>
2023-10-27 11:35 ` [PATCH] riscv: defconfig: Regenerate defconfig Chanho Park
2023-10-29 7:49 ` Krzysztof Kozlowski
2023-10-30 10:06 ` Chanho Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007701da0b18$cf5a8e70$6e0fab50$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=aou@eecs.berkeley.edu \
--cc=krzk@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox