From: Alex Elder <elder@riscstar.com>
To: Yixun Lan <dlan@gentoo.org>, Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Guodong Xu <guodong@riscstar.com>,
Inochi Amaoto <inochiama@gmail.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH v3 4/4] reset: spacemit: fix auxiliary device id
Date: Tue, 6 Jan 2026 08:43:59 -0600 [thread overview]
Message-ID: <058d3911-ff2d-4151-b585-5bcb8810bedf@riscstar.com> (raw)
In-Reply-To: <20260103-06-k1-clk-common-v3-4-6061d9f69eef@gentoo.org>
On 1/3/26 1:26 AM, Yixun Lan wrote:
> Due to the auxiliary register procedure moved to ccu common module where
> the module name changed to spacemit_ccu, then the reset auxiliary device
> register id also need to be adjusted in order to prepare for adding new
> K3 reset driver, otherwise two reset drivers will claim to support same
> "compatible" auxiliary device.
>
> Signed-off-by: Yixun Lan <dlan@gentoo.org>
This would ideally be merged with the previous patch. Maybe
Philipp can negotiate with Stephen to have that happen.
Reviewed-by: Alex Elder <elder@riscstar.com>
> ---
> drivers/reset/reset-spacemit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-spacemit.c b/drivers/reset/reset-spacemit.c
> index e1272aff28f7..cc7fd1f8750d 100644
> --- a/drivers/reset/reset-spacemit.c
> +++ b/drivers/reset/reset-spacemit.c
> @@ -278,7 +278,7 @@ static int spacemit_reset_probe(struct auxiliary_device *adev,
>
> #define K1_AUX_DEV_ID(_unit) \
> { \
> - .name = "spacemit_ccu_k1." #_unit "-reset", \
> + .name = "spacemit_ccu.k1-" #_unit "-reset", \
> .driver_data = (kernel_ulong_t)&k1_ ## _unit ## _reset_data, \
> }
>
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-01-06 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 7:26 [PATCH v3 0/4] clk: spacemit: refactor common ccu driver Yixun Lan
2026-01-03 7:26 ` [PATCH v3 1/4] clk: spacemit: prepare common ccu header Yixun Lan
2026-01-06 14:43 ` Alex Elder
2026-01-03 7:26 ` [PATCH v3 2/4] clk: spacemit: extract common ccu functions Yixun Lan
2026-01-06 14:43 ` Alex Elder
2026-01-06 22:27 ` Yixun Lan
2026-01-06 23:42 ` Alex Elder
2026-01-03 7:26 ` [PATCH v3 3/4] clk: spacemit: add platform SoC prefix to reset name Yixun Lan
2026-01-06 14:43 ` Alex Elder
2026-01-03 7:26 ` [PATCH v3 4/4] reset: spacemit: fix auxiliary device id Yixun Lan
2026-01-06 14:43 ` Alex Elder [this message]
2026-01-08 11:07 ` Philipp Zabel
2026-01-08 12:24 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=058d3911-ff2d-4151-b585-5bcb8810bedf@riscstar.com \
--to=elder@riscstar.com \
--cc=dlan@gentoo.org \
--cc=guodong@riscstar.com \
--cc=inochiama@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox