From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F8FCA9EAF for ; Thu, 24 Oct 2019 17:07:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A10FD21655 for ; Thu, 24 Oct 2019 17:07:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eZ/5Pl1G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A10FD21655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=deltatee.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/RelRzoeINrdQSvrzyjnlmF7BK/8av3rTXvZ/tDwo7A=; b=eZ/5Pl1GCoYSfw nCb65ANir13J7DLi4FVWewlrpKmj4jiKNoB64HqRgNf3g6n0lvWDA8V/egGNDayytXVprY9EhBV0i imKpSWe35g1cIF2s6ElJrrxl/sB+EbfHEXQ4klI9+nES+JgCF7Hdwd1YQ2Dx7FAbp108MAikHjOPZ kbCBDYgCoi+1xtHI/NE56aoLSfJlrqOg85nWKRIo/USxw+CBdeL4dEIbTvHuktT5aVbhx2zvqATPx e0O3YVmuIQl3IO+xGqMdwstNVTUIECz+Zc3hVyaX2HaAMzFVix1h6pka4i3p5bmahA0Oim7ba7bm/ MMp5089jVEl4fMwmaTYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNgaB-0005xP-IW; Thu, 24 Oct 2019 17:07:31 +0000 Received: from ale.deltatee.com ([207.54.116.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNga8-0005qT-Ad for linux-riscv@lists.infradead.org; Thu, 24 Oct 2019 17:07:29 +0000 Received: from s0106ac1f6bb1ecac.cg.shawcable.net ([70.73.163.230] helo=[192.168.11.155]) by ale.deltatee.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1iNgZv-0005cq-D7; Thu, 24 Oct 2019 11:07:16 -0600 To: Paul Walmsley References: <1571908438-4802-1-git-send-email-yash.shah@sifive.com> From: Logan Gunthorpe Message-ID: <0684fa31-1dfd-9f6c-762e-5811e6e9d5b9@deltatee.com> Date: Thu, 24 Oct 2019 11:07:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-SA-Exim-Connect-IP: 70.73.163.230 X-SA-Exim-Rcpt-To: allison@lohutok.net, will@kernel.org, tglx@linutronix.de, gregkh@linuxfoundation.org, greentime.hu@g.sifive.com, sachin.ghadi@sifive.com, rppt@linux.ibm.com, Anup.Patel@wdc.com, catalin.marinas@arm.com, alex@ghiti.fr, aou@eecs.berkeley.edu, sorear2@gmail.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@g.sifive.com, paul.walmsley@g.sifive.com, yash.shah@sifive.com, paul.walmsley@sifive.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] RISC-V: Add PCIe I/O BAR memory mapping X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191024_100728_706779_3C3C8BAC X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "sorear2@gmail.com" , "aou@eecs.berkeley.edu" , "alex@ghiti.fr" , "catalin.marinas@arm.com" , "Palmer Dabbelt \( Sifive\)" , "Anup.Patel@wdc.com" , "linux-kernel@vger.kernel.org" , "Paul Walmsley \( Sifive\)" , "rppt@linux.ibm.com" , Sachin Ghadi , Yash Shah , Greentime Hu , "gregkh@linuxfoundation.org" , "linux-riscv@lists.infradead.org" , "will@kernel.org" , "tglx@linutronix.de" , "allison@lohutok.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On 2019-10-24 10:51 a.m., Paul Walmsley wrote: > On Thu, 24 Oct 2019, Logan Gunthorpe wrote: > >> On 2019-10-24 3:14 a.m., Yash Shah wrote: >>> For I/O BARs to work correctly on RISC-V Linux, we need to establish a >>> reserved memory region for them, so that drivers that wish to use I/O BARs >>> can issue reads and writes against a memory region that is mapped to the >>> host PCIe controller's I/O BAR MMIO mapping. >> >> I don't think other arches do this. > > $ git grep 'define PCI_IOBASE' arch/ > arch/arm/include/asm/io.h:#define PCI_IOBASE ((void __iomem *)PCI_IO_VIRT_BASE) > arch/arm64/include/asm/io.h:#define PCI_IOBASE ((void __iomem *)PCI_IO_START) > arch/m68k/include/asm/io_no.h:#define PCI_IOBASE ((void __iomem *) PCI_IO_PA) > arch/microblaze/include/asm/io.h:#define PCI_IOBASE ((void __iomem *)_IO_BASE) > arch/unicore32/include/asm/io.h:#define PCI_IOBASE PKUNITY_PCILIO_BASE > arch/xtensa/include/asm/io.h:#define PCI_IOBASE ((void __iomem *)XCHAL_KIO_BYPASS_VADDR) > $ > > This is for the old x86-style, non-memory mapped I/O address space the > legacy PCI stuff that one would use in{b,w,l}()/out{b,w,l}() for. > > Yash, you might consider updating your patch description to note that this > is for "legacy I/O BARs (i.e., non-MMIO BARs)" or something similar. That > might make things clearer. Ah, right, yes, that would clear things up. Logan _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv