Re: [PATCH v3 2/8] riscv: dts: microchip: move sysctrlr out of soc bus

[<Conor.Dooley@microchip.com>]

On 04/05/2022 00:37, Heiko Stuebner wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Am Sonntag, 1. Mai 2022, 21:25:53 CEST schrieb Conor Dooley:
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> The MPFS system controller has no registers of its own, so move it out
>> of the soc node to avoid dtbs_check warnings:
>> arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dtb: soc: syscontroller: {'compatible': ['microchip,mpfs-sys-controller'], 'mboxes': [[15, 0]], 'status': ['okay']} should not be valid under {'type': 'object'}
>>
>> Reported-by: Palmer Dabbelt <palmer@rivosinc.com>
>> Suggested-by: Rob Herring <robh@kernel.org>
>> Fixes: 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> 
> What function does the "soc-bus" have at all?
> I.e. mailbox@37020000 also looks like a peripheral
> of the chip but is outside it.

I am not sure why a soc bus was chosen originally, splitting between
axi and ahb would be more accurate.

> 
> And I remember getting the suggestion to not use soc-"busses"
> over in arm-land years ago [0].
> 
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c3030d30d9c99c057b5ddfa289cffa637a2775f5
> 
>> ---
>>   arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> index 746c4d4e7686..bf21a2edd180 100644
>> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> @@ -146,6 +146,11 @@ refclk: mssrefclk {
>>                #clock-cells = <0>;
>>        };
>>
>> +     syscontroller: syscontroller {
>> +             compatible = "microchip,mpfs-sys-controller";
>> +             mboxes = <&mbox 0>;
>> +     };
>> +
>>        soc {
>>                #address-cells = <2>;
>>                #size-cells = <2>;
>> @@ -446,10 +451,5 @@ mbox: mailbox@37020000 {
>>                        #mbox-cells = <1>;
>>                        status = "disabled";
>>                };
>> -
>> -             syscontroller: syscontroller {
>> -                     compatible = "microchip,mpfs-sys-controller";
>> -                     mboxes = <&mbox 0>;
>> -             };
>>        };
>>   };
>>
> 
> 
> 
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv