From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Conor.Dooley@microchip.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
michael.zhu@starfivetech.com, drew@beagleboard.org,
kernel@esmil.dk
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 0/3] Enable initial support for StarFive VisionFive V1 SBC
Date: Fri, 2 Sep 2022 13:12:52 +0300 [thread overview]
Message-ID: <092ed898-dee9-e27f-1f18-3a17b259563e@collabora.com> (raw)
In-Reply-To: <04151f8b-5722-b5a0-a4ab-4958f55b8dec@microchip.com>
On 9/2/22 09:27, Conor.Dooley@microchip.com wrote:
> On 01/09/2022 23:42, Cristian Ciocaltea wrote:
>> [You don't often get email from cristian.ciocaltea@collabora.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> The StarFive VisionFive V1 SBC [1] is similar with the already supported
>> BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
>>
>> In addition to documenting the necessary compatibles, this patch series
>> moves most of the content from jh7100-beaglev-starlight.dts to a new file
>> jh7100-common.dtsi, to be shared between the two boards.
>>
>> No other changes are required in order to successfully boot the board.
>
> Gave it a go this morning, dts stuff itself looks good to me. No new
> warnings, although that's to be expected, & boots fine.
>
> I know that most jn7100 stuff is not really wanted upstream, but I'd
> say that the minimal vision5 dts is an exception to that, so with the
> one comment on patch 1 resolved:
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks for the quick review, I have submitted v2:
https://lore.kernel.org/all/20220902100806.2378543-1-cristian.ciocaltea@collabora.com/
Regards,
Cristian
> Thanks,
> Conor.
>
>>
>> [1] https://github.com/starfive-tech/VisionFive
>>
>> Cristian Ciocaltea (3):
>> dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
>> riscv: dts: starfive: Add common DT for JH7100 based boards
>> riscv: dts: starfive: Add StarFive VisionFive V1 device tree
>>
>> .../devicetree/bindings/riscv/starfive.yaml | 3 +
>> arch/riscv/boot/dts/starfive/Makefile | 2 +-
>> .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +----------------
>> .../boot/dts/starfive/jh7100-common.dtsi | 161 ++++++++++++++++++
>> .../jh7100-starfive-visionfive-v1.dts | 20 +++
>> 5 files changed, 186 insertions(+), 153 deletions(-)
>> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-common.dtsi
>> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>>
>> --
>> 2.37.2
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2022-09-02 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 22:42 [PATCH 0/3] Enable initial support for StarFive VisionFive V1 SBC Cristian Ciocaltea
2022-09-01 22:42 ` [PATCH 1/3] dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board Cristian Ciocaltea
2022-09-02 5:41 ` Conor.Dooley
2022-09-01 22:42 ` [PATCH 2/3] riscv: dts: starfive: Add common DT for JH7100 based boards Cristian Ciocaltea
2022-09-01 22:42 ` [PATCH 3/3] riscv: dts: starfive: Add StarFive VisionFive V1 device tree Cristian Ciocaltea
2022-09-02 6:27 ` [PATCH 0/3] Enable initial support for StarFive VisionFive V1 SBC Conor.Dooley
2022-09-02 10:12 ` Cristian Ciocaltea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=092ed898-dee9-e27f-1f18-3a17b259563e@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=Conor.Dooley@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=kernel@collabora.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael.zhu@starfivetech.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox