From: "Heiko Stübner" <heiko@sntech.de>
To: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, linux-efi@vger.kernel.org
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>
Subject: Re: [PATCH 4/6] riscv: Fix EFI stub usage of KASAN instrumented string functions
Date: Wed, 04 Jan 2023 16:38:05 +0100 [thread overview]
Message-ID: <10490920.nUPlyArG6x@diego> (raw)
In-Reply-To: <20221216162141.1701255-5-alexghiti@rivosinc.com>
Am Freitag, 16. Dezember 2022, 17:21:39 CET schrieb Alexandre Ghiti:
> The EFI stub must not use any KASAN instrumented code as the kernel
> proper did not initialize the thread pointer and the mapping for the
> KASAN shadow region.
>
> Avoid using generic string functions by copying stub dependencies from
> lib/string.c to drivers/firmware/efi/libstub/string.c as RISC-V does
> not implement architecture-specific versions of those functions.
>
> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
I think a similar change already went into 6.2-rc1 [0],
though it seems to leave strcmp in place in image-vars.h
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=da8dd0c75b3f82eb366eb1745fb473ea92c8c087
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-01-04 15:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 16:21 [PATCH 0/6] RISC-V kasan rework Alexandre Ghiti
2022-12-16 16:21 ` [PATCH 1/6] riscv: Split early and final KASAN population functions Alexandre Ghiti
2022-12-16 16:21 ` [PATCH 2/6] riscv: Rework kasan " Alexandre Ghiti
2022-12-16 16:21 ` [PATCH 3/6] riscv: Move DTB_EARLY_BASE_VA to the kernel address space Alexandre Ghiti
2022-12-16 16:21 ` [PATCH 4/6] riscv: Fix EFI stub usage of KASAN instrumented string functions Alexandre Ghiti
2022-12-21 14:05 ` Conor Dooley
2022-12-21 14:23 ` Alexandre Ghiti
2022-12-21 15:00 ` Conor Dooley
2023-01-04 15:38 ` Heiko Stübner [this message]
2022-12-16 16:21 ` [PATCH 5/6] riscv: Fix ptdump when KASAN is enabled Alexandre Ghiti
2022-12-16 16:21 ` [PATCH 6/6] riscv: Unconditionnally select KASAN_VMALLOC if KASAN Alexandre Ghiti
2022-12-22 22:01 ` [PATCH 0/6] RISC-V kasan rework Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10490920.nUPlyArG6x@diego \
--to=heiko@sntech.de \
--cc=alexghiti@rivosinc.com \
--cc=andreyknvl@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ryabinin.a.a@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox