From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34D55C4167B for ; Mon, 4 Dec 2023 13:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yXc4uSsQd5D+OBB1ZdWlMpNXmIMnAxsIwQ/66qTF/rY=; b=vF8Ihlekylzp8q TTXLuMTJuJS982+25Q8rhrecKaJd2w+HSTQzorYOCP4rB+6eD33gTA0crssrFs4ckHW1qUf9OfhLj CUxKJ7VQgQsPLtkJXikN+n/OZatabP0l/oYR0lqd+foE8ZP2Qv4flBr14LeJ8wv/uayog44QDib4R owTAO7zzHb/sPJlk52dGATzQVsHKbcUZgdy5EALA04GgymsaK3JVt73sCMEPNOfYb4qURrAa9rmcj G7JdIYPcKTKZCWNXL5n74WU+tkiIILbA2UuA/k6H1g4+6MwDcPcEWqt7/6DgXAzwT5KDhY2Hv3hXt 9FB6AVpF6JlDMAGM1xKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA92N-004e6p-1F; Mon, 04 Dec 2023 13:31:03 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rA92K-004e2d-0d for linux-riscv@lists.infradead.org; Mon, 04 Dec 2023 13:31:01 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rA92A-00058F-SP; Mon, 04 Dec 2023 14:30:50 +0100 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rA925-00DWy9-50; Mon, 04 Dec 2023 14:30:45 +0100 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1rA925-000Gqm-0E; Mon, 04 Dec 2023 14:30:45 +0100 Message-ID: <12c6097a723b9208f6da89207867b32102237fbc.camel@pengutronix.de> Subject: Re: [v3 3/6] drm/vs: Register DRM device From: Philipp Zabel To: Keith Zhao , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, krzysztof.kozlowski+dt@linaro.org, william.qiu@starfivetech.com, xingyu.wu@starfivetech.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, palmer@dabbelt.com, shengyang.chen@starfivetech.com, jack.zhu@starfivetech.com, changhuang.liang@starfivetech.com, maarten.lankhorst@linux.intel.com, suijingfeng@loongson.cn Date: Mon, 04 Dec 2023 14:30:44 +0100 In-Reply-To: <20231204123315.28456-4-keith.zhao@starfivetech.com> References: <20231204123315.28456-1-keith.zhao@starfivetech.com> <20231204123315.28456-4-keith.zhao@starfivetech.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-riscv@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_053100_239600_4A3E391C X-CRM114-Status: GOOD ( 20.63 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Keith, On Mo, 2023-12-04 at 20:33 +0800, Keith Zhao wrote: > Implement drm device registration interface > > Signed-off-by: Keith Zhao > --- [...] > diff --git a/drivers/gpu/drm/verisilicon/Kconfig b/drivers/gpu/drm/verisilicon/Kconfig > new file mode 100644 > index 000000000000..e10fa97635aa > --- /dev/null > +++ b/drivers/gpu/drm/verisilicon/Kconfig > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: GPL-2.0 > +config DRM_VERISILICON > + tristate "DRM Support for VeriSilicon" > + depends on DRM > + select DRM_KMS_HELPER > + select DRM_GEM_DMA_HELPER > + select CMA > + select DMA_CMA > + help > + Choose this option if you have a VeriSilicon soc chipset. This seems a bit generic. Doesn't the VeriSilicon display controller IP used on JH7110 have a product name? [...] > diff --git a/drivers/gpu/drm/verisilicon/vs_drv.c b/drivers/gpu/drm/verisilicon/vs_drv.c > new file mode 100644 > index 000000000000..4fb1f29ef84b > --- /dev/null > +++ b/drivers/gpu/drm/verisilicon/vs_drv.c > @@ -0,0 +1,316 @@ > +// SPDX-License-Identifier: GPL-2.0 [...] > +static void vs_drm_device_release_clocks(void *res) > +{ > + struct vs_drm_device *priv = res; > + unsigned int i; > + > + reset_control_bulk_assert(priv->nrsts, priv->rst_vout); > + > + for (i = 0; i < priv->clk_count; ++i) { > + if (priv->clks[i]) { > + clk_disable_unprepare(priv->clks[i]); > + clk_put(priv->clks[i]); > + } > + } Why not use the bulk API for clk as well? [...] > +static int vs_drm_device_init_clocks(struct vs_drm_device *priv) > +{ > + struct drm_device *dev = &priv->base; > + struct platform_device *pdev = to_platform_device(dev->dev); > + struct device_node *of_node = pdev->dev.of_node; > + struct clk *clock; > + unsigned int i; > + int ret; > + > + if (dev_get_platdata(&pdev->dev) || !of_node) > + return 0; > + > + priv->nrsts = ARRAY_SIZE(priv->rst_vout); > + for (int i = 0; i < priv->nrsts; ++i) > + priv->rst_vout[i].id = vout_resets[i]; > + ret = devm_reset_control_bulk_get_shared(dev->dev, priv->nrsts, > + priv->rst_vout); I would request resets and clocks in _probe(). If component_bind_all() returns -EPROBE_DEFER because of a still missing DSI panel backlight or similar, this doesn't have to be done multiple times. > + if (ret) { > + drm_err(dev, "Failed to get reset controls\n"); > + return ret; > + } > + > + priv->clk_count = of_clk_get_parent_count(of_node); > + if (!priv->clk_count) > + return 0; > + > + priv->clks = drmm_kzalloc(dev, priv->clk_count * sizeof(priv->clks[0]), > + GFP_KERNEL); > + if (!priv->clks) > + return -ENOMEM; > + > + for (i = 0; i < priv->clk_count; ++i) { > + clock = of_clk_get(of_node, i); > + if (IS_ERR(clock)) { > + ret = PTR_ERR(clock); > + if (ret == -EPROBE_DEFER) > + goto err; > + drm_err(dev, "clock %u not found: %d\n", i, ret); > + continue; > + } > + ret = clk_prepare_enable(clock); > + if (ret) { > + drm_err(dev, "failed to enable clock %u: %d\n", > + i, ret); > + clk_put(clock); > + continue; > + } > + priv->clks[i] = clock; > + } > + > + ret = reset_control_bulk_deassert(priv->nrsts, priv->rst_vout); > + if (ret) > + return ret; This should goto err, otherwise clocks are left enabled. > + > + return devm_add_action_or_reset(&pdev->dev, > + vs_drm_device_release_clocks, > + priv); > + > +err: > + while (i) { > + --i; > + if (priv->clks[i]) { > + clk_disable_unprepare(priv->clks[i]); > + clk_put(priv->clks[i]); > + } > + } > + return ret; > +} > + > +static int vs_drm_bind(struct device *dev) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + struct vs_drm_device *priv; > + int ret; > + struct drm_device *drm_dev; > + > + /* Remove existing drivers that may own the framebuffer memory. */ > + ret = drm_aperture_remove_framebuffers(&vs_drm_driver); > + if (ret) > + return ret; > + > + priv = devm_drm_dev_alloc(dev, &vs_drm_driver, struct vs_drm_device, base); > + if (IS_ERR(priv)) > + return PTR_ERR(priv); > + > + priv->pitch_alignment = 64; Why is this a variable instead of a constant? > + ret = dma_set_coherent_mask(priv->base.dev, DMA_BIT_MASK(40)); > + if (ret) > + return ret; > + > + drm_dev = &priv->base; > + platform_set_drvdata(pdev, drm_dev); > + > + ret = vs_drm_device_init_clocks(priv); > + if (ret) > + return ret; > + > + vs_mode_config_init(drm_dev); > + > + /* Now try and bind all our sub-components */ > + ret = component_bind_all(dev, drm_dev); > + if (ret) > + return ret; > + > + ret = drm_vblank_init(drm_dev, drm_dev->mode_config.num_crtc); > + if (ret) > + return ret; Missing component_unbind_all(), see below. > + > + drm_mode_config_reset(drm_dev); > + > + drm_kms_helper_poll_init(drm_dev); > + > + ret = drm_dev_register(drm_dev, 0); > + if (ret) > + return ret; Missing drm_kms_helper_poll_fini(), see below. > + > + drm_fbdev_generic_setup(drm_dev, 32); > + > + return 0; Here I'd expect an error path calling drm_kms_helper_poll_fini() and component_unbind_all() as appropriate. regards Philipp _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv