From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Zong Li <zong.li@sifive.com>,
robh+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, conor.dooley@microchip.com,
geert@linux-m68k.org, bin.meng@windriver.com,
green.wan@sifive.com, vkoul@kernel.org,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Cc: Palmer Dabbelt <palmer@rivosinc.com>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v6 1/3] dt-bindings: Add dma-channels property and modify compatible
Date: Fri, 4 Mar 2022 10:09:10 +0100 [thread overview]
Message-ID: <1664de3d-8e33-596e-19ff-4fb174f2a178@canonical.com> (raw)
In-Reply-To: <12cff3b68de1bd02a8915bd70999bb4edafaca1b.1646383150.git.zong.li@sifive.com>
On 04/03/2022 09:42, Zong Li wrote:
> Add dma-channels property, then we can determine how many channels there
> by device tree, rather than statically defining it in PDMA driver.
> In addition, we also modify the compatible for PDMA versioning scheme.
>
> Signed-off-by: Zong Li <zong.li@sifive.com>
> Suggested-by: Palmer Dabbelt <palmer@rivosinc.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> .../bindings/dma/sifive,fu540-c000-pdma.yaml | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
Can you add subystem/driver prefix to the subject? In current form it
looks generic, but it is actually specific, so:
dt-bindings: dma-engine: sifive,fu540:
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-03-04 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 8:42 [PATCH v6 0/3] Determine the number of DMA channels by 'dma-channels' property Zong Li
2022-03-04 8:42 ` [PATCH v6 1/3] dt-bindings: Add dma-channels property and modify compatible Zong Li
2022-03-04 9:09 ` Krzysztof Kozlowski [this message]
2022-03-04 10:06 ` Zong Li
2022-03-04 8:42 ` [PATCH v6 2/3] riscv: dts: " Zong Li
2022-03-04 8:42 ` [PATCH v6 3/3] dmaengine: sf-pdma: Get number of channel by device tree Zong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1664de3d-8e33-596e-19ff-4fb174f2a178@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=aou@eecs.berkeley.edu \
--cc=bin.meng@windriver.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=green.wan@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox