public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v1 0/2] RISC-V: Fixes for riscv_has_extension[un]likely()'s alternative dependency
@ 2023-03-24 10:05 Conor Dooley
  2023-03-24 10:05 ` [PATCH v1 1/2] RISC-V: add non-alternative fallback for riscv_has_extension_[un]likely() Conor Dooley
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Conor Dooley @ 2023-03-24 10:05 UTC (permalink / raw)
  To: palmer
  Cc: conor, conor.dooley, Paul Walmsley, Heiko Stuebner, Andrew Jones,
	Anup Patel, Jisheng Zhang, Jason A . Donenfeld, linux-riscv,
	linux-kernel

Here's my attempt at fixing both the use of an FPU on XIP kernels and
the issue that Jason ran into where CONFIG_FPU, which needs the
alternatives frame work for has_fpu() checks, could be enabled without
the alternatives actually being present.

For the former, a "slow" fallback that does not use alternatives is
added to riscv_has_extension_[un]likely() that can be used with XIP.
Obviously, we want to make use of Jisheng's alternatives based approach
where possible, so any users of riscv_has_extension_[un]likely() will
want to make sure that they select RISCV_ALTERNATIVE.
If they don't however, they'll hit the fallback path which (should,
sparing a silly mistake from me!) behave in the same way, thus
succeeding silently. Sounds like a

To prevent "depends on !XIP_KERNEL; select RISCV_ALTERNATIVE" spreading
like the plague through the various places that want to check for the
presence of extensions, and sidestep the potential silent "success"
mentioned above, all users RISCV_ALTERNATIVE are converted from selects
to dependencies, with the option being selected for all !XIP_KERNEL
builds.

I know that the VDSO was a key place that Jisheng wanted to use the new
helper rather than static branches, and I think the fallback path
should not cause issues there.

See the thread at [1] for the prior discussion.

Cheers,
Conor.

1 - https://lore.kernel.org/linux-riscv/20230128172856.3814-1-jszhang@kernel.org/T/#m21390d570997145d31dd8bb95002fd61f99c6573

CC: Paul Walmsley <paul.walmsley@sifive.com>
CC: Palmer Dabbelt <palmer@dabbelt.com>
CC: Conor Dooley <conor.dooley@microchip.com>
CC: Heiko Stuebner <heiko.stuebner@vrull.eu>
CC: Andrew Jones <ajones@ventanamicro.com>
CC: Anup Patel <apatel@ventanamicro.com>
CC: Jisheng Zhang <jszhang@kernel.org>
CC: Andrew Jones <ajones@ventanamicro.com>
CC: Jason A. Donenfeld <Jason@zx2c4.com>
CC: linux-riscv@lists.infradead.org
CC: linux-kernel@vger.kernel.org

Conor Dooley (2):
  RISC-V: add non-alternative fallback for
    riscv_has_extension_[un]likely()
  RISC-V: always select RISCV_ALTERNATIVE for non-xip kernels

 arch/riscv/Kconfig             | 12 ++++----
 arch/riscv/Kconfig.erratas     |  6 ++--
 arch/riscv/include/asm/hwcap.h | 50 ++++++++++++++++++++--------------
 3 files changed, 38 insertions(+), 30 deletions(-)

-- 
2.39.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-03-30 21:10 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-24 10:05 [PATCH v1 0/2] RISC-V: Fixes for riscv_has_extension[un]likely()'s alternative dependency Conor Dooley
2023-03-24 10:05 ` [PATCH v1 1/2] RISC-V: add non-alternative fallback for riscv_has_extension_[un]likely() Conor Dooley
2023-03-24 10:05 ` [PATCH v1 2/2] RISC-V: always select RISCV_ALTERNATIVE for non-xip kernels Conor Dooley
2023-03-24 11:31 ` [PATCH v1 0/2] RISC-V: Fixes for riscv_has_extension[un]likely()'s alternative dependency Andrew Jones
2023-03-24 11:37   ` Conor Dooley
2023-03-24 11:43     ` Andrew Jones
2023-03-24 13:20 ` Jason A. Donenfeld
2023-03-30 21:02 ` Palmer Dabbelt
2023-03-30 21:10 ` patchwork-bot+linux-riscv

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox