From: patchwork-bot+linux-riscv@kernel.org
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: linux-riscv@lists.infradead.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu, nathan@kernel.org,
trix@redhat.com, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, lkp@intel.com
Subject: Re: [PATCH v2] riscv: mm: fix 2 instances of -Wmissing-variable-declarations
Date: Wed, 09 Aug 2023 14:40:21 +0000 [thread overview]
Message-ID: <169159202114.17533.15862327157630311285.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230808-riscv_static-v2-1-2a1e2d2c7a4f@google.com>
Hello:
This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Tue, 08 Aug 2023 09:35:00 -0700 you wrote:
> I'm looking to enable -Wmissing-variable-declarations behind W=1. 0day
> bot spotted the following instance in ARCH=riscv builds:
>
> arch/riscv/mm/init.c:276:7: warning: no previous extern declaration
> for non-static variable 'trampoline_pg_dir'
> [-Wmissing-variable-declarations]
> 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
> | ^
> arch/riscv/mm/init.c:276:1: note: declare 'static' if the variable is
> not intended to be used outside of this translation unit
> 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
> | ^
> arch/riscv/mm/init.c:279:7: warning: no previous extern declaration
> for non-static variable 'early_pg_dir'
> [-Wmissing-variable-declarations]
> 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE);
> | ^
> arch/riscv/mm/init.c:279:1: note: declare 'static' if the variable is
> not intended to be used outside of this translation unit
> 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE);
> | ^
>
> [...]
Here is the summary with links:
- [v2] riscv: mm: fix 2 instances of -Wmissing-variable-declarations
https://git.kernel.org/riscv/c/d2402048bc8a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-08-09 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 16:35 [PATCH v2] riscv: mm: fix 2 instances of -Wmissing-variable-declarations Nick Desaulniers
2023-08-09 14:40 ` patchwork-bot+linux-riscv [this message]
2023-08-10 19:44 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169159202114.17533.15862327157630311285.git-patchwork-notify@kernel.org \
--to=patchwork-bot+linux-riscv@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox