* Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
2023-09-01 11:03 [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config Prabhakar
@ 2023-09-01 11:47 ` Geert Uytterhoeven
2023-09-01 20:27 ` Randy Dunlap
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2023-09-01 11:47 UTC (permalink / raw)
To: Prabhakar
Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Conor Dooley,
Geert Uytterhoeven, linux-riscv, linux-kernel, Lad Prabhakar,
kernel test robot
On Fri, Sep 1, 2023 at 1:03 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
> enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
> avoid any build failures.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
2023-09-01 11:03 [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config Prabhakar
2023-09-01 11:47 ` Geert Uytterhoeven
@ 2023-09-01 20:27 ` Randy Dunlap
2023-09-01 21:12 ` Lad, Prabhakar
2023-09-02 8:20 ` Conor Dooley
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2023-09-01 20:27 UTC (permalink / raw)
To: Prabhakar, Paul Walmsley, Palmer Dabbelt, Albert Ou, Conor Dooley,
Geert Uytterhoeven, linux-riscv
Cc: linux-kernel, Lad Prabhakar, kernel test robot
Hi,
On 9/1/23 04:03, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
> enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
> avoid any build failures.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> arch/riscv/Kconfig.errata | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
> index bee5d838763b..566bcefeab50 100644
> --- a/arch/riscv/Kconfig.errata
> +++ b/arch/riscv/Kconfig.errata
> @@ -2,7 +2,7 @@ menu "CPU errata selection"
>
> config ERRATA_ANDES
> bool "Andes AX45MP errata"
> - depends on RISCV_ALTERNATIVE
> + depends on RISCV_ALTERNATIVE && RISCV_SBI
> help
> All Andes errata Kconfig depend on this Kconfig. Disabling
> this Kconfig will disable all Andes errata. Please say "Y"
I'm still seeing build warnings/errors after applying all 3 RISC-V
Kconfig patches from today (2023 SEP 01).
WARNING: unmet direct dependencies detected for ERRATA_ANDES
Depends on [n]: RISCV_ALTERNATIVE [=y] && RISCV_SBI [=n]
Selected by [y]:
- ARCH_R9A07G043 [=y] && SOC_RENESAS [=y] && RISCV [=y]
../arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_sw_workaround':
../arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known
29 | struct sbiret ret;
| ^~~
../arch/riscv/errata/andes/errata.c:35:15: error: implicit declaration of function 'sbi_ecall' [-Werror=implicit-function-declaration]
35 | ret = sbi_ecall(ANDESTECH_SBI_EXT_ANDES, ANDES_SBI_EXT_IOCP_SW_WORKAROUND,
| ^~~~~~~~~
../arch/riscv/errata/andes/errata.c:29:23: warning: unused variable 'ret' [-Wunused-variable]
29 | struct sbiret ret;
| ^~~
ARCH_R9A07G043 in drivers/soc/renesas/Kconfig selects ERRATA_ANDES and
ERRATA_ANDES_CMO even though RISCV_SBI is not set/enabled.
--
~Randy
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
2023-09-01 20:27 ` Randy Dunlap
@ 2023-09-01 21:12 ` Lad, Prabhakar
2023-09-02 0:47 ` Randy Dunlap
0 siblings, 1 reply; 9+ messages in thread
From: Lad, Prabhakar @ 2023-09-01 21:12 UTC (permalink / raw)
To: Randy Dunlap
Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Conor Dooley,
Geert Uytterhoeven, linux-riscv, linux-kernel, Lad Prabhakar,
kernel test robot
Hi Randy,
On Fri, Sep 1, 2023 at 9:27 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi,
>
> On 9/1/23 04:03, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
> > enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
> > avoid any build failures.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > arch/riscv/Kconfig.errata | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
> > index bee5d838763b..566bcefeab50 100644
> > --- a/arch/riscv/Kconfig.errata
> > +++ b/arch/riscv/Kconfig.errata
> > @@ -2,7 +2,7 @@ menu "CPU errata selection"
> >
> > config ERRATA_ANDES
> > bool "Andes AX45MP errata"
> > - depends on RISCV_ALTERNATIVE
> > + depends on RISCV_ALTERNATIVE && RISCV_SBI
> > help
> > All Andes errata Kconfig depend on this Kconfig. Disabling
> > this Kconfig will disable all Andes errata. Please say "Y"
>
>
> I'm still seeing build warnings/errors after applying all 3 RISC-V
> Kconfig patches from today (2023 SEP 01).
>
> WARNING: unmet direct dependencies detected for ERRATA_ANDES
> Depends on [n]: RISCV_ALTERNATIVE [=y] && RISCV_SBI [=n]
> Selected by [y]:
> - ARCH_R9A07G043 [=y] && SOC_RENESAS [=y] && RISCV [=y]
>
> ../arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_sw_workaround':
> ../arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known
> 29 | struct sbiret ret;
> | ^~~
> ../arch/riscv/errata/andes/errata.c:35:15: error: implicit declaration of function 'sbi_ecall' [-Werror=implicit-function-declaration]
> 35 | ret = sbi_ecall(ANDESTECH_SBI_EXT_ANDES, ANDES_SBI_EXT_IOCP_SW_WORKAROUND,
> | ^~~~~~~~~
> ../arch/riscv/errata/andes/errata.c:29:23: warning: unused variable 'ret' [-Wunused-variable]
> 29 | struct sbiret ret;
> | ^~~
>
> ARCH_R9A07G043 in drivers/soc/renesas/Kconfig selects ERRATA_ANDES and
> ERRATA_ANDES_CMO even though RISCV_SBI is not set/enabled.
>
You need to apply patch [1] aswell.
[1] https://patchwork.kernel.org/project/linux-riscv/patch/20230901110936.313171-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
Cheers,
Prabhakar
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
2023-09-01 21:12 ` Lad, Prabhakar
@ 2023-09-02 0:47 ` Randy Dunlap
0 siblings, 0 replies; 9+ messages in thread
From: Randy Dunlap @ 2023-09-02 0:47 UTC (permalink / raw)
To: Lad, Prabhakar
Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Conor Dooley,
Geert Uytterhoeven, linux-riscv, linux-kernel, Lad Prabhakar,
kernel test robot
Hi,
Thanks for your help.
On 9/1/23 14:12, Lad, Prabhakar wrote:
> Hi Randy,
>
> On Fri, Sep 1, 2023 at 9:27 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> Hi,
>>
>> On 9/1/23 04:03, Prabhakar wrote:
>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>
>>> Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
>>> enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
>>> avoid any build failures.
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>> ---
>>> arch/riscv/Kconfig.errata | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
>>> index bee5d838763b..566bcefeab50 100644
>>> --- a/arch/riscv/Kconfig.errata
>>> +++ b/arch/riscv/Kconfig.errata
>>> @@ -2,7 +2,7 @@ menu "CPU errata selection"
>>>
>>> config ERRATA_ANDES
>>> bool "Andes AX45MP errata"
>>> - depends on RISCV_ALTERNATIVE
>>> + depends on RISCV_ALTERNATIVE && RISCV_SBI
>>> help
>>> All Andes errata Kconfig depend on this Kconfig. Disabling
>>> this Kconfig will disable all Andes errata. Please say "Y"
>>
>>
>> I'm still seeing build warnings/errors after applying all 3 RISC-V
>> Kconfig patches from today (2023 SEP 01).
>>
>> WARNING: unmet direct dependencies detected for ERRATA_ANDES
>> Depends on [n]: RISCV_ALTERNATIVE [=y] && RISCV_SBI [=n]
>> Selected by [y]:
>> - ARCH_R9A07G043 [=y] && SOC_RENESAS [=y] && RISCV [=y]
>>
>> ../arch/riscv/errata/andes/errata.c: In function 'ax45mp_iocp_sw_workaround':
>> ../arch/riscv/errata/andes/errata.c:29:23: error: storage size of 'ret' isn't known
>> 29 | struct sbiret ret;
>> | ^~~
>> ../arch/riscv/errata/andes/errata.c:35:15: error: implicit declaration of function 'sbi_ecall' [-Werror=implicit-function-declaration]
>> 35 | ret = sbi_ecall(ANDESTECH_SBI_EXT_ANDES, ANDES_SBI_EXT_IOCP_SW_WORKAROUND,
>> | ^~~~~~~~~
>> ../arch/riscv/errata/andes/errata.c:29:23: warning: unused variable 'ret' [-Wunused-variable]
>> 29 | struct sbiret ret;
>> | ^~~
>>
>> ARCH_R9A07G043 in drivers/soc/renesas/Kconfig selects ERRATA_ANDES and
>> ERRATA_ANDES_CMO even though RISCV_SBI is not set/enabled.
>>
>
> You need to apply patch [1] aswell.
>
> [1] https://patchwork.kernel.org/project/linux-riscv/patch/20230901110936.313171-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
I tested the failing builds that I had - after applying all 4 patches only,
not each patch separately.
If that is satisfactory, you can add
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
--
~Randy
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
2023-09-01 11:03 [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config Prabhakar
2023-09-01 11:47 ` Geert Uytterhoeven
2023-09-01 20:27 ` Randy Dunlap
@ 2023-09-02 8:20 ` Conor Dooley
2023-09-02 11:02 ` Conor Dooley
2023-09-06 2:50 ` patchwork-bot+linux-riscv
4 siblings, 0 replies; 9+ messages in thread
From: Conor Dooley @ 2023-09-02 8:20 UTC (permalink / raw)
To: linux-riscv
On 1 September 2023 12:03:20 IST, Prabhakar <prabhakar.csengg@gmail.com> wrote:
>From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
>Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
>enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
>avoid any build failures.
>
>Reported-by: kernel test robot <lkp@intel.com>
>Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
>Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
This one needs to grow the same fixes tag.
Ideally the whole lot of kconfig bits would be in a series IMO.
>---
> arch/riscv/Kconfig.errata | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
>index bee5d838763b..566bcefeab50 100644
>--- a/arch/riscv/Kconfig.errata
>+++ b/arch/riscv/Kconfig.errata
>@@ -2,7 +2,7 @@ menu "CPU errata selection"
>
> config ERRATA_ANDES
> bool "Andes AX45MP errata"
>- depends on RISCV_ALTERNATIVE
>+ depends on RISCV_ALTERNATIVE && RISCV_SBI
> help
> All Andes errata Kconfig depend on this Kconfig. Disabling
> this Kconfig will disable all Andes errata. Please say "Y"
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
2023-09-01 11:03 [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config Prabhakar
` (2 preceding siblings ...)
2023-09-02 8:20 ` Conor Dooley
@ 2023-09-02 11:02 ` Conor Dooley
2023-09-05 7:52 ` Lad, Prabhakar
2023-09-06 2:50 ` patchwork-bot+linux-riscv
4 siblings, 1 reply; 9+ messages in thread
From: Conor Dooley @ 2023-09-02 11:02 UTC (permalink / raw)
To: Prabhakar
Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Conor Dooley,
Geert Uytterhoeven, linux-riscv, linux-kernel, Lad Prabhakar,
kernel test robot
[-- Attachment #1.1: Type: text/plain, Size: 1711 bytes --]
On Fri, Sep 01, 2023 at 12:03:20PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
> enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
> avoid any build failures.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Replied here earlier, but pressed the wrong key & it only went to the
list.
I think this patch probably also needs to grow a Fixes tag, for
commit f2863f30d1b0 ("riscv: errata: Add Andes alternative ports").
The 4 Kconfig patches ideally would've been in a series, since 3 of the
4 seem to be fixes & the 4th depends on one of the fixes being applied.
Thaks,
Conor.
> ---
> arch/riscv/Kconfig.errata | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
> index bee5d838763b..566bcefeab50 100644
> --- a/arch/riscv/Kconfig.errata
> +++ b/arch/riscv/Kconfig.errata
> @@ -2,7 +2,7 @@ menu "CPU errata selection"
>
> config ERRATA_ANDES
> bool "Andes AX45MP errata"
> - depends on RISCV_ALTERNATIVE
> + depends on RISCV_ALTERNATIVE && RISCV_SBI
> help
> All Andes errata Kconfig depend on this Kconfig. Disabling
> this Kconfig will disable all Andes errata. Please say "Y"
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
2023-09-02 11:02 ` Conor Dooley
@ 2023-09-05 7:52 ` Lad, Prabhakar
0 siblings, 0 replies; 9+ messages in thread
From: Lad, Prabhakar @ 2023-09-05 7:52 UTC (permalink / raw)
To: Conor Dooley
Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Conor Dooley,
Geert Uytterhoeven, linux-riscv, linux-kernel, Lad Prabhakar,
kernel test robot
Hi Conor,
On Sat, Sep 2, 2023 at 12:02 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Fri, Sep 01, 2023 at 12:03:20PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
> > enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
> > avoid any build failures.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Replied here earlier, but pressed the wrong key & it only went to the
> list.
> I think this patch probably also needs to grow a Fixes tag, for
> commit f2863f30d1b0 ("riscv: errata: Add Andes alternative ports").
>
> The 4 Kconfig patches ideally would've been in a series, since 3 of the
> 4 seem to be fixes & the 4th depends on one of the fixes being applied.
>
My bad I should i've posted them as a series.
Cheers,
Prabhakar
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
2023-09-01 11:03 [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config Prabhakar
` (3 preceding siblings ...)
2023-09-02 11:02 ` Conor Dooley
@ 2023-09-06 2:50 ` patchwork-bot+linux-riscv
4 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+linux-riscv @ 2023-09-06 2:50 UTC (permalink / raw)
To: Prabhakar
Cc: linux-riscv, paul.walmsley, palmer, aou, conor.dooley,
geert+renesas, linux-kernel, prabhakar.mahadev-lad.rj, lkp
Hello:
This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Fri, 1 Sep 2023 12:03:20 +0100 you wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
> enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
> avoid any build failures.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> [...]
Here is the summary with links:
- riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config
https://git.kernel.org/riscv/c/005846ea7265
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread