public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH --fixes] riscv: Remove SHADOW_OVERFLOW_STACK_SIZE macro
@ 2023-12-11 11:03 Song Shuai
  2023-12-11 17:34 ` Sami Tolvanen
  2024-01-11 14:50 ` patchwork-bot+linux-riscv
  0 siblings, 2 replies; 3+ messages in thread
From: Song Shuai @ 2023-12-11 11:03 UTC (permalink / raw)
  To: paul.walmsley, palmer, aou, guoren, samitolvanen, conor.dooley,
	bjorn, debug, songshuaishuai, greentime.hu
  Cc: linux-riscv, linux-kernel

The commit be97d0db5f44 ("riscv: VMAP_STACK overflow
detection thread-safe") got rid of `shadow_stack`,
so SHADOW_OVERFLOW_STACK_SIZE should be removed too.

Fixes: be97d0db5f44 ("riscv: VMAP_STACK overflow detection thread-safe")
Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
---
 arch/riscv/include/asm/thread_info.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/include/asm/thread_info.h b/arch/riscv/include/asm/thread_info.h
index 574779900bfb..4856697c5f25 100644
--- a/arch/riscv/include/asm/thread_info.h
+++ b/arch/riscv/include/asm/thread_info.h
@@ -28,7 +28,6 @@
 
 #define THREAD_SHIFT            (PAGE_SHIFT + THREAD_SIZE_ORDER)
 #define OVERFLOW_STACK_SIZE     SZ_4K
-#define SHADOW_OVERFLOW_STACK_SIZE (1024)
 
 #define IRQ_STACK_SIZE		THREAD_SIZE
 
-- 
2.20.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH --fixes] riscv: Remove SHADOW_OVERFLOW_STACK_SIZE macro
  2023-12-11 11:03 [PATCH --fixes] riscv: Remove SHADOW_OVERFLOW_STACK_SIZE macro Song Shuai
@ 2023-12-11 17:34 ` Sami Tolvanen
  2024-01-11 14:50 ` patchwork-bot+linux-riscv
  1 sibling, 0 replies; 3+ messages in thread
From: Sami Tolvanen @ 2023-12-11 17:34 UTC (permalink / raw)
  To: Song Shuai
  Cc: paul.walmsley, palmer, aou, guoren, conor.dooley, bjorn, debug,
	greentime.hu, linux-riscv, linux-kernel

Hi,

On Mon, Dec 11, 2023 at 3:04 AM Song Shuai <songshuaishuai@tinylab.org> wrote:
>
> The commit be97d0db5f44 ("riscv: VMAP_STACK overflow
> detection thread-safe") got rid of `shadow_stack`,
> so SHADOW_OVERFLOW_STACK_SIZE should be removed too.
>
> Fixes: be97d0db5f44 ("riscv: VMAP_STACK overflow detection thread-safe")
> Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
> ---
>  arch/riscv/include/asm/thread_info.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/include/asm/thread_info.h b/arch/riscv/include/asm/thread_info.h
> index 574779900bfb..4856697c5f25 100644
> --- a/arch/riscv/include/asm/thread_info.h
> +++ b/arch/riscv/include/asm/thread_info.h
> @@ -28,7 +28,6 @@
>
>  #define THREAD_SHIFT            (PAGE_SHIFT + THREAD_SIZE_ORDER)
>  #define OVERFLOW_STACK_SIZE     SZ_4K
> -#define SHADOW_OVERFLOW_STACK_SIZE (1024)
>
>  #define IRQ_STACK_SIZE         THREAD_SIZE

Ah, good catch. Thanks for the patch!

Reviewed-by: Sami Tolvanen <samitolvanen@google.com>

Sami

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH --fixes] riscv: Remove SHADOW_OVERFLOW_STACK_SIZE macro
  2023-12-11 11:03 [PATCH --fixes] riscv: Remove SHADOW_OVERFLOW_STACK_SIZE macro Song Shuai
  2023-12-11 17:34 ` Sami Tolvanen
@ 2024-01-11 14:50 ` patchwork-bot+linux-riscv
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-riscv @ 2024-01-11 14:50 UTC (permalink / raw)
  To: Song Shuai
  Cc: linux-riscv, paul.walmsley, palmer, aou, guoren, samitolvanen,
	conor.dooley, bjorn, debug, greentime.hu, linux-kernel

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Mon, 11 Dec 2023 19:03:31 +0800 you wrote:
> The commit be97d0db5f44 ("riscv: VMAP_STACK overflow
> detection thread-safe") got rid of `shadow_stack`,
> so SHADOW_OVERFLOW_STACK_SIZE should be removed too.
> 
> Fixes: be97d0db5f44 ("riscv: VMAP_STACK overflow detection thread-safe")
> Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
> 
> [...]

Here is the summary with links:
  - [--fixes] riscv: Remove SHADOW_OVERFLOW_STACK_SIZE macro
    https://git.kernel.org/riscv/c/a7565f4d068b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-11 14:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-11 11:03 [PATCH --fixes] riscv: Remove SHADOW_OVERFLOW_STACK_SIZE macro Song Shuai
2023-12-11 17:34 ` Sami Tolvanen
2024-01-11 14:50 ` patchwork-bot+linux-riscv

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox