Re: [PATCH 02/13] dt-bindings: thead: add a vlen register length property

From: "Rob Herring (Arm)" <robh@kernel.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	linux-riscv@lists.infradead.org,
	 Jisheng Zhang <jszhang@kernel.org>,
	linux-kselftest@vger.kernel.org,
	 Samuel Holland <samuel@sholland.org>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	Jonathan Corbet <corbet@lwn.net>,
	 Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor@kernel.org>,
	 linux-kernel@vger.kernel.org, Andy Chiu <andy.chiu@sifive.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,  Shuah Khan <shuah@kernel.org>,
	linux-sunxi@lists.linux.dev,  devicetree@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	 Evan Green <evan@rivosinc.com>,
	linux-doc@vger.kernel.org,  Guo Ren <guoren@kernel.org>
Subject: Re: [PATCH 02/13] dt-bindings: thead: add a vlen register length property
Date: Mon, 10 Jun 2024 00:27:09 -0600	[thread overview]
Message-ID: <171800082930.1000302.5109301877296329341.robh@kernel.org> (raw)
In-Reply-To: <20240609-xtheadvector-v1-2-3fe591d7f109@rivosinc.com>

On Sun, 09 Jun 2024 21:45:07 -0700, Charlie Jenkins wrote:
> Add a property analogous to the vlenb CSR so that software can detect
> the vector length of each CPU prior to it being brought online.
> Currently software has to assume that the vector length read from the
> boot CPU applies to all possible CPUs. On T-Head CPUs implementing
> pre-ratification vector, reading the th.vlenb CSR may produce an illegal
> instruction trap, so this property is required on such systems.
> 
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> ---
>  Documentation/devicetree/bindings/riscv/thead.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/thead.yaml: 'thead,vlenb' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240609-xtheadvector-v1-2-3fe591d7f109@rivosinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv