Re: [PATCH v1] RISC-V: disallow gcc + rust builds

Alexandre Ghiti
2024-10-09T09:45:51Z

On 09/10/2024 10:23, Conor Dooley wrote:
> On Wed, Oct 09, 2024 at 10:10:14AM +0200, Alexandre Ghiti wrote:
>
>>>> , it is better
>>>> to disable gcc + rust builds to match the original intent, and
>>>> subsequently support it when an appropriate set of extensions can be
>>>> deduced from the version of libclang.
>>>>
>>>> Closes:
>>>> https://lore.kernel.org/all/20240917000848.720765-2-jmontleo@redhat.com/
>>>> [1]
>>>> Link:
>>>> https://lore.kernel.org/all/20240926-battering-revolt-6c6a7827413e@spud/
>>>> [2]
>>>> Fixes: 70a57b247251a ("RISC-V: enable building 64-bit kernels with
>>>> rust support")
>>
>> I also fixed the Fixes tag ^, it contains 13 characters instead of 12 and
>> added a cc: stable tag.
> FYI, checkpatch is not an arbiter of truth, and I intentionally left the
> 13th character that git determined it needed to have there. Apparently
> the kernel now has enough objects that there can be 12 character
> collisions.

Ok, thanks for the explanation: do checkpatch and the documentation need
to be updated then? Is that a known issue?

From https://docs.kernel.org/process/submitting-patches.html:

"If your patch fixes a bug in a specific commit, e.g. you found an issue
using git bisect, please use the ‘Fixes:’ tag with the first 12
characters of the SHA-1 ID, and the one line summary."

>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv