Re: [RESEND PATCH] mm: Move set_pxd_safe() helpers from generic to platform

David Hildenbrand
2024-10-04T07:55:54Z

On 03.10.24 16:09, Dave Hansen wrote:
> On 10/2/24 21:48, Anshuman Khandual wrote:
>> set_pxd_safe() helpers that serve a specific purpose for both x86 and riscv
>> platforms, do not need to be in the common memory code. Otherwise they just
>> unnecessarily make the common API more complicated. This moves the helpers
>> from common code to platform instead.
>
> I looked into the x86 side a bit. I'm pretty sure we can just remove
> the _safe variants. All they do is spew warnings that don't seem to be
> doing any good. They're not really safer in any meaningful way.

Yes, one reason I am happy that we are removing them from core code :)

>
> I've got a series cooked up to zap them, but I need to get some eyeballs
> on it.

Feel free to CC me. If you're busy, let me know and I might have someone
to tackle this.

Acked-by: David Hildenbrand <david@redhat.com>

--
Cheers,

David / dhildenb