Re: [PATCH v4 12/18] dt-bindings: gpu: Add support for T-HEAD TH1520 GPU

From: "Rob Herring (Arm)" <robh@kernel.org>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: guoren@kernel.org, krzk+dt@kernel.org, aou@eecs.berkeley.edu,
	 airlied@gmail.com, wefu@redhat.com, ulf.hansson@linaro.org,
	 jszhang@kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, jassisinghbrar@gmail.com,
	 linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 linux-clk@vger.kernel.org, palmer@dabbelt.com,
	 maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	 mturquette@baylibre.com, p.zabel@pengutronix.de,
	m.szyprowski@samsung.com,  linux-riscv@lists.infradead.org,
	simona@ffwll.ch, drew@pdp7.com,  frank.binns@imgtec.com,
	conor+dt@kernel.org, tzimmermann@suse.de,  sboyd@kernel.org,
	paul.walmsley@sifive.com, matt.coster@imgtec.com
Subject: Re: [PATCH v4 12/18] dt-bindings: gpu: Add support for T-HEAD TH1520 GPU
Date: Tue, 28 Jan 2025 19:42:17 -0600	[thread overview]
Message-ID: <173811493702.543459.14627465568650161345.robh@kernel.org> (raw)
In-Reply-To: <20250128194816.2185326-13-m.wilczynski@samsung.com>

On Tue, 28 Jan 2025 20:48:10 +0100, Michal Wilczynski wrote:
> Add bindings for the PowerVR BXM-4-64 GPU integrated in the T-HEAD
> TH1520 SoC.  This GPU requires two clocks.
> 
> Document the integration details including clock, reset, power domain
> and interrupt assignments. Add a dt-bindings example showing the proper
> usage of the compatible string "thead,th1520-gpu" along with
> "img,img-bxm".
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> ---
>  .../bindings/gpu/img,powervr-rogue.yaml       | 39 +++++++++++++++++--
>  1 file changed, 35 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/gpu/img,powervr-rogue.example.dts:46.28-29 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/gpu/img,powervr-rogue.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250128194816.2185326-13-m.wilczynski@samsung.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv