From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E63FDC0219B for ; Mon, 10 Feb 2025 16:28:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:References: In-Reply-To:To:Cc:From:MIME-Version:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=WV1x9eizc5X6QEVTJT5axdFw26TBWH62GdpNmeAXbUA=; b=ITsavJ/j9GQLXaICa5u0S0ALgo 4YO9BzQVKs5E8cYjmlGE7/c82YJUrhd//QZx5VdYqhMTl/fKe76m+XsA5GUF0U7UjibhIFZZnHjgj nlChJ4R1vC02ObJSk/zrtW21DqjssZKKUR3gkiOM/vdNiIlWYsV0pByD/eZGJOzbJ9IhLLDyTirpu BdZ4vlRINyECfanSMiM9pffqEsb/R3WDqnQU7rNJadgabVFTGPvrSt+6cfnGoK8TZgaszU7nUcX1l pWg39R9ZAA7LbdK4yskFrqJg8jLAWDemhumOeycoOEgwsPM4al/ke+roCwf8jWEJXVC0iiu6qqoGV DxhQgTIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thWdz-00000000W53-390x; Mon, 10 Feb 2025 16:28:23 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thWYY-00000000Uqd-2eXQ; Mon, 10 Feb 2025 16:22:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 567F8A41970; Mon, 10 Feb 2025 16:21:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84FC0C4CEE6; Mon, 10 Feb 2025 16:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739204565; bh=5pue0C/bvY7Bi4z8DCyV8fK5Y7JUy3U4ZkaQjuaNTCw=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=Q7kOpbmSvyikwdl0vxdtsvwh3aPlVJKtOKvBumplA6jZU96aNqOf/2VNQRZsxcpFi ivVRzLV+1fHR4GZ6yjJTQ9kSmhPHXHVPO7pEtbVEHdRPfwKNARwrG6CSzsdYEIipY5 Z/Usfk1EIFx408e+8pO5fTi91IkqEvYYgHCDLz77yy4G6Ut0EW5i3F0gM6CRbHbxby Wtk8O7BufKk1n7g2d4WH37bPsPndpQtwmJU+Zpq9WIIFVIILD45ePkIrLB90FQrFQH qas1Frr4pWnbkvcyyzMEQ53fNsEJjoCo0tQaluzkHzxGOw2xym+NxbGUl0YIXkaWFO t1AdRCYX4NpsQ== Date: Mon, 10 Feb 2025 10:22:44 -0600 MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: Chen Wang , linux-arm-kernel@lists.infradead.org, Sebastian Reichel , Conor Dooley , devicetree@vger.kernel.org, Haylen Chu , linux-pm@vger.kernel.org, Krzysztof Kozlowski , soc@lists.linux.dev, Arnd Bergmann , Will Deacon , Albert Ou , Inochi Amaoto , Palmer Dabbelt , linux-riscv@lists.infradead.org, Paul Walmsley , Philipp Zabel , Catalin Marinas , Lee Jones To: Alexander Sverdlin In-Reply-To: <20250209220646.1090868-1-alexander.sverdlin@gmail.com> References: <20250209220646.1090868-1-alexander.sverdlin@gmail.com> Message-Id: <173920412075.477254.10964125366963859194.robh@kernel.org> Subject: Re: [PATCH 00/10] arm64 support for Milk-V Duo Module 01 EVB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_082246_797905_21D258E7 X-CRM114-Status: GOOD ( 25.41 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, 09 Feb 2025 23:06:25 +0100, Alexander Sverdlin wrote: > This series adds very basic support for Milk-V Duo Module 01 EVB [1] in > arm64 mode. The SoC (SG2000) is dual-arch, RiscV and ARM64, the latter has > been chosen because the upstream toolchain can be utilized. > > Sophgo SG2000 seems to be a continuation of the Cvitek CV18xx series, same > peripherals with an addition of ARM64 core. Therefore it would be > beneficial not to copy-paste the peripherals' device-tree, but rather split > the most suitable riscv DT into ARCH-specific and peripherals parts and > just include the latter on the arm64 side. > > This series adds the device-tree for Milk-V Duo Module 01 EVB, which > in turn contains Milk-V Duo Module 01 (separate .dtsi) on it, which has > SG2000 SoC inside (separate .dtsi). > > This series has been tested with Sophgo-provided U-Boot binary [2]: it > boots from SD card, pinctrl, serial, GPIO drivers are functional (same > as for RiscV-based CV18xx SoCs). > New reset driver is provided as an alternative to the ATF PSCI handler, > which Sophgo only provides in binary form. > > Partial SoC documentation is available [3]. > > This series lacks the support of: > - USB > - Audio > - Ethernet > - WiFi > - Bluetooth > - eMMC > - Video > > It would probably make sense that the whole series would go into SOC tree, > even though technically nothing prevents the reboot/reset driver to come > in PM/reset tree. If everything would come together, `reboot` command would > work out of the box. > > [1] https://milkv.io/docs/duo/getting-started/duo-module-01 > [2] https://github.com/milkv-duo/duo-buildroot-sdk-v2/releases/ > [3] https://github.com/sophgo/sophgo-doc/releases/download/sg2000-trm-v1.01/sg2000_trm_en.pdf > > Alexander Sverdlin (10): > arm64: Add SOPHGO SOC family Kconfig support > riscv: dts: sophgo: cv18xx: Split into CPU core and peripheral parts > arm64: dts: sophgo: Add initial SG2000 SoC device tree > arm64: dts: sophgo: Add Duo Module 01 > arm64: dts: sophgo: Add Duo Module 01 Evaluation Board > dt-bindings: mfd: syscon: Add Cvitek CV18xx rtcsys core and ctrl > compatible > dt-bindings: reset: sophgo: Add CV18xx reset controller > riscv/arm64: dts: cv18xx: Add sysctl and reset nodes > power: reset: cv18xx: New driver > arm64: defconfig: Enable rudimentary Sophgo SG2000 support > > .../devicetree/bindings/mfd/syscon.yaml | 4 + > .../bindings/reset/sophgo,cv1800-reset.yaml | 38 ++ > MAINTAINERS | 1 + > arch/arm64/Kconfig.platforms | 12 + > arch/arm64/boot/dts/Makefile | 1 + > arch/arm64/boot/dts/sophgo/Makefile | 2 + > arch/arm64/boot/dts/sophgo/sg2000.dtsi | 79 +++++ > .../sophgo/sg2000_milkv_duo_module_01.dtsi | 84 +++++ > .../sophgo/sg2000_milkv_duo_module_01_evb.dts | 30 ++ > arch/arm64/configs/defconfig | 3 + > arch/riscv/boot/dts/sophgo/cv181x.dtsi | 2 +- > arch/riscv/boot/dts/sophgo/cv18xx-periph.dtsi | 329 ++++++++++++++++++ > arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 305 +--------------- > drivers/power/reset/Kconfig | 12 + > drivers/power/reset/Makefile | 1 + > drivers/power/reset/cv18xx-reset.c | 89 +++++ > 16 files changed, 689 insertions(+), 303 deletions(-) > create mode 100644 Documentation/devicetree/bindings/reset/sophgo,cv1800-reset.yaml > create mode 100644 arch/arm64/boot/dts/sophgo/Makefile > create mode 100644 arch/arm64/boot/dts/sophgo/sg2000.dtsi > create mode 100644 arch/arm64/boot/dts/sophgo/sg2000_milkv_duo_module_01.dtsi > create mode 100644 arch/arm64/boot/dts/sophgo/sg2000_milkv_duo_module_01_evb.dts > create mode 100644 arch/riscv/boot/dts/sophgo/cv18xx-periph.dtsi > create mode 100644 drivers/power/reset/cv18xx-reset.c > > -- > 2.48.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/sophgo/' for 20250209220646.1090868-1-alexander.sverdlin@gmail.com: arch/arm64/boot/dts/sophgo/sg2000_milkv_duo_module_01_evb.dtb: /: failed to match any schema with compatible: ['sophgo,sg2000'] arch/arm64/boot/dts/sophgo/sg2000_milkv_duo_module_01_evb.dtb: soc: soc-reset: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/simple-bus.yaml# arch/arm64/boot/dts/sophgo/sg2000_milkv_duo_module_01_evb.dtb: l2-cache: 'cache-unified' is a dependency of 'cache-size' from schema $id: http://devicetree.org/schemas/cache.yaml# arch/arm64/boot/dts/sophgo/sg2000_milkv_duo_module_01_evb.dtb: l2-cache: 'cache-unified' is a required property from schema $id: http://devicetree.org/schemas/cache.yaml# arch/arm64/boot/dts/sophgo/sg2000_milkv_duo_module_01_evb.dtb: l2-cache: Unevaluated properties are not allowed ('cache-level', 'cache-size' were unexpected) from schema $id: http://devicetree.org/schemas/cache.yaml# _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv