* [PATCH v1 3/6] spi: Remove the use of dev_err_probe()
2025-08-19 9:20 [PATCH v1 0/6] spi: Remove the use of dev_err_probe() Xichao Zhao
@ 2025-08-19 9:20 ` Xichao Zhao
2025-08-19 18:52 ` [PATCH v1 0/6] " Mark Brown
2025-10-09 1:07 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: Xichao Zhao @ 2025-08-19 9:20 UTC (permalink / raw)
To: Conor Dooley, Daire McNamara, Mark Brown,
open list:RISC-V MICROCHIP FPGA SUPPORT, open list:SPI SUBSYSTEM,
open list
Cc: Xichao Zhao
The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value instead.
Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
drivers/spi/spi-microchip-core-qspi.c | 3 +--
drivers/spi/spi-microchip-core.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-microchip-core-qspi.c b/drivers/spi/spi-microchip-core-qspi.c
index d13a9b755c7f..0a6f65c77eac 100644
--- a/drivers/spi/spi-microchip-core-qspi.c
+++ b/drivers/spi/spi-microchip-core-qspi.c
@@ -701,8 +701,7 @@ static int mchp_coreqspi_probe(struct platform_device *pdev)
ctlr = devm_spi_alloc_host(&pdev->dev, sizeof(*qspi));
if (!ctlr)
- return dev_err_probe(&pdev->dev, -ENOMEM,
- "unable to allocate host for QSPI controller\n");
+ return -ENOMEM;
qspi = spi_controller_get_devdata(ctlr);
platform_set_drvdata(pdev, qspi);
diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
index 62ba0bd9cbb7..9128b86c5366 100644
--- a/drivers/spi/spi-microchip-core.c
+++ b/drivers/spi/spi-microchip-core.c
@@ -534,8 +534,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
host = devm_spi_alloc_host(&pdev->dev, sizeof(*spi));
if (!host)
- return dev_err_probe(&pdev->dev, -ENOMEM,
- "unable to allocate host for SPI controller\n");
+ return -ENOMEM;
platform_set_drvdata(pdev, host);
--
2.34.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 0/6] spi: Remove the use of dev_err_probe()
2025-08-19 9:20 [PATCH v1 0/6] spi: Remove the use of dev_err_probe() Xichao Zhao
2025-08-19 9:20 ` [PATCH v1 3/6] " Xichao Zhao
@ 2025-08-19 18:52 ` Mark Brown
2025-10-09 1:07 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2025-08-19 18:52 UTC (permalink / raw)
To: Raju Rangoju, Sunny Luo, Xianwei Zhao, Conor Dooley,
Daire McNamara, Matthias Brugger, AngeloGioacchino Del Regno,
Daniel Mack, Haojian Zhuang, Robert Jarzmik, Andi Shyti,
Tudor Ambarus, Krzysztof Kozlowski, Alim Akhtar, linux-spi,
linux-kernel, linux-amlogic, linux-riscv, linux-arm-kernel,
linux-mediatek, linux-samsung-soc, Xichao Zhao
On Tue, 19 Aug 2025 17:20:37 +0800, Xichao Zhao wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
> remove the useless call to dev_err_probe(), and just return the value instead.
>
> Xichao Zhao (6):
> spi: spi_amd: Remove the use of dev_err_probe()
> spi: SPISG: Remove the use of dev_err_probe()
> spi: Remove the use of dev_err_probe()
> spi: mt65xx: Remove the use of dev_err_probe()
> spi: pxa2xx: Remove the use of dev_err_probe()
> spi: s3c64xx: Remove the use of dev_err_probe()
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/6] spi: spi_amd: Remove the use of dev_err_probe()
commit: 2a5d410916d3a8dcac06f72494f252314e933cfb
[2/6] spi: SPISG: Remove the use of dev_err_probe()
commit: 0d00ebc6b869f4df67c05522bc1e8d01d1c7daa7
[3/6] spi: Remove the use of dev_err_probe()
commit: b875b97017050b92c64273178a0b0d282ea67874
[4/6] spi: mt65xx: Remove the use of dev_err_probe()
commit: 2bee48c9d1cd1749922d0e2df54330c924e14a0e
[5/6] spi: pxa2xx: Remove the use of dev_err_probe()
commit: 67259af78219bdbdea00491f32b1c0971a33401e
[6/6] spi: s3c64xx: Remove the use of dev_err_probe()
commit: 27848c082ba0b22850fd9fb7b185c015423dcdc7
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 0/6] spi: Remove the use of dev_err_probe()
2025-08-19 9:20 [PATCH v1 0/6] spi: Remove the use of dev_err_probe() Xichao Zhao
2025-08-19 9:20 ` [PATCH v1 3/6] " Xichao Zhao
2025-08-19 18:52 ` [PATCH v1 0/6] " Mark Brown
@ 2025-10-09 1:07 ` patchwork-bot+linux-riscv
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-riscv @ 2025-10-09 1:07 UTC (permalink / raw)
To: Xichao Zhao
Cc: linux-riscv, Raju.Rangoju, broonie, sunny.luo, xianwei.zhao,
conor.dooley, daire.mcnamara, matthias.bgg,
angelogioacchino.delregno, daniel, haojian.zhuang, robert.jarzmik,
andi.shyti, tudor.ambarus, krzk, alim.akhtar, linux-spi,
linux-kernel, linux-amlogic, linux-arm-kernel, linux-mediatek,
linux-samsung-soc
Hello:
This patch was applied to riscv/linux.git (for-next)
by Mark Brown <broonie@kernel.org>:
On Tue, 19 Aug 2025 17:20:37 +0800 you wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
> remove the useless call to dev_err_probe(), and just return the value instead.
>
> Xichao Zhao (6):
> spi: spi_amd: Remove the use of dev_err_probe()
> spi: SPISG: Remove the use of dev_err_probe()
> spi: Remove the use of dev_err_probe()
> spi: mt65xx: Remove the use of dev_err_probe()
> spi: pxa2xx: Remove the use of dev_err_probe()
> spi: s3c64xx: Remove the use of dev_err_probe()
>
> [...]
Here is the summary with links:
- [v1,3/6] spi: Remove the use of dev_err_probe()
https://git.kernel.org/riscv/c/2aade32d1ffc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread