Re: [PATCH net-next v3 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac

From: "Rob Herring (Arm)" <robh@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-riscv@lists.infradead.org,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Andrew Lunn <andrew+netdev@lunn.ch>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Yao Zi <ziyao@disroot.org>,  Longbin Li <looong.bin@gmail.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	 Choong Yong Liang <yong.liang.choong@linux.intel.com>,
	 Yixun Lan <dlan@gentoo.org>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	 Jakub Kicinski <kuba@kernel.org>,
	devicetree@vger.kernel.org,  Paolo Abeni <pabeni@redhat.com>,
	Conor Dooley <conor+dt@kernel.org>,
	 Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	 Paul Walmsley <pjw@kernel.org>,
	 Alexandre Torgue <alexandre.torgue@foss.st.com>,
	 Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	 Boon Khai Ng <boon.khai.ng@altera.com>,
	 Yanteng Si <siyanteng@cqsoftware.com.cn>,
	spacemit@lists.linux.dev,
	 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	 Richard Cochran <richardcochran@gmail.com>,
	 Shangjuan Wei <weishangjuan@eswincomputing.com>,
	 Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org,  Chen-Yu Tsai <wens@kernel.org>,
	 Maxime Chevallier <maxime.chevallier@bootlin.com>,
	 "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	 Alexandre Ghiti <alex@ghiti.fr>,
	Jose Abreu <joabreu@synopsys.com>,
	 "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v3 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac
Date: Wed, 28 Jan 2026 04:52:29 -0600	[thread overview]
Message-ID: <176959754960.624625.3292309980701778789.robh@kernel.org> (raw)
In-Reply-To: <20260128072931.875041-2-inochiama@gmail.com>

On Wed, 28 Jan 2026 15:29:27 +0800, Inochi Amaoto wrote:
> The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare
> MAC (version 5.40a) with some extra clock.
> 
> Add necessary compatible string for this device.
> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml   |   2 +
>  .../bindings/net/spacemit,k3-dwmac.yaml       | 103 ++++++++++++++++++
>  2 files changed, 105 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.example.dtb: ethernet@cac80000 (spacemit,k3-dwmac): compatible: ['spacemit,k3-dwmac', 'snps,dwmac-5.40a'] does not contain items matching the given schema
	from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.example.dtb: ethernet@cac80000 (spacemit,k3-dwmac): compatible: ['spacemit,k3-dwmac', 'snps,dwmac-5.40a'] does not contain items matching the given schema
	from schema $id: http://devicetree.org/schemas/net/spacemit,k3-dwmac.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.example.dtb: ethernet@cac80000 (spacemit,k3-dwmac): Unevaluated properties are not allowed ('phy-handle', 'phy-mode' were unexpected)
	from schema $id: http://devicetree.org/schemas/net/spacemit,k3-dwmac.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260128072931.875041-2-inochiama@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv