From: Jia Wang <wangjia@ultrarisc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Jia Wang" <wangjia@ultrarisc.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
"Yao Zi" <me@ziyao.cc>
Subject: Re: [PATCH v2 1/2] dt-bindings: serial: update bindings of ultrarisc dp1000 uart
Date: Tue, 17 Mar 2026 09:29:22 +0800 [thread overview]
Message-ID: <177371096243.4115496.3239364895397658958@leopard> (raw)
In-Reply-To: <20260316-uptight-dachshund-of-grandeur-fbee0f@quoll>
On 2026-03-16 09:11 +0100, Krzysztof Kozlowski wrote:
> On Mon, Mar 16, 2026 at 02:33:22PM +0800, Jia Wang wrote:
> > Add DP1000 UART compatible information
>
> We see this from the diff. Why this is not compatible with
> snps,dw-apb-uart? What are the differences. You have entire commit msg
> to explain the hardware.
>
The UART controller in DP1000 is based on the Synopsys
DesignWare APB UART IP, but the hardware does not support
automatic FIFO size detection used by the generic driver.
I will update the commit message to clarify this.
> >
> > Signed-off-by: Jia Wang <wangjia@ultrarisc.com>
> > Reviewed-by: Yao Zi <me@ziyao.cc>
> > ---
> > Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > index 6efe43089a74..0040ed28e35b 100644
> > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > @@ -78,6 +78,8 @@ properties:
> > - starfive,jh7100-uart
> > - starfive,jh7110-uart
> > - const: snps,dw-apb-uart
> > + - items:
>
> Drop, not needed.
>
> > + - const: ultrarisc,dp1000-uart
> > - const: snps,dw-apb-uart
>
> So just enum with the snps one.
Understood. I will drop the items block and add
"ultrarisc,dp1000-uart" directly to the enum list in v3.
Best regards,
Jia
>
> Best regards,
> Krzysztof
>
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-17 1:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 6:33 [PATCH v2 0/2] serial: 8250_dw: Add support for UltraRISC DP1000 uart Jia Wang via B4 Relay
2026-03-16 6:33 ` [PATCH v2 1/2] dt-bindings: serial: update bindings of ultrarisc dp1000 uart Jia Wang via B4 Relay
2026-03-16 8:11 ` Krzysztof Kozlowski
2026-03-17 1:29 ` Jia Wang [this message]
2026-03-16 8:12 ` Krzysztof Kozlowski
2026-03-16 6:33 ` [PATCH v2 2/2] riscv: ultrarisc: 8250_dw: support DP1000 uart Jia Wang via B4 Relay
2026-03-16 11:35 ` Andy Shevchenko
2026-04-17 7:32 ` Jia Wang
2026-04-17 7:46 ` Andy Shevchenko
2026-04-20 5:27 ` Jia Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177371096243.4115496.3239364895397658958@leopard \
--to=wangjia@ultrarisc.com \
--cc=alex@ghiti.fr \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=me@ziyao.cc \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox