From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAECDC36007 for ; Fri, 21 Mar 2025 20:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4kweeas6AcJbSEyTwbY9FAAbZgr8BZP3TBZv3pSa9pY=; b=HFSFcW/xa/ze+C 7uYnMuPFhxu+jjn4ioF3iTmzfhKvnfkU9CWdOnQNRHnXzvhExtiD8mEcWnO5grbafaG+orzQIPvBt Ni4ThZrTyr1YVK1cyVrSlmtIlScHQs9iEECw2seNELAupLrE4+GLWMaNx/UiIJC8wleLHVmsZIs4y msl561Wpku3wXJaxS1yUI7HtCwm+wy9IOuNogeNhHaAGOpuMIEXpfKNxZypS4fxSsUGu5H2FXXftc 7QzvA07rY/WSTP+RP30JcuSNyuRGUh3E22HKF/cbFOt4KsfWpxxOn17marOS3G7v6KYm4LzDCewuO /CACNaOrNycjcFQEebDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tvjQt-0000000GGz9-2OwE; Fri, 21 Mar 2025 20:57:35 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tvjQq-0000000GGxn-38G5 for linux-riscv@lists.infradead.org; Fri, 21 Mar 2025 20:57:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=kd/LOXc2hK0rFV/RZv6EziZTaeljqABnxpQVD76cq5s=; b=yN k5RdcJr7nXPEYApyt0Sf4vKbvkk1NmIidaKI2PoZWMB+D1yiCgRvWSVG5pEN46soseD3v7ks81OF0 MnVROFbDhG6csm2yiE83Jk6CyRlCzzXgOQZRYdpSLn3CXV7qQPGhhjzuQbpVUnhyKq1CFxXljJdB9 B4W9vYeJvBrpXEw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1tvjQg-006ee0-6h; Fri, 21 Mar 2025 21:57:22 +0100 Date: Fri, 21 Mar 2025 21:57:22 +0100 From: Andrew Lunn To: =?iso-8859-1?Q?Th=E9o?= Lebrun Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Ferre , Claudiu Beznea , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Samuel Holland , Richard Cochran , Russell King , Thomas Bogendoerfer , Vladimir Kondratiev , Gregory CLEMENT , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mips@vger.kernel.org, Thomas Petazzoni , Tawfik Bayouk Subject: Re: [PATCH net-next 06/13] net: macb: simplify macb_probe() code touching match data Message-ID: <18adb857-35c8-4ef2-bfd2-ebe1dbdeaeea@lunn.ch> References: <20250321-macb-v1-0-537b7e37971d@bootlin.com> <20250321-macb-v1-6-537b7e37971d@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250321-macb-v1-6-537b7e37971d@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250321_135732_780747_A4DF802A X-CRM114-Status: UNSURE ( 7.16 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Mar 21, 2025 at 08:09:37PM +0100, Th=E9o Lebrun wrote: > Remove local variables clk_init and init. Those function pointers are > always equivalent to macb_config->clk_init and macb_config->init. > = > Also remove NULL checks on macb_config as it is always valid: > - either it is its default value &default_gem_config, > - or it got overridden using match data. I probably would of made this two patches. But otherwise it looks O.K. Andrew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv