From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D560C433F5 for ; Sun, 9 Oct 2022 12:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6xvuhgZTNWN8/LjVkA3k7XIOPX0SxgCGJdHVZrnuoi8=; b=yd8AuQOAP9vpiRy36l+acd6SPV jn8hrr4EdRe9xjAuISG5W8PNR/JggFCKo2wZroGdBtoFVVBbHL0WxS+wy/VUHAEq6FA5hGpOpuFnX lDB7j7myvDYY9c2/jUU4XEucu1O8lPKCUst4PqUURcYrUmd5J6JiDYMlQ2rmTNoluoNOLlq4+PdC4 R9j6R3+niJSQHb92s/FNiO/0PI0vzbvuM/anB45DSfjcgDeJ/8qA3rlCKlcgSthCEZj0QTirJmK99 itepvM/QCYaMCufWE9ivlHSyxepfE2KE9LhEQPv7kpAuEub6SUDT/GciNDLQehV0ziM6Dm9dGTvs/ CJtdhpnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohVaG-00FZba-50; Sun, 09 Oct 2022 12:39:08 +0000 Received: from mail.galaxycrow.de ([162.55.242.111]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohVaD-00FZah-D4 for linux-riscv@lists.infradead.org; Sun, 09 Oct 2022 12:39:06 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 82B9061866; Sun, 9 Oct 2022 14:38:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=galaxycrow.de; s=dkim; t=1665319139; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=d6mUxv+4rMdxCUE/xftUBw4Q6gPkeYMBuZIYtE6ZrQM=; b=I0qo+O3ZbG2GxEku3vz8bKwzhJBKe3TUINC6fOuGkNvsBdQj0pRUFHsAyeWM4R/guYBOiK 26KHFAHAjbo/SVkgRSnJjr2ToIsy2t9q7YeGzV/rYTKGkE5G9K0xC+BC29rEjyrOj/ULSJ zy2DMoAcC3TApHrE8WvX+sHOiDafLB8rZigeoBknPFFW/m0msKInkCo2SjPJsj+NXYfry2 f25KmTFKjQ2qc3XUwNGrL3RHhR6KmV+W56hCuzjZlwAPaRk1j8gdVLlYEEgGZ+PBLMF/0n 8L+KIoZo5qTGKHGknvkAN8NLR/mF3yEzhtX6YdCZs7rfiJpuu35xWXtA6U5IQA== From: Cleo John To: Conor Dooley Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixed styling in riscv ucontext header Date: Sun, 09 Oct 2022 14:38:43 +0200 Message-ID: <1923489.PYKUYFuaPT@watet-ms7b87> In-Reply-To: References: <20221009120340.GA41243@watet-ms7b87> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221009_053905_643926_511A167B X-CRM114-Status: GOOD ( 31.13 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5369013940182198119==" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org --===============5369013940182198119== Content-Type: multipart/signed; boundary="nextPart21645611.EfDdHjke4D"; micalg="pgp-sha512"; protocol="application/pgp-signature" --nextPart21645611.EfDdHjke4D Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Cleo John To: Conor Dooley Subject: Re: [PATCH] Fixed styling in riscv ucontext header Date: Sun, 09 Oct 2022 14:38:43 +0200 Message-ID: <1923489.PYKUYFuaPT@watet-ms7b87> In-Reply-To: MIME-Version: 1.0 Hey Connor, On Sun, 9. October 2022, 14:14:52 CEST, Conor Dooley wrote: > Hey Cleo, > > On Sun, Oct 09, 2022 at 02:03:40PM +0200, Cleo John wrote: > > Fixed styling in riscv ucontext header > > This should probably be "riscv: fix styling..." okay yea, I will change this in a second patch. > > This patch changes the two comments in ucontext.h by getting them up to > > the cody style proposed by torwalds. > s/This patch changes/Change > > Looks like some typos here too & your lines need to be wrapped at 72 > characters for commit messages. git usually enforces that automatically > when you do a `git commit`. I will wrap the lines, but where are the typos if I may ask? > > In my opinion this also improves the readability so I think this is a > > useful change to do. Please also tell me if you have a different opinion. > > FYI commentary on the patch should go below the ---. will note > > Signed-off-by: Cleo John > > --- > > > > arch/riscv/include/uapi/asm/ucontext.h | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/riscv/include/uapi/asm/ucontext.h > > b/arch/riscv/include/uapi/asm/ucontext.h index 44eb993950e5..0cd6f8616985 > > 100644 > > --- a/arch/riscv/include/uapi/asm/ucontext.h > > +++ b/arch/riscv/include/uapi/asm/ucontext.h > > @@ -18,7 +18,8 @@ struct ucontext { > > > > /* There's some padding here to allow sigset_t to be expanded in the > > Why fix the closing comment but leave the opening ones incorrect? > > Thanks, > Conor. I mixed the code style up with the one in net/ -will fix Thanks, Cleo. > > * future. Though this is unlikely, other architectures put uc_sigmask > > * at the end of this structure and explicitly state it can be > > > > - * expanded, so we didn't want to box ourselves in here. */ > > + * expanded, so we didn't want to box ourselves in here. > > + */ > > > > __u8 __unused[1024 / 8 - sizeof(sigset_t)]; > > /* We can't put uc_sigmask at the end of this structure because we need > > > > * to be able to expand sigcontext in the future. For example, the > > > > @@ -27,7 +28,8 @@ struct ucontext { > > > > * ucontext, so we're putting this at the end in order to allow for > > * infinite extensibility. Since we know this will be extended and we > > * assume sigset_t won't be extended an extreme amount, we're > > > > - * prioritizing this. */ > > + * prioritizing this. > > + */ > > > > struct sigcontext uc_mcontext; > > > > }; --nextPart21645611.EfDdHjke4D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE2nzORJA3JEiNR015AnApHozuxisFAmNCwNMACgkQAnApHozu xisufhAAlvSM5MWGEbowao+ZV4f6Xi+XnTXSAgkDnZmMi9bjvBL0AaaS8u9eq9bt EgWaVVkHbjw/zdwOERwUL51UNMy+NxN03whjKZ4JsL0Ei+1JtVtLfJNWY0DVouw5 zpj7Bd6s2CTOogDPLlVp443D5Hjf8+MGftk/7sn/fjonFOIwDlMWwlT6iaC1lEGp KNinD2NNJU16hws0H21GJpkGfuUcHk1S4nAdM4gacTuAS0L30fTH2qAPTK3rrzsx jhb7XIDFiTPaUCNtzu8MFb9hrzK8yiuet3tTY7sPomHrfcyMZGdGPZbHUe6/j2Yz EmjrDtwcXkWczHcDL8PzyH22beA8uF0aq5gDnO3DNjblKwxBPwLH9Q9dGMqdjzzn flOxHoRdvBh7yrbRcANZZqsH2S8vfEKr3E0VlAzHwHqrh+jhWK6vgNTeQ/AeVq9C +xf7x40NrOT1JyI7Znp407jWJnbtholyVUhwDOsan4avV8UNuB0NJYz9gFE3fkON t0PS3FIUUVgHf16bTR/2Kdpj5hAZpYPkyGWtKR3bOdzhCaZoA26HWOd9FMFok0fP oldCGGh+LQuUrplrlDDD32xSREIO4vMbXpqsFFHppesr2BUv9njs4gamd0xT7KYD OUJTFiAsaYzMEjaaM3wFYgu9YIlc4K7uckVARKY/Vsmg0U+kpEY= =eD/M -----END PGP SIGNATURE----- --nextPart21645611.EfDdHjke4D-- --===============5369013940182198119== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --===============5369013940182198119==--