From: <Conor.Dooley@microchip.com>
To: <catalin.marinas@arm.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<palmer@rivosinc.com>, <aou@eecs.berkeley.edu>,
<sudeep.holla@arm.com>, <will@kernel.org>,
<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<Daire.McNamara@microchip.com>, <Conor.Dooley@microchip.com>,
<niklas.cassel@wdc.com>, <damien.lemoal@opensource.wdc.com>,
<geert@linux-m68k.org>, <zong.li@sifive.com>, <kernel@esmil.dk>,
<hahnjo@hahnjo.de>, <guoren@kernel.org>, <anup@brainfault.org>,
<atishp@atishpatra.org>, <heiko@sntech.de>,
<philipp.tomsich@vrull.eu>, <robh@kernel.org>, <maz@kernel.org>,
<viresh.kumar@linaro.org>, <linux-riscv@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <Brice.Goglin@inria.fr>
Subject: Re: [PATCH v4 1/2] arm64: topology: move store_cpu_topology() to shared code
Date: Tue, 19 Jul 2022 11:51:04 +0000 [thread overview]
Message-ID: <198b0486-29e7-9729-d137-0470e93038fa@microchip.com> (raw)
In-Reply-To: <YtaYTgFDpGSsG+H0@arm.com>
On 19/07/2022 12:41, Catalin Marinas wrote:
> On Fri, Jul 15, 2022 at 06:51:55PM +0100, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> arm64's method of defining a default cpu topology requires only minimal
>> changes to apply to RISC-V also. The current arm64 implementation exits
>> early in a uniprocessor configuration by reading MPIDR & claiming that
>> uniprocessor can rely on the default values.
>>
>> This is appears to be a hangover from prior to '3102bc0e6ac7 ("arm64:
>> topology: Stop using MPIDR for topology information")', because the
>> current code just assigns default values for multiprocessor systems.
>>
>> With the MPIDR references removed, store_cpu_topolgy() can be moved to
>> the common arch_topology code.
>>
>> CC: stable@vger.kernel.org
>
> I'd quantify how far back you want this to go. IIUC based on the Fixes
> tag in the other patch, it should stop at 5.4. If you send a pull
> request instead and have a fixed commit id, you could add it as a
> prerequisite on the following patch without a cc stable here.
I guess a PR might be the easiest way for it anyway, so that both
yourself and Palmer could merge it?
>
> Either way:
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Thanks.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-07-19 11:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 17:51 [PATCH v4 0/2] Fix RISC-V's arch-topology reporting Conor Dooley
2022-07-15 17:51 ` [PATCH v4 1/2] arm64: topology: move store_cpu_topology() to shared code Conor Dooley
2022-07-19 11:41 ` Catalin Marinas
2022-07-19 11:51 ` Conor.Dooley [this message]
2022-07-19 12:00 ` Catalin Marinas
2022-07-26 8:10 ` Atish Patra
2022-07-15 17:51 ` [PATCH v4 2/2] riscv: topology: fix default topology reporting Conor Dooley
2022-07-26 8:24 ` Atish Patra
2022-07-16 13:35 ` [PATCH v4 0/2] Fix RISC-V's arch-topology reporting Conor.Dooley
2022-07-23 11:22 ` Conor.Dooley
2022-07-25 9:13 ` Will Deacon
2022-07-25 9:20 ` Conor.Dooley
2022-07-26 8:12 ` Atish Patra
2022-07-26 9:14 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198b0486-29e7-9729-d137-0470e93038fa@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Brice.Goglin@inria.fr \
--cc=Daire.McNamara@microchip.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=catalin.marinas@arm.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=hahnjo@hahnjo.de \
--cc=heiko@sntech.de \
--cc=kernel@esmil.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=philipp.tomsich@vrull.eu \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox