From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nick Hu <nick.hu@sifive.com>
Cc: conor+dt@kernel.org, krzk+dt@kernel.org,
Cyan Yang <cyan.yang@sifive.com>,
Samuel Holland <samuel.holland@sifive.com>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers
Date: Wed, 11 Jun 2025 09:20:08 +0200 [thread overview]
Message-ID: <19dd3d16-aadd-469c-a090-238baba14d4e@kernel.org> (raw)
In-Reply-To: <CAKddAkAyvRdAz9X_rCGgfdxD0Z_Q7sAt8e5nuJe7=s7G-Y3+AQ@mail.gmail.com>
On 11/06/2025 09:15, Nick Hu wrote:
> On Wed, Jun 11, 2025 at 2:57 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 11/06/2025 05:10, Nick Hu wrote:
>>> SiFive Domain Management controller includes the following components
>>> - SiFive Tile Management Controller
>>> - SiFive Cluster Management Controller
>>> - SiFive Core Complex Management Controller
>>>
>>> These controllers control the clock and power domain of the
>>> corresponding domain.
>>>
>>> However, Since we don't have a SoC specific compatible string yet, so
>>> add '- {}' for the first entry [1][2].
>>
>>
>> But you must have Soc specific compatible strings. See previous discussion.
>>
> Maybe I'm missing something, but since we don't have a SoC-specific compatible
> string yet, I thought we agreed to include a `- {}` as the first
> entry, along with an
> explanation in both the commit message and comments [1].
But your commit msg does not explain. You need to explain why you do not
have SoC specific compatibles. Saying "I do not have a SoC specific
compatible" is not an argument explaining why you do not have SoC
specific compatible.
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-06-11 7:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 3:10 [PATCH v2 0/3] Add SiFive power provider driver Nick Hu
2025-06-11 3:10 ` [PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers Nick Hu
2025-06-11 6:57 ` Krzysztof Kozlowski
2025-06-11 7:15 ` Nick Hu
2025-06-11 7:20 ` Krzysztof Kozlowski [this message]
2025-06-16 1:48 ` Nick Hu
2025-06-11 3:10 ` [PATCH v2 2/3] cpuidle: riscv-sbi: Work with the external pmdomain driver Nick Hu
2025-06-11 3:10 ` [PATCH v2 3/3] cpuidle: Add SiFive power provider Nick Hu
2025-06-11 22:09 ` kernel test robot
2025-06-11 23:11 ` kernel test robot
2025-06-12 1:16 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19dd3d16-aadd-469c-a090-238baba14d4e@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cyan.yang@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nick.hu@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).