From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C09CBC48BC4 for ; Tue, 20 Feb 2024 08:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AMxYr4w7Lqo+yaeWbYF0hEa6yJwJ0Wmf5Z8AMQheq8Q=; b=dEFNH1B/KqKKRf BhF9AMInqXyd7s2i2KeaZ25o+D1xbOePIprg90oVl1HHXjub/KH7uRKyfJaGvgxYWUae891XqfUSF s3MLXxyZ6VxqMzGPeMYguY3gV4YNSwR1mPnvIyQjXoUwxmPBhzK7tNc3vPWqIsNhudcVYzlH9c7pV FB4Mxt3e+4saN/0J0n+pFbsEIsNR42LfCtnvdnbrRV08lgqJ6CtJYBWENJAZ41ObxnofpxSI28DZD Brg5jwtvCnf4fdwUZ6wrOCGr4GLESXhgsF1nGzrV3bj2p0hlDm8W4l6pz/SvPM1jjp+PyrbDRQPsY Pf7ujQf71/F/K6126fmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcLEG-0000000Dd1V-0dJm; Tue, 20 Feb 2024 08:11:52 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcLED-0000000Dd0t-1Utr for linux-riscv@lists.infradead.org; Tue, 20 Feb 2024 08:11:50 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-51181d8f52fso6793849e87.3 for ; Tue, 20 Feb 2024 00:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708416706; x=1709021506; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YYB1k4O8sSvflbPHK49SeRBVqldixAxJYgn6/wXS50k=; b=Pm5MxMgpfPpdmydNVy0m0bp1j6KwodkERueErjG5ZkpFcjvBDsDIX7nmX2yreaCekO tpkYbpglh366fl+XyUtKTDTfnWOjMpwGzpJ0Sek2/4Dr3CfqpT9oQKxS/1NZUf255MJ+ WDa2pP6n9Wz4Mv9ETOoZJhJByNR8z9h7awZMgIPw6IUDgz8mggRfA4bVsAK1FWilOfXW vHRgwjmsbyS262HMEvruWnnDMa67o68Gpg50C0tVC891IXNBUJZEevUxb9eitHgmXL4a u2ZJsF0wNpuBtJk+yAwdFYwmFARRrlaFyaV1p+y0uOg5EsCliwm3sAiv+/q+xzcZXrjQ 2rvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708416706; x=1709021506; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YYB1k4O8sSvflbPHK49SeRBVqldixAxJYgn6/wXS50k=; b=EsV0l3fYt4nqDjZ0OIGh5HOjA/EdfjDDsQEmCtQqn/dm3QprU+xWfly8aawweUOuQ3 km5pP2lHfrCl11fKdS7C2SRKNTmQFi/J6QyAQJgF1O0csk8T0MqQg857ajBOtsOtISCL atcVf/pYPNyXmvKoqSlqb6YhTZgX4kS33mGiArpOoaIkGUaXyT94M+/NgKo8thqHxk4v YWkuMIKhJrRx3j7B8oUyeWAhLkYoDagdpycfGLQSf0FlKKIeZxCQKA1Oms6O5NMf8YWW E5Cm9gfVXhW765qwQyfGj9jh7fHpDBdzDkWVo7gb7KPTQwNe1bdHvWMKh0HcHLcrSCQ9 n1ug== X-Forwarded-Encrypted: i=1; AJvYcCXMqLZDJPhoVkVsgqYm1WjrtpsXsXNPI2zeQXoCj0OrOJG9KNN2Xfj2FNze1QdSjcDm4XgsfXync5DYeNFkSNdQdsiJay9tXKRYWzYjaLI1 X-Gm-Message-State: AOJu0YxVJcNcGMIAGQ6EOkEQC/qdGrDMAx7l5DuLF3yd+DPzopJKSz3n gHVVMlZxCrfemtPHGDS+guagVOW9xbdDTPG5QebMv/qx0eDxaGkBktA0JrrDtqY= X-Google-Smtp-Source: AGHT+IGnM55Q2ffumb5GN2tOwX+zvB1seJItc9/HMT8JvwK4u+qjQvl9MgM26QA7NiR50HtA8djMVg== X-Received: by 2002:ac2:58ce:0:b0:512:b069:f93a with SMTP id u14-20020ac258ce000000b00512b069f93amr3129960lfo.40.1708416705767; Tue, 20 Feb 2024 00:11:45 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.116]) by smtp.gmail.com with ESMTPSA id g1-20020a056000118100b00337d5cd0d8asm12573872wrx.90.2024.02.20.00.11.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Feb 2024 00:11:45 -0800 (PST) Message-ID: <1a11cee2-2ef1-4ce0-8cc1-63c6cc97863f@linaro.org> Date: Tue, 20 Feb 2024 09:11:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/6] dt-bindings: pinctrl: starfive: Add JH8100 pinctrl Content-Language: en-US To: Alex Soo , Linus Walleij , Bartosz Golaszewski , Hal Feng , Ley Foon Tan , Jianlong Huang , Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Drew Fustini Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20240220064246.467216-1-yuklin.soo@starfivetech.com> <20240220064246.467216-2-yuklin.soo@starfivetech.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240220064246.467216-2-yuklin.soo@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_001149_446450_A1E07C66 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 20/02/2024 07:42, Alex Soo wrote: > Add documentation and header file for JH8100 pinctrl driver. > > Signed-off-by: Alex Soo > --- RFC? Why isn't this patch ready for review? As requested, I will provide only brief review, not full one. ... > + > +properties: > + compatible: > + oneOf: Drop > + - items: > + - const: starfive,jh8100-aon-pinctrl > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + interrupt-controller: true > + > + gpio-controller: true > + > + '#gpio-cells': > + const: 2 > + > + gpio-ranges: > + maxItems: 1 > + > + wakeup-gpios: > + maxItems: 1 > + description: GPIO pin to be used for waking up the system from sleep mode. > + > + wakeup-source: > + maxItems: 1 > + description: to indicate pinctrl has wakeup capability. > + > +patternProperties: > + '-grp$': > + type: object > + additionalProperties: false > + patternProperties: > + '-pins$': > + type: object > + description: | > + A pinctrl node should contain at least one subnode representing the > + pinctrl groups available in the domain. Each subnode will list the > + pins it needs, and how they should be configured, with regard to > + muxer configuration, bias, input enable/disable, input schmitt > + trigger enable/disable, slew-rate and drive strength. > + allOf: > + - $ref: /schemas/pinctrl/pincfg-node.yaml > + - $ref: /schemas/pinctrl/pinmux-node.yaml > + additionalProperties: false NAK, nothing improved. .... > diff --git a/include/dt-bindings/pinctrl/starfive,jh8100-pinctrl.h b/include/dt-bindings/pinctrl/starfive,jh8100-pinctrl.h > new file mode 100644 > index 000000000000..055bac7eb2a6 > --- /dev/null > +++ b/include/dt-bindings/pinctrl/starfive,jh8100-pinctrl.h > @@ -0,0 +1,103 @@ > +/* SPDX-License-Identifier: GPL-2.0 OR MIT */ > +/* > + * Copyright (C) 2023-2024 StarFive Technology Co., Ltd. > + */ > + > +#ifndef __DT_BINDINGS_PINCTRL_STARFIVE_JH8100_H__ > +#define __DT_BINDINGS_PINCTRL_STARFIVE_JH8100_H__ > + > +/* sys_iomux_west pins */ > +#define PAD_GPIO0_W 0 > +#define PAD_GPIO1_W 1 NAK, read my comments. Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv